Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bump-2.6/+merge/118625
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/bug-899364
into lp:zorba.
Requested reviews:
Markos Zaharioudakis (markos-za)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691
Fixed bug #899364 (throw XQST0103 in case of
The proposal to merge lp:~zorba-coders/zorba/bug-899364 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691
--
https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691
There are additional revisions which have not been approved in review. Please
seek review and approval of these new revisions.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/bug-899364 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691
--
https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691
The proposal to merge lp:~zorba-coders/zorba/bug-899364 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691
--
https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-899364-2012-08-08T09-14-03.892Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job bug-899364-2012-08-08T09-14-03.892Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 2 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/bug-899364 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691
--
https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691
Review: Disapprove
There are several problems:
1. The new string pool is not thread-safe (the current one is)
2. The check made in ~StringPool() must be implemented in the new pool as well
3. Most of the time, the strings that are inserted in the pool are char *
strings (for example, during
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/bug-899364
into lp:zorba.
Requested reviews:
Markos Zaharioudakis (markos-za)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118727
Fixed bugs #899364 and 899363 (throw XQST0103 in case
The proposal to merge lp:~zorba-coders/zorba/bug-899364 into lp:zorba has been
updated.
Commit Message changed to:
Fixed bugs #899364 and 899363 (throw XQST0103 in case of non-distinct window
variables)
Fixed bug #899366 (enforce the type declaration of a window variable)
For more details,
Isn't the name of the clang C++ = clang++? Does MATCHES do partial or exact
matches?
--
https://code.launchpad.net/~davidagraf/zorba/detect-clang-properly/+merge/117994
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Match does partial matches. c++ --version does return much more then 'clang'
:-).
--
https://code.launchpad.net/~davidagraf/zorba/detect-clang-properly/+merge/117994
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Review: Approve
--
https://code.launchpad.net/~davidagraf/zorba/detect-clang-properly/+merge/117994
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bump-2.6-2012-08-08T14-59-08.364Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bump-2.6/+merge/118625
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job bump-2.6-2012-08-08T14-59-08.364Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bump-2.6/+merge/118625
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
The proposal to merge lp:~zorba-coders/zorba/bump-2.6 into lp:zorba has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bump-2.6/+merge/118625
--
https://code.launchpad.net/~zorba-coders/zorba/bump-2.6/+merge/118625
Your team
19 matches
Mail list logo