Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump-2.6 into lp:zorba

2012-08-08 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bump-2.6/+merge/118625 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-899364 into lp:zorba

2012-08-08 Thread Markos Zaharioudakis
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/bug-899364 into lp:zorba. Requested reviews: Markos Zaharioudakis (markos-za) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691 Fixed bug #899364 (throw XQST0103 in case of

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-899364 into lp:zorba

2012-08-08 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/bug-899364 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691 -- https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-899364 into lp:zorba

2012-08-08 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-899364 into lp:zorba

2012-08-08 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bug-899364 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691 -- https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-899364 into lp:zorba

2012-08-08 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/bug-899364 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691 -- https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-899364 into lp:zorba

2012-08-08 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-899364-2012-08-08T09-14-03.892Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-899364 into lp:zorba

2012-08-08 Thread Zorba Build Bot
Validation queue job bug-899364-2012-08-08T09-14-03.892Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-899364 into lp:zorba

2012-08-08 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-899364 into lp:zorba

2012-08-08 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bug-899364 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691 -- https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118691

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-08-08 Thread Markos Zaharioudakis
Review: Disapprove There are several problems: 1. The new string pool is not thread-safe (the current one is) 2. The check made in ~StringPool() must be implemented in the new pool as well 3. Most of the time, the strings that are inserted in the pool are char * strings (for example, during

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-899364 into lp:zorba

2012-08-08 Thread Markos Zaharioudakis
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/bug-899364 into lp:zorba. Requested reviews: Markos Zaharioudakis (markos-za) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-899364/+merge/118727 Fixed bugs #899364 and 899363 (throw XQST0103 in case

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-899364 into lp:zorba

2012-08-08 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/bug-899364 into lp:zorba has been updated. Commit Message changed to: Fixed bugs #899364 and 899363 (throw XQST0103 in case of non-distinct window variables) Fixed bug #899366 (enforce the type declaration of a window variable) For more details,

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/detect-clang-properly into lp:zorba

2012-08-08 Thread Paul J. Lucas
Isn't the name of the clang C++ = clang++? Does MATCHES do partial or exact matches? -- https://code.launchpad.net/~davidagraf/zorba/detect-clang-properly/+merge/117994 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/detect-clang-properly into lp:zorba

2012-08-08 Thread David Graf
Match does partial matches. c++ --version does return much more then 'clang' :-). -- https://code.launchpad.net/~davidagraf/zorba/detect-clang-properly/+merge/117994 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump-2.6 into lp:zorba

2012-08-08 Thread Cezar Andrei
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bump-2.6/+merge/118625 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/detect-clang-properly into lp:zorba

2012-08-08 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~davidagraf/zorba/detect-clang-properly/+merge/117994 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump-2.6 into lp:zorba

2012-08-08 Thread Sorin Marian Nasoi
The proposal to merge lp:~zorba-coders/zorba/bump-2.6 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bump-2.6/+merge/118625 -- https://code.launchpad.net/~zorba-coders/zorba/bump-2.6/+merge/118625 Your

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump-2.6 into lp:zorba

2012-08-08 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bump-2.6-2012-08-08T14-59-08.364Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bump-2.6/+merge/118625 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump-2.6 into lp:zorba

2012-08-08 Thread Zorba Build Bot
Validation queue job bump-2.6-2012-08-08T14-59-08.364Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bump-2.6/+merge/118625 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump-2.6 into lp:zorba

2012-08-08 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/bump-2.6 into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bump-2.6/+merge/118625 -- https://code.launchpad.net/~zorba-coders/zorba/bump-2.6/+merge/118625 Your team