Review: Needs Fixing
There is a memory leak in the implementation.
To check simply run
ctest -R url-
and look into the build/Testing/Temporary/LastTest.log.
Here is what you will see:
test xqxq/url-schema-resolver
[...]
=== end of result ===
testdriver: success (non-canonical result # 1
Review: Needs Fixing
- Regarding the dependency graph, could you please put it back yourself? I was
not able to do it myself as it was highly coupled with the old codebase.
It is NOT coupled with the old codebase at all.
Just revert all your changes in file doc/zorba/xqdoc/CMakeLists.txt.
--
Review: Needs Fixing
I have managed to create the documentation and the generation is very quick
(even after you add all the functionality I still think it will be quicker than
the old one).
I would have some remarks though:
1) the menu on the left in the modules.html page is broken:
here is
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/markos-scratch
into lp:zorba.
Commit message:
Fixed mustcopyInputNodes() method of no-copy, and jsoniq functions.
Requested reviews:
Markos Zaharioudakis (markos-za)
For more details, see:
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/markos-scratch-2012-10-05T08-59-43.74Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/128189
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
Validation queue job markos-scratch-2012-10-05T08-59-43.74Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/128189
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/markos-scratch
into lp:zorba.
Commit message:
Fixed bug #1062093 (bug in var reference iterators with an associated position
that is negative)
Requested reviews:
Markos Zaharioudakis (markos-za)
For more details, see:
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/128206
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/128206
--
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/markos-scratch-2012-10-05T10-20-45.902Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/128206
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
Validation queue job markos-scratch-2012-10-05T10-20-45.902Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/128206
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has
been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/128206
--
The proposal to merge lp:~zorba-coders/zorba/bug1053736 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1053736/+merge/126088
--
https://code.launchpad.net/~zorba-coders/zorba/bug1053736/+merge/126088
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug1053736-2012-10-05T15-26-47.637Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug1053736/+merge/126088
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job bug1053736-2012-10-05T15-26-47.637Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug1053736/+merge/126088
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/bug1053736 into lp:zorba has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1053736/+merge/126088
--
https://code.launchpad.net/~zorba-coders/zorba/bug1053736/+merge/126088
Your
16 matches
Mail list logo