Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba_FOTS_driver into lp:zorba

2012-11-08 Thread Sorin Marian Nasoi
The implementation looks very clean. I poked around a bit and ran several random test sets. The feeling I got is that it's not quite ready yet for merging. I would like to avoid waisting time when more people start using it and all run into the same issues. Before we continue, I would like

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070706 into lp:zorba

2012-11-08 Thread Ghislain Fourny
Ghislain Fourny has proposed merging lp:~zorba-coders/zorba/bug-1070706 into lp:zorba. Commit message: Fixes a bug that leads to a crash if there are inline, anonymous functions in a stack trace. Requested reviews: Markos Zaharioudakis (markos-za) Sorin Marian Nasoi (sorin.marian.nasoi)

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/image-module-dont-pass-svg-as-binary into lp:zorba/image-module

2012-11-08 Thread David Graf
- getImageFromString: const String aString, should be const String aString, Done - basic:convert-svg-impl should use basic:convert-svg-string I don't understand. Currently, convert-svg-string invokes convert-svg-impl. How should that work the other way round? - we might have to make sure the

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070706 into lp:zorba

2012-11-08 Thread Ghislain Fourny
The proposal to merge lp:~zorba-coders/zorba/bug-1070706 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1070706/+merge/133484 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070706 into lp:zorba

2012-11-08 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1070706-2012-11-08T14-10-43.793Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1070706/+merge/133484 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070706 into lp:zorba

2012-11-08 Thread Zorba Build Bot
Validation queue job bug-1070706-2012-11-08T14-10-43.793Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-1070706/+merge/133484 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070706 into lp:zorba

2012-11-08 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 3 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1070706/+merge/133484 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070706 into lp:zorba

2012-11-08 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bug-1070706 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1070706/+merge/133484 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070722 into lp:zorba

2012-11-08 Thread Ghislain Fourny
Ghislain Fourny has proposed merging lp:~zorba-coders/zorba/bug-1070722 into lp:zorba. Commit message: Fixing typo in the casting code which leads to a crash (confusion between type and code). Requested reviews: Sorin Marian Nasoi (sorin.marian.nasoi) Related bugs: Bug #1070722 in Zorba:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070706 into lp:zorba

2012-11-08 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1070706/+merge/133484 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070722 into lp:zorba

2012-11-08 Thread Ghislain Fourny
The proposal to merge lp:~zorba-coders/zorba/bug-1070722 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1070722/+merge/133492 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070722 into lp:zorba

2012-11-08 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1070722-2012-11-08T14-57-42.185Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1070722/+merge/133492 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070722 into lp:zorba

2012-11-08 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1070722/+merge/133492 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070706 into lp:zorba

2012-11-08 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1070706/+merge/133484 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070706 into lp:zorba

2012-11-08 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/bug-1070706 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1070706/+merge/133484 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070722 into lp:zorba

2012-11-08 Thread Zorba Build Bot
Validation queue job bug-1070722-2012-11-08T14-57-42.185Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-1070722/+merge/133492 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070706 into lp:zorba

2012-11-08 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1070706-2012-11-08T15-22-50.872Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1070706/+merge/133484 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070722 into lp:zorba

2012-11-08 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 2 Approve, 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1070722/+merge/133492 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867363-disable-http into lp:zorba

2012-11-08 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-867363-disable-http/+merge/133032 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070722 into lp:zorba

2012-11-08 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bug-1070722 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1070722/+merge/133492 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867363-disable-http into lp:zorba

2012-11-08 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/bug-867363-disable-http into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-867363-disable-http/+merge/133032 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070722 into lp:zorba

2012-11-08 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1070722/+merge/133492 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070722 into lp:zorba

2012-11-08 Thread Sorin Marian Nasoi
The proposal to merge lp:~zorba-coders/zorba/bug-1070722 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1070722/+merge/133492 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070706 into lp:zorba

2012-11-08 Thread Zorba Build Bot
Validation queue job bug-1070706-2012-11-08T15-22-50.872Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-1070706/+merge/133484 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070722 into lp:zorba

2012-11-08 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1070722-2012-11-08T15-48-44.053Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1070722/+merge/133492 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070722 into lp:zorba

2012-11-08 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/bug-1070722 into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1070722/+merge/133492 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1070722/+merge/133492

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867363-disable-http into lp:zorba

2012-11-08 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-867363-disable-http-2012-11-08T16-14-48.2Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-867363-disable-http/+merge/133032 Your team Zorba Coders is subscribed to branch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1070722 into lp:zorba

2012-11-08 Thread Zorba Build Bot
Validation queue job bug-1070722-2012-11-08T15-48-44.053Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-1070722/+merge/133492 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867363-disable-http into lp:zorba

2012-11-08 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/bug-867363-disable-http into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job bug-867363-disable-http-2012-11-08T16-14-48.2Z is

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867363-disable-http into lp:zorba

2012-11-08 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bug-867363-disable-http into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-867363-disable-http/+merge/133032 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867363-disable-http into lp:zorba

2012-11-08 Thread Chris Hillery
Fixed the broken test (path oversight), and added the test case for option-in-query text (forgot to bzr add it before). -- https://code.launchpad.net/~zorba-coders/zorba/bug-867363-disable-http/+merge/133032 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867363-disable-http into lp:zorba

2012-11-08 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-867363-disable-http into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-867363-disable-http/+merge/133032 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867363-disable-http into lp:zorba

2012-11-08 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-867363-disable-http-2012-11-08T22-01-03.465Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-867363-disable-http/+merge/133032 Your team Zorba Coders is subscribed to branch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867363-disable-http into lp:zorba

2012-11-08 Thread Zorba Build Bot
Validation queue job bug-867363-disable-http-2012-11-08T22-01-03.465Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-867363-disable-http/+merge/133032 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867363-disable-http into lp:zorba

2012-11-08 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/bug-867363-disable-http into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-867363-disable-http/+merge/133032 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

2012-11-08 Thread Cezar Andrei
Cezar Andrei has proposed merging lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba. Commit message: Add new nosql-db module. Requested reviews: Juan Zacarias (juan457) Matthias Brantner (matthias-brantner) Related bugs: Bug #1056953 in Zorba: NOSQL DB module

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

2012-11-08 Thread Cezar Andrei
The proposal to merge lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba has been updated. Commit Message changed to: Add new nosql-db module. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/133585 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

2012-11-08 Thread Cezar Andrei
The proposal to merge lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/133585 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

2012-11-08 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/f-nosql-db-trunk-2012-11-08T22-48-55.136Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/133585 Your team Zorba Coders is subscribed to branch lp:zorba. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

2012-11-08 Thread Cezar Andrei
Please review the code in https://code.launchpad.net/~zorba-coders/zorba/f-nosqldb-module for the new nosql-db module. -- https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/133585 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

2012-11-08 Thread Matthias Brantner
I don't like the name nosqldb-module because it's confusing/ambiguous. Would be nice if the name Oracle appeared there. -- https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/133585 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

2012-11-08 Thread Zorba Build Bot
Validation queue job f-nosql-db-trunk-2012-11-08T22-48-55.136Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/133585 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

2012-11-08 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/133585 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

2012-11-08 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/133585 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/image-module-dont-pass-svg-as-binary into lp:zorba/image-module

2012-11-08 Thread Matthias Brantner
On Nov 8, 2012, at 6:13 AM, David Graf david.g...@28msec.com wrote: - getImageFromString: const String aString, should be const String aString, Done - basic:convert-svg-impl should use basic:convert-svg-string I don't understand. Currently, convert-svg-string invokes convert-svg-impl. How

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba_FOTS_driver into lp:zorba

2012-11-08 Thread Chris Hillery
I agree with Sorin that the file naming is OK: I've had to teach myself to say FOTS driver when that's what I mean, rather than FOTS itself. The file naming as it is now is clear and consistent. I have no real opinion about .xqy - .xq. The test case CondExpr002 is passing currently (Matthias,

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1067028-no-json into lp:zorba

2012-11-08 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1067028-no-json/+merge/129743 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1067028-no-json into lp:zorba

2012-11-08 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/bug-1067028-no-json into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1067028-no-json/+merge/129743 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1067028-no-json into lp:zorba

2012-11-08 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: text conflict in src/compiler/rewriter/rules/type_rules.cpp -- https://code.launchpad.net/~zorba-coders/zorba/bug-1067028-no-json/+merge/129743 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1067028-no-json into lp:zorba

2012-11-08 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bug-1067028-no-json into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1067028-no-json/+merge/129743 --

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1075106 into lp:zorba

2012-11-08 Thread Paul J. Lucas
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/bug-1075106 into lp:zorba. Commit message: Fixed sign extension. Requested reviews: Zorba Coders (zorba-coders) Related bugs: Bug #1075106 in Zorba: big unsignedInts doesn't work on 32bit https://bugs.launchpad.net/zorba/+bug/1075106

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1075106 into lp:zorba

2012-11-08 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/bug-1075106/+merge/133612 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :