Review: Approve
It works, thanks!
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/169270
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/169270
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/169270
Your team
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/pjl-misc-2013-06-14T10-24-56.613Z/log.html
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/169270
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job pjl-misc-2013-06-14T10-24-56.613Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/169270
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/169270
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/169270
Your team Zorba
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/bug-1188061
into lp:zorba/stack-module.
Requested reviews:
Luis Rodriguez Gonzalez (kuraru)
Chris Hillery (ceejatec)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553
--
Review: Needs Information
Looks pretty good so far! A couple questions for Matthias since he wrote the
style guide:
1. Is this the correct way to use p for splitting doc paragraphs - wrapping
them in p.../p ? Or should there be single p / elements between
paragraphs?
2. Is this the correct
Also, Luis: Have you done any investigation to ensure that the documentation is
reasonable? In particular is the header comment clear, clean, and possibly have
an example or two?
And, can you verify that all reasonably-possible error conditions are
documented? At least, are there any other
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/bug-1187537 into
lp:zorba.
Commit message:
Eliminated MAX_PATH use on *nix (it's PATH_MAX there anyway). In sole
remaining use of PATH_MAX in fs::curdir(), its use is mitigated by increasing
the buffer size as needed.
Also cleaned-up
The proposal to merge lp:~paul-lucas/zorba/bug-1187537 into lp:zorba has been
updated.
Commit Message changed to:
Eliminated MAX_PATH use on *nix (it's PATH_MAX there anyway). In sole
remaining use of PATH_MAX in fs::curdir(), its use is mitigated by increasing
the buffer size as needed.
The proposal to merge lp:~paul-lucas/zorba/bug-1187537 into lp:zorba has been
updated.
Description changed to:
Eliminated MAX_PATH use on *nix (it's PATH_MAX there anyway). In sole
remaining use of PATH_MAX in fs::curdir(), its use is mitigated by increasing
the buffer size as needed.
Also
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1187537/+merge/169567
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~paul-lucas/zorba/bug-1187537 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/bug-1187537/+merge/169567
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1187537/+merge/169567
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-1187537-2013-06-15T00-26-48.915Z/log.html
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1187537/+merge/169567
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1, Needs Information 1, Resubmit 1. Got: 1
Approve.
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1187537/+merge/169567
Your team Zorba Coders is subscribed to branch lp:zorba.
--
The proposal to merge lp:~paul-lucas/zorba/bug-1187537 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/bug-1187537/+merge/169567
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1187537/+merge/169567
Could somebody having Windows please review this?
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1187537/+merge/169567
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Could somebody having Windows please review this?
Added Juan. So now you can approve it for Unix. :)
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1187537/+merge/169567
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to
The proposal to merge lp:~zorba-coders/zorba/bug-1067028 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1067028/+merge/169585
--
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-1067028-2013-06-15T03-03-10.364Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1067028/+merge/169585
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job bug-1067028-2013-06-15T03-03-10.364Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1067028/+merge/169585
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/bug-1067028 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1067028/+merge/169585
--
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1067028/+merge/169585
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1187537/+merge/169567
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1067028/+merge/169585
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-1067028-2013-06-15T05-23-02.276Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1067028/+merge/169585
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job bug-1067028-2013-06-15T05-23-02.276Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1067028/+merge/169585
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/bug-1067028 into lp:zorba has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1067028/+merge/169585
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1067028/+merge/169585
28 matches
Mail list logo