[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-06-19 Thread Markos Zaharioudakis
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/markos-scratch into lp:zorba. Commit message: Fixed bug #1188304 Requested reviews: Markos Zaharioudakis (markos-za) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/170288 Fixed bug

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-06-19 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/170288 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-06-19 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/170288 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-06-19 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/markos-scratch-2013-06-19T10-08-56.951Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/170288 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-06-19 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:281 (message): Validation queue job markos-scratch-2013-06-19T10-08-56.951Z is finished. The

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-06-19 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/170288 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-06-19 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/170288 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-06-19 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/markos-scratch-2013-06-19T11-02-01.275Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/170288 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-06-19 Thread Zorba Build Bot
Validation queue job markos-scratch-2013-06-19T11-02-01.275Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/170288 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-06-19 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/170288 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/correct_LP_bug_number into lp:zorba

2013-06-19 Thread Sorin Marian Nasoi
Sorin Marian Nasoi has proposed merging lp:~zorba-coders/zorba/correct_LP_bug_number into lp:zorba. Commit message: corrected LP bug number Requested reviews: Chris Hillery (ceejatec) Sorin Marian Nasoi (sorin.marian.nasoi) For more details, see:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/correct_LP_bug_number into lp:zorba

2013-06-19 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/correct_LP_bug_number/+merge/170309 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-06-19 Thread Cezar Andrei
Review: Needs Fixing Also, add a note on the module documentation section about using the header jsoniq version 1.0; at the top and put a link to a page that describes this header. -- https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579 Your team Zorba Coders is

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-06-19 Thread Cezar Andrei
timeout option has a bug. Uncomment timeout in the following script and get this error: $ ./zorba -i -f -q q.jq error [zerr:ZSTR0040]: type error: Item::getIntValue() not defined for type xs:integer jsoniq version 1.0; import module namespace http=http://zorba.io/modules/http-client;;

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/correct_LP_bug_number into lp:zorba

2013-06-19 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/correct_LP_bug_number/+merge/170309 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/correct_LP_bug_number into lp:zorba

2013-06-19 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/correct_LP_bug_number into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/correct_LP_bug_number/+merge/170309 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/correct_LP_bug_number into lp:zorba

2013-06-19 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/correct_LP_bug_number-2013-06-19T16-55-49.759Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/correct_LP_bug_number/+merge/170309 Your team Zorba Coders is subscribed to branch lp:zorba.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-06-19 Thread Chris Hillery
Also, add a note on the module documentation section about using the header jsoniq version 1.0; at the top and put a link to a page that describes this header. Cezar, it is not necessary for users to have a jsoniq version header in their queries to use this module. They can use (field) object

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-06-19 Thread Cezar Andrei
Cezar, it is not necessary for users to have a jsoniq version header in their queries to use this module. They can use (field) object accessors instead of .field . My point was to mention these options somewhere in the doc and link to a page which better describes this. IMHO it's confusing if

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/correct_LP_bug_number into lp:zorba

2013-06-19 Thread Zorba Build Bot
Validation queue job correct_LP_bug_number-2013-06-19T16-55-49.759Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/correct_LP_bug_number/+merge/170309 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/correct_LP_bug_number into lp:zorba

2013-06-19 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/correct_LP_bug_number into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/correct_LP_bug_number/+merge/170309 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-06-19 Thread Matthias Brantner
timeout option has a bug. Uncomment timeout in the following script and get this error: $ ./zorba -i -f -q q.jq error [zerr:ZSTR0040]: type error: Item::getIntValue() not defined for type xs:integer jsoniq version 1.0; import module namespace http=http://zorba.io/modules/http-client;;

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2013-06-19 Thread Matthias Brantner
Review: Needs Information - I think we should remove the examples 7 and 8. The tests don't make sense anymore - Is it possible to avoid the string copy in line 338 of the diff (s = t.get_value())? - The csharp, php, ruby, and python tests can also be removed - What's the performance gain? --

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2013-06-19 Thread Paul J. Lucas
- I removed examples 7 8. - The string copy isn't a copy: it's just a ref-count increment. Regardless, it's gone. - Which c#, php, ruby, and python tests? While file(s)? Please be specific. - I don't know what the perf. gain is. --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-06-19 Thread Markos Zaharioudakis
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/markos-scratch into lp:zorba. Commit message: fixed bug in casting to xs:NCName + fixed bug in computed PI constructor Requested reviews: Markos Zaharioudakis (markos-za) For more details, see:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-06-19 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/170429 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-06-19 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/170429 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-06-19 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/markos-scratch-2013-06-19T19-41-57.53Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/170429 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-06-19 Thread Zorba Build Bot
Validation queue job markos-scratch-2013-06-19T19-41-57.53Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/170429 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

2013-06-19 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/170429 --

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2013-06-19 Thread Matthias Brantner
- Which c#, php, ruby, and python tests? While file(s)? Please be specific. swig/csharp/tests/test10.cs swig/php/tests/test11.php swig/python/tests/test13.py swig/ruby/tests/test13.rb - I don't know what the perf. gain is. Maybe it would be worth finding out. --

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2013-06-19 Thread Paul J. Lucas
Tests removed. The point of this MP was to remove the confusing createJSONNumber(). The performance has probably improved slightly due to removing an extra virtual function call. If you want to find out more, you're free to run some tests. --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_info-extraction-module into lp:zorba/info-extraction-module

2013-06-19 Thread Juan Zacarias
Juan Zacarias has proposed merging lp:~zorba-coders/zorba/update3.0_info-extraction-module into lp:zorba/info-extraction-module. Commit message: Update to 3.0 Requested reviews: Chris Hillery (ceejatec) Related bugs: Bug #1188043 in Zorba: Update non-core module info-extraction

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1189636 into lp:zorba

2013-06-19 Thread Paul J. Lucas
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/bug-1189636 into lp:zorba. Commit message: * Added hexbinary::streambuf and friends. * Fixed buffer overflow bug in base64::streambuf::xsputn(). Requested reviews: Paul J. Lucas (paul-lucas) Related bugs: Bug #1189636 in Zorba:

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1189636 into lp:zorba

2013-06-19 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/bug-1189636/+merge/170471 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1189636 into lp:zorba

2013-06-19 Thread Matthias Brantner
Unfortunately, I will not be able to review this until next week. Hence, I have added Federico who can do the review and immediately use the streambuffer inside the new http-client module. -- https://code.launchpad.net/~paul-lucas/zorba/bug-1189636/+merge/170471 Your team Zorba Coders is

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1189636 into lp:zorba

2013-06-19 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/bug-1189636/+merge/170471 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2013-06-19 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/170225 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2013-06-19 Thread Matthias Brantner
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/170225 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/170225 Your team

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2013-06-19 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/pjl-misc-2013-06-20T01-32-57.426Z/log.html -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/170225 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2013-06-19 Thread Zorba Build Bot
Validation queue job pjl-misc-2013-06-20T01-32-57.426Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/170225 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2013-06-19 Thread noreply
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/170225 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/170225 Your team Zorba