Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1027142-process-leak into lp:zorba/process-module

2012-07-26 Thread Luis Rodriguez Gonzalez
Review: Approve All seems to be alright. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1027142-process-leak/+merge/116102 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-archive-dateTime into lp:zorba

2012-08-02 Thread Luis Rodriguez Gonzalez
Review: Needs Fixing There's a bug that arises in Windows in archive_module.cpp lines 309 to 312 from this if (theCompression != GZIP #ifndef WIN32 theCompression != BZIP2 theCompression != LZMA #endif ) to this if (theCompression != GZIP #ifndef

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-archive-dateTime into lp:zorba/archive-module

2012-08-03 Thread Luis Rodriguez Gonzalez
Review: Approve Seems good -- https://code.launchpad.net/~zorba-coders/zorba/fix-archive-dateTime/+merge/118036 Your team Zorba Coders is subscribed to branch lp:zorba/archive-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-archive-dateTime into lp:zorba/archive-module

2012-08-03 Thread Luis Rodriguez Gonzalez
The proposal to merge lp:~zorba-coders/zorba/fix-archive-dateTime into lp:zorba/archive-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix-archive-dateTime/+merge/118036 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-archive-module into lp:zorba

2012-08-07 Thread Luis Rodriguez Gonzalez
Review: Approve Seems OK. -- https://code.launchpad.net/~zorba-coders/zorba/add-archive-module/+merge/116086 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-archive-module into lp:zorba

2012-08-07 Thread Luis Rodriguez Gonzalez
The proposal to merge lp:~zorba-coders/zorba/add-archive-module into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/add-archive-module/+merge/116086 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/1025564 into lp:zorba

2012-08-16 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/1025564 into lp:zorba. Requested reviews: Chris Hillery (ceejatec) Related bugs: Bug #1025564 in Zorba: Deprecate -f argument to zorbacmd https://bugs.launchpad.net/zorba/+bug/1025564 For more details, see: https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/undo-10989 into lp:zorba

2012-08-17 Thread Luis Rodriguez Gonzalez
The proposal to merge lp:~zorba-coders/zorba/undo-10989 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/undo-10989/+merge/120245 -- https://code.launchpad.net/~zorba-coders/zorba/undo-10989/+merge/120245

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/archive-module-winfixes into lp:zorba/archive-module

2012-08-20 Thread Luis Rodriguez Gonzalez
Review: Approve Looks fine. -- https://code.launchpad.net/~zorba-coders/zorba/archive-module-winfixes/+merge/120438 Your team Zorba Coders is subscribed to branch lp:zorba/archive-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1040558 into lp:zorba

2012-08-27 Thread Luis Rodriguez Gonzalez
The proposal to merge lp:~zorba-coders/zorba/bug-1040558 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1040558/+merge/120956 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1040558 into lp:zorba

2012-08-27 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1040558/+merge/120956 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/1039576 into lp:zorba/archive-module

2012-09-06 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/1039576 into lp:zorba/archive-module. Requested reviews: Matthias Brantner (matthias-brantner) Related bugs: Bug #1039576 in Zorba: archive module doesnt create directory entries https://bugs.launchpad.net/zorba/+bug

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-for-sqlite into lp:zorba

2012-12-10 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/zorba-for-sqlite into lp:zorba. Requested reviews: Matthias Brantner (matthias-brantner) Chris Hillery (ceejatec) Rodolfo Ochoa (rodolfo-ochoa) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1091844 into lp:zorba

2012-12-18 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug1091844/+merge/140539 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-for-sqlite into lp:zorba

2012-12-19 Thread Luis Rodriguez Gonzalez
I fixed the problems Chris pointed out. Please review. -- https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba

2012-12-20 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/zorba-windows-fixes into lp:zorba. Requested reviews: Rodolfo Ochoa (rodolfo-ochoa) Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/zorba-windows-fixes/+merge/141005 - Fixes

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/1039576 into lp:zorba/archive-module

2012-12-21 Thread Luis Rodriguez Gonzalez
- Added documentation changes to include entry@type attribute. -- https://code.launchpad.net/~zorba-coders/zorba/1039576/+merge/123170 Your team Zorba Coders is subscribed to branch lp:zorba/archive-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-for-sqlite into lp:zorba

2013-01-04 Thread Luis Rodriguez Gonzalez
A new SQLite module version is now uploaded. I fixed most of the problems but I'm still testing out things. -- https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba

2013-01-08 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/sqlite-with-file-access into lp:zorba/sqlite-module

2013-01-24 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/sqlite-with-file-access/+merge/144641 Your team Zorba Coders is subscribed to branch lp:zorba/sqlite-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/sqlite-with-file-access into lp:zorba/sqlite-module

2013-01-24 Thread Luis Rodriguez Gonzalez
The proposal to merge lp:~zorba-coders/zorba/sqlite-with-file-access into lp:zorba/sqlite-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/sqlite-with-file-access/+merge/144641 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/sqlite-check-for-metadata-availability into lp:zorba/sqlite-module

2013-01-25 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/sqlite-check-for-metadata-availability into lp:zorba/sqlite-module. Requested reviews: Chris Hillery (ceejatec) Related bugs: Bug #1102549 in Zorba: SQLite module doesn't link on MacOS https://bugs.launchpad.net/zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/archive-module-winfixes into lp:zorba/archive-module

2013-02-18 Thread Luis Rodriguez Gonzalez
I just updated the branch. -- https://code.launchpad.net/~zorba-coders/zorba/archive-module-winfixes/+merge/120438 Your team Zorba Coders is subscribed to branch lp:zorba/archive-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1130998 into lp:zorba

2013-04-02 Thread Luis Rodriguez Gonzalez
I followed Nicolae's suggestions but still I get the same problems. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1130998/+merge/156700 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/1025564 into lp:zorba

2013-04-08 Thread Luis Rodriguez Gonzalez
Comments fixed, please re-review. -- https://code.launchpad.net/~zorba-coders/zorba/1025564/+merge/125256 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/sqlite-check-for-metadata-availability into lp:zorba/sqlite-module

2013-04-08 Thread Luis Rodriguez Gonzalez
I think this branch is corrected as Chris suggested. Please re-review. -- https://code.launchpad.net/~zorba-coders/zorba/sqlite-check-for-metadata-availability/+merge/145041 Your team Zorba Coders is subscribed to branch lp:zorba/sqlite-module. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-04-18 Thread Luis Rodriguez Gonzalez
As for the error condition, I've been thinking about it more, and I'm pretty sure that uri:serialize() needs to enforce at least the following rules: 1. You can specify opaque-part, OR some subset of host/port/path/user- info/query. Not both. (Put another way: If opaque-part is specified,

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1015468 into lp:zorba

2013-04-30 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/bug-1015468 into lp:zorba. Requested reviews: Chris Hillery (ceejatec) Related bugs: Bug #1015468 in Zorba: wrong uri resolution with fn:resolve-uri() https://bugs.launchpad.net/zorba/+bug/1015468 For more details, see

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1015468 into lp:zorba

2013-05-01 Thread Luis Rodriguez Gonzalez
I followed Chris' suggestion and now we use the full path to build the reference in the case when we don't have a path in the relative URI. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1015468/+merge/161712 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-05-01 Thread Luis Rodriguez Gonzalez
I will include the 3 different errors for uri:serialize(), Should I leave uri:parse() without any error code? I'm sure there are some reasonable errors for uri:parse(), but I'm not totally sure what they might be. It's possible that URI.cpp will already throw some exceptions if you try to

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-05-01 Thread Luis Rodriguez Gonzalez
There are still some test failures. serialize-direct-uris now throws ZURI errors, which is good, but the test needs to be adapted for that (split the failing cases into separate tests with a .spec file containing the Error: you expect). More worrying, FOTS/fn-resolve-uri is failing. I'm

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-05-02 Thread Luis Rodriguez Gonzalez
- Could you give an example in the documentation of uri:parse and show a resulting URI object? Done - The names of the variables are all upper-case. I know that we don't have any coding conventions for it but the names in the full-text module are all lower- case. Should we be consistent here?

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1015468 into lp:zorba

2013-05-03 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1015468/+merge/161712 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump-2.9 into lp:zorba

2013-05-07 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bump-2.9/+merge/162732 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump-2.9 into lp:zorba

2013-05-07 Thread Luis Rodriguez Gonzalez
The proposal to merge lp:~zorba-coders/zorba/bump-2.9 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bump-2.9/+merge/162732 -- https://code.launchpad.net/~zorba-coders/zorba/bump-2.9/+merge/162732 Your

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/prune-test-dir into lp:zorba

2013-05-14 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/prune-test-dir/+merge/163672 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1181360 into lp:zorba

2013-05-31 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/bug-1181360 into lp:zorba. Requested reviews: Luis Rodriguez Gonzalez (kuraru) Cezar Andrei (cezar-andrei) Related bugs: Bug #1181360 in Zorba: validation leaks exception https://bugs.launchpad.net/zorba/+bug/1181360

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/1181360 into lp:zorba

2013-06-05 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/1181360 into lp:zorba. Requested reviews: Luis Rodriguez Gonzalez (kuraru) Cezar Andrei (cezar-andrei) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/1181360/+merge/167690 -- https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188061 into lp:zorba/stack-module

2013-06-14 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/bug-1188061 into lp:zorba/stack-module. Requested reviews: Luis Rodriguez Gonzalez (kuraru) Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553 -- https

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188061 into lp:zorba/stack-module

2013-06-17 Thread Luis Rodriguez Gonzalez
The documentation has several mentions to tests that are included but no textual representations are made, Should I move some of the examples to the code instead of sending the user to check the tests? Aside from that the documentation seems to be pretty straight forward and all the errors that I

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module

2013-06-17 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module. Requested reviews: Luis Rodriguez Gonzalez (kuraru) Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1188062/+merge/169946 -- https

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module

2013-07-05 Thread Luis Rodriguez Gonzalez
See the updated task description on the bug report. Also, see the updated coding guidelines for p and error codes. Documentation and code problems fixed, please check it again. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1188062/+merge/169946 Your team Zorba Coders is subscribed to

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188061 into lp:zorba/stack-module

2013-07-05 Thread Luis Rodriguez Gonzalez
After that, I'm afraid we've got some more substantive changes to be made to JSON-ify this module. I'll update the bug with details. If you'd like, we could merge this first pass (after you've addressed the coding guidelines issues) and then have a separate proposal for the JSONiq updates;

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188061 into lp:zorba/stack-module

2013-07-16 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553 Your team Zorba Coders is subscribed to branch lp:zorba/stack-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188061 into lp:zorba/stack-module

2013-07-16 Thread Luis Rodriguez Gonzalez
The proposal to merge lp:~zorba-coders/zorba/bug-1188061 into lp:zorba/stack-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module

2013-07-16 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1188062/+merge/169946 Your team Zorba Coders is subscribed to branch lp:zorba/queue-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module

2013-07-16 Thread Luis Rodriguez Gonzalez
The proposal to merge lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1188062/+merge/169946 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-nosql into lp:zorba/oracle-nosql-db-module

2013-07-17 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-nosql/+merge/175214 Your team Zorba Coders is subscribed to branch lp:zorba/oracle-nosql-db-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-oauth into lp:zorba/oauth-module

2013-07-17 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-oauth/+merge/175217 Your team Zorba Coders is subscribed to branch lp:zorba/oauth-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-core into lp:zorba

2013-07-17 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-core/+merge/175204 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-archive into lp:zorba/archive-module

2013-07-17 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-archive/+merge/175215 Your team Zorba Coders is subscribed to branch lp:zorba/archive-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189785-csv into lp:zorba/csv-module

2013-07-17 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189785-csv/+merge/175208 Your team Zorba Coders is subscribed to branch lp:zorba/csv-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189794-core into lp:zorba

2013-07-17 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189794-core/+merge/175224 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189794-core into lp:zorba

2013-07-17 Thread Luis Rodriguez Gonzalez
The proposal to merge lp:~zorba-coders/zorba/bug-1189794-core into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189794-core/+merge/175224 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189794-oauth into lp:zorba/oauth-module

2013-07-17 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189794-oauth/+merge/175236 Your team Zorba Coders is subscribed to branch lp:zorba/oauth-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189794-oauth into lp:zorba/oauth-module

2013-07-17 Thread Luis Rodriguez Gonzalez
The proposal to merge lp:~zorba-coders/zorba/bug-1189794-oauth into lp:zorba/oauth-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189794-oauth/+merge/175236 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188033 into lp:zorba/archive-module

2013-07-25 Thread Luis Rodriguez Gonzalez
Also, you have at least one /p typo in archive.xq. Always remember to run ctest -R moduleDocumentation before committing, to be sure that your XQDoc is syntactically correct and that you didn't forget to document any parameters, etc. Done. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188033 into lp:zorba/archive-module

2013-07-26 Thread Luis Rodriguez Gonzalez
You didn't actually create singleton zorba::Items for the JSON object key strings. Using C++ #defines isn't the same. This code will still create a separate zorba::Item for the string name for every single entry in every archive passed to a:entries(). I used #defines only for the strings that

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189784 into lp:zorba/sqlite-module

2013-07-29 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/bug-1189784 into lp:zorba/sqlite-module. Requested reviews: Luis Rodriguez Gonzalez (kuraru) Chris Hillery (ceejatec) Related bugs: Bug #1189784 in Zorba: Update non-core module sqlite https://bugs.launchpad.net/zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188033 into lp:zorba/archive-module

2013-07-29 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1188033/+merge/176523 Your team Zorba Coders is subscribed to branch lp:zorba/archive-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189784 into lp:zorba/sqlite-module

2013-07-29 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189784/+merge/177489 Your team Zorba Coders is subscribed to branch lp:zorba/sqlite-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188033 into lp:zorba/archive-module

2013-07-29 Thread Luis Rodriguez Gonzalez
The proposal to merge lp:~zorba-coders/zorba/bug-1188033 into lp:zorba/archive-module has been updated. Commit Message changed to: JSONiqfication for Archive Module Done. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1188033/+merge/176523 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189784 into lp:zorba/sqlite-module

2013-07-29 Thread Luis Rodriguez Gonzalez
The proposal to merge lp:~zorba-coders/zorba/bug-1189784 into lp:zorba/sqlite-module has been updated. Commit Message changed to: JSONiqfication for Sqlite Module Done! For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189784/+merge/177489 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189807 into lp:zorba

2013-07-31 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189807/+merge/176627 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188058 into lp:zorba

2013-08-02 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/bug-1188058 into lp:zorba. Requested reviews: Luis Rodriguez Gonzalez (kuraru) Chris Hillery (ceejatec) Related bugs: Bug #1188058 in Zorba: Update non-core module system https://bugs.launchpad.net/zorba/+bug/1188058

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189807-html into lp:zorba/html-module

2013-08-07 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189807-html/+merge/176636 Your team Zorba Coders is subscribed to branch lp:zorba/html-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188058 into lp:zorba/system-module

2013-08-07 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1188058/+merge/178905 Your team Zorba Coders is subscribed to branch lp:zorba/system-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188058 into lp:zorba/system-module

2013-08-08 Thread Luis Rodriguez Gonzalez
Looks very good, nice work. However, the moduleDocumentation test doesn't pass, so there must be a typo somewhere in the XQDoc. Also, I suspect once you fix that, it will complain that all those public variable declarations need to have XQDoc; you'll probably need to restore the doc from the

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188042 into lp:zorba/excel-module

2013-08-23 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1188042/+merge/181152 Your team Zorba Coders is subscribed to branch lp:zorba/excel-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188056 into lp:zorba/security-module

2013-08-29 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1188056/+merge/182790 Your team Zorba Coders is subscribed to branch lp:zorba/security-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188056 into lp:zorba/security-module

2013-08-29 Thread Luis Rodriguez Gonzalez
1. sha256 test failures. 2. There are error codes thrown like hmac:unsupported-algorithm; they should be like hmac:UNSUPPORTED_ALGORITHM, and the XQDoc should be updated accordingly. both errors are fixed now. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1188056/+merge/182790 Your

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188041 into lp:zorba/data-formatting-module

2013-08-29 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/bug-1188041 into lp:zorba/data-formatting-module. Requested reviews: Chris Hillery (ceejatec) Luis Rodriguez Gonzalez (kuraru) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1188041/+merge/183023

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189806 into lp:zorba

2013-09-02 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/bug-1189806 into lp:zorba. Requested reviews: Luis Rodriguez Gonzalez (kuraru) Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189806/+merge/183528 -- https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189803 into lp:zorba

2013-09-10 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/bug-1189803 into lp:zorba. Requested reviews: Luis Rodriguez Gonzalez (kuraru) Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189803/+merge/184872 -- https

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189803 into lp:zorba

2013-09-18 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189803/+merge/184872 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/1181360 into lp:zorba

2013-09-19 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/1181360/+merge/167690 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189806 into lp:zorba

2013-09-19 Thread Luis Rodriguez Gonzalez
The proposal to merge lp:~zorba-coders/zorba/bug-1189806 into lp:zorba has been updated. Commit Message changed to: Changes for Zorba 3.0 for URI internal module. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189806/+merge/183528 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189803 into lp:zorba

2013-09-19 Thread Luis Rodriguez Gonzalez
Actually there's a lot more work to be done here - updating test cases, documentation, static_context... I changed all ocurrences of the uri except for the ones in Changelog. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189803/+merge/184872 Your team Zorba Coders is subscribed to

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188056 into lp:zorba/security-module

2013-09-19 Thread Luis Rodriguez Gonzalez
The proposal to merge lp:~zorba-coders/zorba/bug-1188056 into lp:zorba/security-module has been updated. Commit Message changed to: Changes for Zorba 3.0 for security internal module. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1188056/+merge/182790 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188041 into lp:zorba/data-formatting-module

2013-09-19 Thread Luis Rodriguez Gonzalez
The proposal to merge lp:~zorba-coders/zorba/bug-1188041 into lp:zorba/data-formatting-module has been updated. Commit Message changed to: Changes for Zorba 3.0 for data formatting internal module. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1188041/+merge/183023

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188041 into lp:zorba/data-formatting-module

2013-09-19 Thread Luis Rodriguez Gonzalez
I think it makes sense to remove the Deprecated functions entirely at this point. Deprecated function is now removed. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1188041/+merge/183023 Your team Zorba Coders is subscribed to branch lp:zorba/data-formatting-module. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188056-oauth into lp:zorba/oauth-module

2013-09-20 Thread Luis Rodriguez Gonzalez
The proposal to merge lp:~zorba-coders/zorba/bug-1188056-oauth into lp:zorba/oauth-module has been updated. Commit Message changed to: hmac uri changed for the new one. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1188056-oauth/+merge/186874 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188056 into lp:zorba/security-module

2013-09-20 Thread Luis Rodriguez Gonzalez
Looks like you will need to create a secondary merge proposal which updates the oauth module (which uses the hmac module that you're changing here). I just created lp:~zorba-coders/zorba/bug-1188056-oauth to change that uri. --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188056-oauth into lp:zorba/oauth-module

2013-09-20 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/bug-1188056-oauth into lp:zorba/oauth-module. Requested reviews: Luis Rodriguez Gonzalez (kuraru) Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1188056-oauth/+merge

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188056-oauth into lp:zorba/oauth-module

2013-09-20 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1188056-oauth/+merge/186874 Your team Zorba Coders is subscribed to branch lp:zorba/oauth-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/1189803-html into lp:zorba/html-module

2013-09-26 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/1189803-html/+merge/187932 Your team Zorba Coders is subscribed to branch lp:zorba/html-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/1189803-html into lp:zorba/html-module

2013-09-26 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/1189803-html into lp:zorba/html-module. Requested reviews: Luis Rodriguez Gonzalez (kuraru) Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/1189803-html/+merge/187932 -- https

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/1189803-geoproj-module into lp:zorba/geoproj-module

2013-09-26 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/1189803-geoproj-module/+merge/187939 Your team Zorba Coders is subscribed to branch lp:zorba/geoproj-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/1189803-geoproj-module into lp:zorba/geoproj-module

2013-09-26 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/1189803-geoproj-module into lp:zorba/geoproj-module. Requested reviews: Luis Rodriguez Gonzalez (kuraru) Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/1189803-geoproj-module

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/1189803-csv into lp:zorba/csv-module

2013-09-26 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/1189803-csv into lp:zorba/csv-module. Requested reviews: Luis Rodriguez Gonzalez (kuraru) Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/1189803-csv/+merge/187949 -- https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/1189803-schema-tools into lp:zorba/schema-tools-module

2013-09-29 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/1189803-schema-tools into lp:zorba/schema-tools-module. Commit message: Changes for Zorba 3.0 for schema module Requested reviews: Luis Rodriguez Gonzalez (kuraru) Chris Hillery (ceejatec) For more details, see: https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/1189803-schema-tools into lp:zorba/schema-tools-module

2013-09-29 Thread Luis Rodriguez Gonzalez
The proposal to merge lp:~zorba-coders/zorba/1189803-schema-tools into lp:zorba/schema-tools-module has been updated. Commit Message changed to: Changes for Zorba 3.0 for schema module For more details, see: https://code.launchpad.net/~zorba-coders/zorba/1189803-schema-tools/+merge/188235 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/1189803-schema-tools into lp:zorba/schema-tools-module

2013-09-29 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/1189803-schema-tools/+merge/188235 Your team Zorba Coders is subscribed to branch lp:zorba/schema-tools-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/1189803-geoproj-module into lp:zorba/geoproj-module

2013-09-29 Thread Luis Rodriguez Gonzalez
The proposal to merge lp:~zorba-coders/zorba/1189803-geoproj-module into lp:zorba/geoproj-module has been updated. Commit Message changed to: Changes for Zorba 3.0 for schema module For more details, see: https://code.launchpad.net/~zorba-coders/zorba/1189803-geoproj-module/+merge/187939 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/1189803-html into lp:zorba/html-module

2013-09-29 Thread Luis Rodriguez Gonzalez
The proposal to merge lp:~zorba-coders/zorba/1189803-html into lp:zorba/html-module has been updated. Commit Message changed to: Changes for Zorba 3.0 for schema module For more details, see: https://code.launchpad.net/~zorba-coders/zorba/1189803-html/+merge/187932 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/set-uri-components into lp:zorba

2013-10-11 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/set-uri-components/+merge/190740 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189788-dbgp into lp:zorba

2013-10-15 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189788-dbgp/+merge/191073 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189806 into lp:zorba

2013-10-15 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189806/+merge/191316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189806 into lp:zorba

2013-10-15 Thread Luis Rodriguez Gonzalez
The proposal to merge lp:~zorba-coders/zorba/bug-1189806 into lp:zorba has been updated. Commit Message changed to: Changes for Zorba 3.0 for URI module For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189806/+merge/191316 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189806 into lp:zorba

2013-10-15 Thread Luis Rodriguez Gonzalez
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/bug-1189806 into lp:zorba. Commit message: Changes for Zorba 3.0 for URI module Requested reviews: Luis Rodriguez Gonzalez (kuraru) Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders

  1   2   >