Re: [Zorba-coders] [Merge] lp:~matthias-brantner/zorba/auditing into lp:zorba

2011-09-30 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~matthias-brantner/zorba/auditing/+merge/77600 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~matthias-brantner/zorba/auditing into lp:zorba

2011-09-30 Thread Till Westmann
The proposal to merge lp:~matthias-brantner/zorba/auditing into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~matthias-brantner/zorba/auditing/+merge/77600 --

[Zorba-coders] [Merge] lp:~matthias-brantner/zorba/bug-fixing into lp:zorba

2011-10-26 Thread Till Westmann
The proposal to merge lp:~matthias-brantner/zorba/bug-fixing into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~matthias-brantner/zorba/bug-fixing/+merge/80512 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/windowing-tests into lp:zorba

2011-12-12 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/windowing-tests/+merge/84540 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/windowing-tests into lp:zorba

2011-12-22 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/windowing-tests into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/windowing-tests/+merge/86746 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/windowing-tests into lp:zorba

2011-12-22 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/windowing-tests/+merge/86746 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug911956 into lp:zorba

2012-01-06 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug911956/+merge/87779 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug911956 into lp:zorba

2012-01-06 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug911956 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug911956/+merge/87779 -- https://code.launchpad.net/~zorba-coders/zorba/bug911956/+merge/87779 Your

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fnserialize into lp:zorba

2012-01-20 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fnserialize/+merge/89504 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Bug 919438] Re: assertion failed in var_expr::remove_set_expr during shutdown

2012-01-20 Thread Till Westmann
The error can be reproduced in the linked branch. ** Branch linked: lp:~zorba-coders/zorba/bug-919438 ** Changed in: zorba Assignee: (unassigned) = Markos Zaharioudakis (markos-za) ** Changed in: zorba Importance: Undecided = High -- You received this bug notification because you are

[Zorba-coders] [Bug 919438] [NEW] assertion failed in var_expr::remove_set_expr during shutdown

2012-01-20 Thread Till Westmann
Public bug reported: In an extended version of the plan_serializer unit test we run into this error: #0 0xb52ef0e5 in __cxa_throw () from /usr/lib/i386-linux-gnu/libstdc++.so.6 #1 0xb7144a0f in zorba::assertion_failed (condition=0xb79f3632 found, file=0xb79f35c0

[Zorba-coders] [Bug 924987] Re: Failure getting type of a collection via the StaticCollectionManager

2012-02-01 Thread Till Westmann
** Branch linked: lp:~zorba-coders/zorba/bug924987 -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/924987 Title: Failure getting type of a collection via the StaticCollectionManager Status in

[Zorba-coders] [Bug 924987] [NEW] Failure getting type of a collection via the StaticCollectionManager

2012-02-01 Thread Till Westmann
: High Assignee: Till Westmann (tillw) Status: New -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/924987 Title: Failure getting type of a collection via the StaticCollectionManager

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924987 into lp:zorba

2012-02-01 Thread Till Westmann
Till Westmann has proposed merging lp:~zorba-coders/zorba/bug924987 into lp:zorba. Requested reviews: Till Westmann (tillw) Markos Zaharioudakis (markos-za) Related bugs: Bug #924987 in Zorba: Failure getting type of a collection via the StaticCollectionManager https

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924987 into lp:zorba

2012-02-01 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/91144 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924987 into lp:zorba

2012-02-01 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug924987 into lp:zorba has been updated. Commit Message changed to: fixes bug 924987 - extended TypeIdentifier to also support schema-element, schema-attribute and namespace-node sequence types - fixed TypeOps::get_type_identifier - added a test

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924987 into lp:zorba

2012-02-01 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug924987 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/91144 -- https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/91144 Your

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924987 into lp:zorba

2012-02-02 Thread Till Westmann
1. ok 2. I see your point, but I think that I need information about the content type. Is there a way to get that from the public API? (I looked over the public static context and didn't see something obvious.) 3. Good question. Actually, the type doesn't really reflect the structure of a

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-919438 into lp:zorba

2012-02-14 Thread Till Westmann
Till Westmann has proposed merging lp:~zorba-coders/zorba/bug-919438 into lp:zorba. Requested reviews: Matthias Brantner (matthias-brantner) Till Westmann (tillw) Related bugs: Bug #919438 in Zorba: assertion failed in var_expr::remove_set_expr during shutdown https://bugs.launchpad.net

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-919438 into lp:zorba

2012-02-14 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-919438/+merge/93093 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-919438 into lp:zorba

2012-02-14 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-919438 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-919438/+merge/93093 -- https://code.launchpad.net/~zorba-coders/zorba/bug-919438/+merge/93093

[Zorba-coders] [Bug 919438] Re: assertion failed in var_expr::remove_set_expr during shutdown

2012-02-14 Thread Till Westmann
To test it you could have used ctest -R plan_serializer on the related branch. However, I've merged the trunk into the branch and the problem is indeed fixed. I'll propose the branch for merging. -- You received this bug notification because you are a member of Zorba Coders, which is the

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/uuid-state-file into lp:zorba

2012-02-16 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/uuid-state-file/+merge/93514 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Bug 935666] Re: Item types need to have their own class

2012-02-20 Thread Till Westmann
There's bug 924987 (with a merge proposal that still needs some work) that addresses a similar problem. I think that the goal in both cases is the same: to provide complete information about a sequence type on the public API. Probably we can extend/modify TypeIdentifier in a way that provides

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba

2012-02-23 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/abstract-collection-set/+merge/94384 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba

2012-02-23 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/abstract-collection-set/+merge/94384 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba

2012-02-23 Thread Till Westmann
Review: Approve include/zorba/item.h: Docs do not say what happens, if getBase64BinaryValue is called when the item is streamable. include/zorba/item_factory.h: whence isn't the most commonly used word (http://en.wiktionary.org/wiki/whence) maybe we could use another one

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba

2012-02-23 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/ft-base64Binary/+merge/94494 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba

2012-02-23 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/ft-base64Binary/+merge/94494 --

[Zorba-coders] [Merge] lp:~gislenius/zorba/same-directory-store-includes into lp:zorba

2012-02-24 Thread Till Westmann
The proposal to merge lp:~gislenius/zorba/same-directory-store-includes into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~gislenius/zorba/same-directory-store-includes/+merge/94216 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-943788 into lp:zorba

2012-03-01 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-943788/+merge/95387 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-943788 into lp:zorba

2012-03-01 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-943788 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-943788/+merge/95387 -- https://code.launchpad.net/~zorba-coders/zorba/bug-943788/+merge/95387

[Zorba-coders] [Bug 947627] [NEW] setting the static type of the context item is ignored

2012-03-05 Thread Till Westmann
Public bug reported: In test2 in test/unit/context_item.cpp, the static type of the context item is set to xs:integer via the C++ API. In the query in test/unit/context_item2.xq - which is used to create the static context - the context item is declared to be of type xs:string. Currently the

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924987 into lp:zorba

2012-03-05 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug924987 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/91144 -- https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/91144 Your

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924987 into lp:zorba

2012-03-05 Thread Till Westmann
Till Westmann has proposed merging lp:~zorba-coders/zorba/bug924987 into lp:zorba. Requested reviews: Till Westmann (tillw) Markos Zaharioudakis (markos-za) Related bugs: Bug #924987 in Zorba: Failure getting type of a collection via the StaticCollectionManager https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924987 into lp:zorba

2012-03-05 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug924987 into lp:zorba has been updated. Commit Message changed to: fixes bug 924987 - extended TypeIdentifier to also support schema-element, schema-attribute and namespace-node sequence types - fixed TypeOps::get_type_identifier - added a test

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924987 into lp:zorba

2012-03-05 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/96047 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924987 into lp:zorba

2012-03-05 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug924987 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/96047 -- https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/96047 Your

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924987 into lp:zorba

2012-03-05 Thread Till Westmann
All points should be fixed. For 4. I've introduced a new parameter 'nested' that specifies, if the call to TypeOps::get_type_identifier is a nested call. If it is a nested call (from another invocation of TypeOps::get_type_identifier) the 'nested' is true and it is allowed to create type

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924987 into lp:zorba

2012-03-06 Thread Till Westmann
Looks good. Thanks! -- https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/96047 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924987 into lp:zorba

2012-03-06 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug924987 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/96047 -- https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/96047 Your

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-945241 into lp:zorba

2012-03-09 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-945241/+merge/96278 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-945241 into lp:zorba

2012-03-09 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-945241 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-945241/+merge/96278 -- https://code.launchpad.net/~zorba-coders/zorba/bug-945241/+merge/96278

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-938934 into lp:zorba

2012-03-09 Thread Till Westmann
Review: Approve Seems to work well. However, I think that the error message should be collection truncation cannot be undone instead of collection truncate cannot be undone. -- https://code.launchpad.net/~zorba-coders/zorba/bug-938934/+merge/96644 Your team Zorba Coders is subscribed to

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/store-shutdown-set-numusers-zero into lp:zorba

2012-03-20 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/store-shutdown-set-numusers-zero/+merge/98409 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/store-shutdown-set-numusers-zero into lp:zorba

2012-03-20 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/store-shutdown-set-numusers-zero into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/store-shutdown-set-numusers-zero/+merge/98409 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-readme into lp:zorba

2012-03-20 Thread Till Westmann
Till Westmann has proposed merging lp:~zorba-coders/zorba/fix-readme into lp:zorba. Requested reviews: Till Westmann (tillw) Matthias Brantner (matthias-brantner) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix-readme/+merge/98441 Fix the documentation URL

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/collection-claim-tree-ownership into lp:zorba

2012-03-20 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/collection-claim-tree-ownership/+merge/98419 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/collection-claim-tree-ownership into lp:zorba

2012-03-20 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/collection-claim-tree-ownership into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/collection-claim-tree-ownership/+merge/98419 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-readme into lp:zorba

2012-03-20 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix-readme/+merge/98441 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/947627 into lp:zorba

2012-03-20 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/947627/+merge/97570 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-955574 into lp:zorba

2012-03-26 Thread Till Westmann
Review: Approve Looks good, works fine. -- https://code.launchpad.net/~zorba-coders/zorba/bug-955574/+merge/97537 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-955574 into lp:zorba

2012-03-26 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-955574 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-955574/+merge/97537 -- https://code.launchpad.net/~zorba-coders/zorba/bug-955574/+merge/97537

[Zorba-coders] [Bug 966706] [NEW] key uniqueness of value equality index not enforced

2012-03-27 Thread Till Westmann
Public bug reported: Updates inserting entries into a collection that result in duplicate keys in the index are not rejected. An example can be found in test/rbkt/zorba/index/unique in the related branch. ** Affects: zorba Importance: Undecided Status: New ** Branch linked:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/unneeded-link-directory into lp:zorba

2012-04-05 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/unneeded-link-directory/+merge/100969 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/clang-friend into lp:zorba

2012-04-05 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/clang-friend/+merge/100978 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/unordered-collection-tests into lp:zorba

2012-04-10 Thread Till Westmann
Review: Approve Looks good to me and they work for me. -- https://code.launchpad.net/~zorba-coders/zorba/unordered-collection-tests/+merge/101374 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/unordered-collection-tests into lp:zorba

2012-04-10 Thread Till Westmann
Maybe I don't understand this right but I thought that 1) there is an order in a collection (within a snapshot) 2) this order extends to the document order for nodes that are descendants of different nodes in the collection. However, the nodes that are inserted into a collection are copied and

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ordpathmsgs into lp:zorba

2012-04-10 Thread Till Westmann
Review: Needs Information Looks good, but it is not clear how the changes in bin/debugger/command.h and src/runtime/collections/collections_impl.cpp are related to the new macro. -- https://code.launchpad.net/~zorba-coders/zorba/ordpathmsgs/+merge/101373 Your team Zorba Coders is subscribed to

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-955135 into lp:zorba

2012-04-10 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-955135/+merge/99354 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ordpathmsgs into lp:zorba

2012-04-11 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/ordpathmsgs/+merge/101520 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/ordpathmsgs into lp:zorba

2012-04-11 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/ordpathmsgs into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/ordpathmsgs/+merge/101520 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/virtual-destructors into lp:zorba

2012-04-11 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/virtual-destructors/+merge/100979 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/virtual-destructors into lp:zorba

2012-04-11 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/virtual-destructors into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/virtual-destructors/+merge/100979 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/clang-friend into lp:zorba

2012-04-11 Thread Till Westmann
Review: Needs Information The changes look ok, but I'm not sure how to test. I tried to build this branch using clang on MacOS X, but it doesn't build for me. What exactly should work now that did not work before? -- https://code.launchpad.net/~zorba-coders/zorba/clang-friend/+merge/101518

[Zorba-coders] [Bug 979147] [NEW] test/rbkt/zorba/index/numbers fails in Release mode

2012-04-11 Thread Till Westmann
Public bug reported: It works in Debug mode (Linux 32 bit) ** Affects: zorba Importance: Undecided Status: New -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/979147 Title:

[Zorba-coders] [Bug 924987] Re: Failure getting type of a collection via the StaticCollectionManager

2012-04-12 Thread Till Westmann
** Changed in: zorba Status: New = Fix Committed -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/924987 Title: Failure getting type of a collection via the StaticCollectionManager Status

[Zorba-coders] [Bug 919438] Re: assertion failed in var_expr::remove_set_expr during shutdown

2012-04-12 Thread Till Westmann
** Changed in: zorba Status: New = Fix Committed -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/919438 Title: assertion failed in var_expr::remove_set_expr during shutdown Status in

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/clang-friend into lp:zorba

2012-04-18 Thread Till Westmann
I tried to build on the command line by replacing /usr/bin/c++ with /usr/bin/llvm-g++ (and the same for cc), but that didn't work. To build with XCode, is it sufficient to use CMake's XCode project generator? -- https://code.launchpad.net/~zorba-coders/zorba/clang-friend/+merge/101518 Your team

[Zorba-coders] [Bug 988417] [NEW] block internal modules

2012-04-25 Thread Till Westmann
the usual resolution mechanism. ** Affects: zorba Importance: High Assignee: Till Westmann (tillw) Status: New -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/988417 Title: block

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba

2012-04-27 Thread Till Westmann
Review: Approve It would be nice to have 2 comments explaining 1) the modification of the parameter in simple_index_value.cpp:380 and 674 and 2) the role of key2 in Store::populateValueIndex. It would also be nice to use the typedef here: === modified file 'src/store/naive/simple_pul.cpp' ---

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-04-30 Thread Till Westmann
It seemed to me that the whole point of distinguishing between built-in modules and other modules here was that one does not want to invoke the the existing URI resolution mechanisms. Wanting to keep this spirit of the existing code, I proposed this solution. If that's not needed, then that's

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-rq-28msec into lp:zorba

2012-04-30 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix-rq-28msec/+merge/104187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-rq-28msec into lp:zorba

2012-04-30 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/fix-rq-28msec into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix-rq-28msec/+merge/104187 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-04-30 Thread Till Westmann
I've changed this as proposed (I think) and added some tests. Having the exception throw directly seems to have the advantage that I get consistent behavior between internal and external modules - so that seems to be good. As resolution doesn't seem to happen in the current scenario, the only

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-01 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-02 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-02 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Commit Message changed to: enable blocking of internal modules by running through URI mapping (but not through URL resolution) during translation For more details, see:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-02 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-04 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 --

[Zorba-coders] [Bug 988417] Re: block internal modules

2012-05-04 Thread Till Westmann
** Changed in: zorba Milestone: None = 2.5 ** Changed in: zorba Status: New = In Progress -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/988417 Title: block internal modules Status

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-04 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Status: Approved = Work in progress For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba

2012-05-17 Thread Till Westmann
Review: Approve Looks good - even the transcoding stuff seems to work :) Some remarks (nothing blocking): - It would be nice to keep fetch-binary functions together in the module. - Is internal::StreamResource::create ever used with 3 parameters? - fetch_impl.cpp: - 104 Why is

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba

2012-05-18 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/106300 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba

2012-05-18 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/106300 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-transient_maps into lp:zorba

2012-05-19 Thread Till Westmann
Review: Needs Fixing The docs say that a key can consist of a set of atomic values. As the order of the values is relevant list or tuple might be better. As the parameters for insert, get, etc. are anyAtomicType? an empty sequence can be passed in, but the doc does not say how that is handled.

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-transient_maps into lp:zorba

2012-05-19 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/feature-transient_maps into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-transient_maps/+merge/106287 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/opt-count-index-probe into lp:zorba

2012-05-21 Thread Till Westmann
Review: Approve The change looks good. Only 2 general comments: 1) func_sequences_impl.cpp It seems wasteful to first codegen the underlying probe iterators and then to re-create them here. It would be nice to parameterize the codeine on the way down - but I guess that there's no easy way of

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/opt-count-index-probe into lp:zorba

2012-05-21 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/opt-count-index-probe into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/opt-count-index-probe/+merge/105528 --

[Zorba-coders] [Bug 1009366] [NEW] access denied error message for module URIs does not contain location information

2012-06-06 Thread Till Westmann
Public bug reported: If a user defined URIMapper denies access to a URI, then the error message does not contain any location information. ** Affects: zorba Importance: Medium Assignee: Till Westmann (tillw) Status: New ** Changed in: zorba Importance: Undecided = High

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-06 Thread Till Westmann
Till Westmann has proposed merging lp:~zorba-coders/zorba/bug-1009366 into lp:zorba. Requested reviews: Chris Hillery (ceejatec) Markos Zaharioudakis (markos-za) Related bugs: Bug #1009366 in Zorba: access denied error message for module URIs does not contain location information https

[Zorba-coders] [Bug 1009366] Re: access denied error message for module URIs does not contain location information

2012-06-06 Thread Till Westmann
** Branch linked: lp:~zorba-coders/zorba/bug-1009366 -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/1009366 Title: access denied error message for module URIs does not contain location

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread Till Westmann
I've changed the catch(...) in translator.cpp and I've put the correct exception message back into the test. However, I don't see why the exception is reported twice, if the test fails. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge/108894 Your team Zorba Coders is

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread Till Westmann
Till Westmann has proposed merging lp:~zorba-coders/zorba/bug-1009366 into lp:zorba. Requested reviews: Markos Zaharioudakis (markos-za) Chris Hillery (ceejatec) Related bugs: Bug #1009366 in Zorba: access denied error message for module URIs does not contain location information https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-1009366 into lp:zorba has been updated. Commit Message changed to: add location information to ZXQP0029_URI_ACCESS_DENIED For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge/110410 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-1009366 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge/110410 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/cleanup-guestbook.xq into lp:zorba

2012-06-14 Thread Till Westmann
Till Westmann has proposed merging lp:~zorba-coders/zorba/cleanup-guestbook.xq into lp:zorba. Requested reviews: Till Westmann (tillw) Ghislain Fourny (gislenius) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/cleanup-guestbook.xq/+merge/110413 remove unnecessary

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/cleanup-guestbook.xq into lp:zorba

2012-06-14 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/cleanup-guestbook.xq/+merge/110413 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/cleanup-guestbook.xq into lp:zorba

2012-06-14 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/cleanup-guestbook.xq into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/cleanup-guestbook.xq/+merge/110413 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/cleanup-guestbook.xq into lp:zorba

2012-06-15 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/cleanup-guestbook.xq into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/cleanup-guestbook.xq/+merge/110413 --

  1   2   3   >