[Zorba-coders] [Bug 919189] Re: ZorbaImpl::init might call GlobalEnvironment::init with a NULL store pointer
** Changed in: zorba Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/919189 Title: ZorbaImpl::init might call GlobalEnvironment::init with a NULL store pointer Status in Zorba - The XQuery Processor: Fix Released Bug description: At this location, in function ZorbaImpl::init(Store* store): http://bazaar.launchpad.net/~zorba- coders/zorba/trunk/view/head:/src/api/zorbaimpl.cpp#L93 The assertion assert(store == NULL || store2 == store); allows the variable store to be NULL (and there are places that do call this function indirectly with an explicit NULL store pointer, such as here: http://bazaar.launchpad.net/~zorba- coders/zorba/trunk/view/head:/modules/com/zorba-xquery/www/modules /http-client.xq.src/http_client.cpp#L68 ). However, this assertion is followed by GlobalEnvironment::init(store); that always fails upon a NULL pointer. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/919189/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 919189] Re: ZorbaImpl::init might call GlobalEnvironment::init with a NULL store pointer
Ghislain, yes, what you say makes sense, given the current implementation. But the current API reflects our long-term goal of separating zorba from the store (into separate libraries). The application may link with several stores and start zorba with a different store each time. In this scenario, the store must be passed as an input to zorba. -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/919189 Title: ZorbaImpl::init might call GlobalEnvironment::init with a NULL store pointer Status in Zorba - The XQuery Processor: Fix Committed Bug description: At this location, in function ZorbaImpl::init(Store* store): http://bazaar.launchpad.net/~zorba- coders/zorba/trunk/view/head:/src/api/zorbaimpl.cpp#L93 The assertion assert(store == NULL || store2 == store); allows the variable store to be NULL (and there are places that do call this function indirectly with an explicit NULL store pointer, such as here: http://bazaar.launchpad.net/~zorba- coders/zorba/trunk/view/head:/modules/com/zorba-xquery/www/modules /http-client.xq.src/http_client.cpp#L68 ). However, this assertion is followed by GlobalEnvironment::init(store); that always fails upon a NULL pointer. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/919189/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 919189] Re: ZorbaImpl::init might call GlobalEnvironment::init with a NULL store pointer
Actually, would it make sense to completely remove the store parameter, make init a 0-ary function, and just use the store manager's singleton for initializing the global environment, since the variable store may only have a given value? -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/919189 Title: ZorbaImpl::init might call GlobalEnvironment::init with a NULL store pointer Status in Zorba - The XQuery Processor: Fix Committed Bug description: At this location, in function ZorbaImpl::init(Store* store): http://bazaar.launchpad.net/~zorba- coders/zorba/trunk/view/head:/src/api/zorbaimpl.cpp#L93 The assertion assert(store == NULL || store2 == store); allows the variable store to be NULL (and there are places that do call this function indirectly with an explicit NULL store pointer, such as here: http://bazaar.launchpad.net/~zorba- coders/zorba/trunk/view/head:/modules/com/zorba-xquery/www/modules /http-client.xq.src/http_client.cpp#L68 ). However, this assertion is followed by GlobalEnvironment::init(store); that always fails upon a NULL pointer. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/919189/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 919189] Re: ZorbaImpl::init might call GlobalEnvironment::init with a NULL store pointer
I removed the store == NULL test from the assertion. ** Changed in: zorba Status: New => Fix Committed -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/919189 Title: ZorbaImpl::init might call GlobalEnvironment::init with a NULL store pointer Status in Zorba - The XQuery Processor: Fix Committed Bug description: At this location, in function ZorbaImpl::init(Store* store): http://bazaar.launchpad.net/~zorba- coders/zorba/trunk/view/head:/src/api/zorbaimpl.cpp#L93 The assertion assert(store == NULL || store2 == store); allows the variable store to be NULL (and there are places that do call this function indirectly with an explicit NULL store pointer, such as here: http://bazaar.launchpad.net/~zorba- coders/zorba/trunk/view/head:/modules/com/zorba-xquery/www/modules /http-client.xq.src/http_client.cpp#L68 ). However, this assertion is followed by GlobalEnvironment::init(store); that always fails upon a NULL pointer. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/919189/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
