[Zorba-coders] [Merge] lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba

2012-02-28 Thread Ghislain Fourny
The proposal to merge lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/abstract-collection-set/+merge/94384 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba

2012-02-28 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/abstract-collection-set/+merge/94384 -- https://code.launchpad.net/~zorba-coders/zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba

2012-02-28 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/abstract-collection-set/+merge/94384 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba

2012-02-28 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~zorba-coders/zorba/abstract-collection-set/+merge/94384 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba

2012-02-28 Thread Zorba Build Bot
Validation queue job abstract-collection-set-2012-02-28T15-43-11.328Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/abstract-collection-set/+merge/94384 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba

2012-02-28 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/abstract-collection-set/+merge/94384 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba

2012-02-23 Thread Ghislain Fourny
Ghislain Fourny has proposed merging lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba. Requested reviews: Matthias Brantner (matthias-brantner) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/abstract-collection-set/+merge/94384 Refactored CollectionSet

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba

2012-02-23 Thread Ghislain Fourny
The proposal to merge lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/abstract-collection-set/+merge/94384 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba

2012-02-23 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/abstract-collection-set-2012-02-23T14-54-58.415Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/abstract-collection-set/+merge/94384 Your team Zorba Coders is subscribed to branch

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba

2012-02-23 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job abstract-collection-set-2012-02-23T14-54-58.415Z

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba

2012-02-23 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/abstract-collection-set/+merge/94384 -- https://code.launchpad.net/~zorba-coders/zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba

2012-02-23 Thread Matthias Brantner
Review: Needs Fixing - Did you forget to add file simple_collection_set.h - I would keep the CollectionSet in the simplestore namespace because it's a component defined by the simplestore and not the store api (i.e. a file in store/api) --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba

2012-02-23 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/abstract-collection-set/+merge/94384 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba

2012-02-23 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/abstract-collection-set-2012-02-23T20-39-04.769Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/abstract-collection-set/+merge/94384 Your team Zorba Coders is subscribed to branch

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba

2012-02-23 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job abstract-collection-set-2012-02-23T20-39-04.769Z

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba

2012-02-23 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/abstract-collection-set/+merge/94384 -- https://code.launchpad.net/~zorba-coders/zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba

2012-02-23 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/abstract-collection-set/+merge/94384 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/abstract-collection-set into lp:zorba

2012-02-23 Thread Matthias Brantner
Review: Needs Fixing One last and very small change request. The indentation in line 512 of the diff is broken. -- https://code.launchpad.net/~zorba-coders/zorba/abstract-collection-set/+merge/94384 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: