Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-04 Thread Matthias Brantner
Review: Approve s/hust/just -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-04 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 -- https://code.launchpad.net

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-04 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Status: Approved = Work in progress For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 -- https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-04 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-988417-block-internal-module-2012-05-05T02-07-02.544Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-04 Thread Zorba Build Bot
Validation queue job bug-988417-block-internal-module-2012-05-05T02-07-02.544Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-04 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 -- https://code.launchpad.net/~zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-03 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-02 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 -- https://code.launchpad.net

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-02 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Commit Message changed to: enable blocking of internal modules by running through URI mapping (but not through URL resolution) during translation For more details, see: https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-02 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 -- https://code.launchpad.net

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-02 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-988417-block-internal-module-2012-05-02T20-19-00.73Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-02 Thread Zorba Build Bot
Validation queue job bug-988417-block-internal-module-2012-05-02T20-19-00.73Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-02 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 4 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-02 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 -- https://code.launchpad.net

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-02 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-01 Thread Chris Hillery
Review: Approve Ah, yes, I guess you want the exception to be thrown anyway. Cool, that works. -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/103542 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-05-01 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 -- https://code.launchpad.net

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-04-30 Thread Till Westmann
It seemed to me that the whole point of distinguishing between built-in modules and other modules here was that one does not want to invoke the the existing URI resolution mechanisms. Wanting to keep this spirit of the existing code, I proposed this solution. If that's not needed, then that's

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-04-30 Thread Chris Hillery
IMHO, the point of built-in modules was to prevent the overhead of *compiling* those modules, not bypassing URI resolution per se. It is true, though, that invoking URI resolution implies a bit of performance overhead. I believe that if only the URI mapping stage is invoked that the overhead

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba

2012-04-30 Thread Till Westmann
I've changed this as proposed (I think) and added some tests. Having the exception throw directly seems to have the advantage that I get consistent behavior between internal and external modules - so that seems to be good. As resolution doesn't seem to happen in the current scenario, the only