Review: Approve
s/hust/just
--
https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module
into lp:zorba has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207
--
https://code.launchpad.net
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module
into lp:zorba has been updated.
Status: Approved = Work in progress
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207
--
https
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-988417-block-internal-module-2012-05-05T02-07-02.544Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207
Your team Zorba Coders is
Validation queue job bug-988417-block-internal-module-2012-05-05T02-07-02.544Z
is finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207
Your team Zorba Coders is subscribed to branch lp:zorba.
--
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module
into lp:zorba has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207
--
https://code.launchpad.net/~zorba
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module
into lp:zorba has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207
--
https://code.launchpad.net
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module
into lp:zorba has been updated.
Commit Message changed to:
enable blocking of internal modules by running through URI mapping (but not
through URL resolution) during translation
For more details, see:
https
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module
into lp:zorba has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207
--
https://code.launchpad.net
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-988417-block-internal-module-2012-05-02T20-19-00.73Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207
Your team Zorba Coders is
Validation queue job bug-988417-block-internal-module-2012-05-02T20-19-00.73Z
is finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 4 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module
into lp:zorba has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207
--
https://code.launchpad.net
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
Ah, yes, I guess you want the exception to be thrown anyway. Cool, that works.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/103542
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module
into lp:zorba has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207
--
https://code.launchpad.net
It seemed to me that the whole point of distinguishing between built-in modules
and other modules here was that one does not want to invoke the the existing
URI resolution mechanisms. Wanting to keep this spirit of the existing code, I
proposed this solution. If that's not needed, then that's
IMHO, the point of built-in modules was to prevent the overhead of
*compiling* those modules, not bypassing URI resolution per se. It is true,
though, that invoking URI resolution implies a bit of performance overhead. I
believe that if only the URI mapping stage is invoked that the overhead
I've changed this as proposed (I think) and added some tests.
Having the exception throw directly seems to have the advantage that I get
consistent behavior between internal and external modules - so that seems to be
good.
As resolution doesn't seem to happen in the current scenario, the only
20 matches
Mail list logo