Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Markos Zaharioudakis
Review: Needs Fixing


-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Markos Zaharioudakis
Why is the processPragma method defined only for 
static_collections_dml_apply_insert_nodes_last. Should it be defined for the 
other collection-insert functions as well?

ChangeLog needs updating

Tiny optimization: if you want to erase the last N entries in a vector, you can 
just use resize(). This applies to the code in translator.cpp:8470

-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Matthias Brantner
 Why is the processPragma method defined only for
 static_collections_dml_apply_insert_nodes_last. Should it be defined for the
 other collection-insert functions as well?
 
 ChangeLog needs updating
 
 Tiny optimization: if you want to erase the last N entries in a vector, you
 can just use resize(). This applies to the code in translator.cpp:8470
All of the are fixed.
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into 
lp:zorba has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please 
seek review and approval of these new revisions.
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into 
lp:zorba has been updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Markos Zaharioudakis
I am going to approve, but it would be nice if you added an iter test to make 
sure that the optimization is applied and we won't loose it somehow in the 
future. To do so, you must first make PrinterVisitor print theNeedToCpy data 
member of the various ZorbaInsertNodesXXX iterators. This will probably involve 
messing with the runtime code generator (ouch!). Then you print the iterators 
plan of your no_copy_01.xq, and save it in 
test/rbkt/ExpCompilerResults/IterPlans/zorba/collections/no_copy_01.iter.

-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Markos Zaharioudakis
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into 
lp:zorba has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Matthias Brantner
 I am going to approve, but it would be nice if you added an iter test to
 make sure that the optimization is applied and we won't loose it somehow in
 the future. To do so, you must first make PrinterVisitor print theNeedToCpy
 data member of the various ZorbaInsertNodesXXX iterators. This will probably
 involve messing with the runtime code generator (ouch!). Then you print the
 iterators plan of your no_copy_01.xq, and save it in
 test/rbkt/ExpCompilerResults/IterPlans/zorba/collections/no_copy_01.iter.
done
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/feature-pragma_no_copy-2012-09-19T21-42-49.059Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread Zorba Build Bot
Validation queue job feature-pragma_no_copy-2012-09-19T21-42-49.059Z is 
finished. The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-19 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into 
lp:zorba has been updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into 
lp:zorba has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/feature-pragma_no_copy-2012-09-12T17-51-55.158Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into 
lp:zorba failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 
(message):
  Validation queue job feature-pragma_no_copy-2012-09-12T17-51-55.158Z is
  finished.  The final status was:

  

  2 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into 
lp:zorba has been updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into 
lp:zorba has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Zorba Build Bot
Validation queue job feature-pragma_no_copy-2012-09-12T18-22-49.866Z is 
finished. The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1. Got: 1 Approve, 2 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into 
lp:zorba has been updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into 
lp:zorba has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/feature-pragma_no_copy-2012-09-12T21-32-49.698Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Zorba Build Bot
Validation queue job feature-pragma_no_copy-2012-09-12T21-32-49.698Z is 
finished. The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1. Got: 1 Approve, 2 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-09-12 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into 
lp:zorba has been updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Matthias Brantner
Matthias Brantner has proposed merging 
lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba.

Requested reviews:
  Matthias Brantner (matthias-brantner)

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816

pragma for preventing copying of nodes in functions that insert into collections

For example

 declare namespace ext = http://www.zorba-xquery.com/extensions;;

 (# ext:no-copy #) {
   dml:insert-nodes-last(xs:QName(local:foo), $node)
 };
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/compiler/api/compilercb.h'
--- src/compiler/api/compilercb.h	2012-06-28 04:14:03 +
+++ src/compiler/api/compilercb.h	2012-06-29 17:23:20 +
@@ -29,6 +29,7 @@
 // without having the definition of static_context availble.
 # include context/static_context.h
 #endif
+#include compiler/expression/pragma.h
 
 #include zorbaserialization/class_serializer.h
 
@@ -157,6 +158,9 @@
 
   typedef std::mapcsize, static_context_t SctxMap;
 
+  typedef std::multimapexpr*, pragma_t PragmaMap;
+  typedef PragmaMap::const_iterator  PragmaMapIter;
+
 public:  
   XQueryDiagnostics   * theXQueryDiagnostics;
 
@@ -186,6 +190,8 @@
 
   configtheConfig;
 
+  PragmaMap thePragmas;
+
 public:
   SERIALIZABLE_CLASS(CompilerCB);
   CompilerCB(::zorba::serialization::Archiver ar);

=== modified file 'src/compiler/expression/CMakeLists.txt'
--- src/compiler/expression/CMakeLists.txt	2012-06-28 04:14:03 +
+++ src/compiler/expression/CMakeLists.txt	2012-06-29 17:23:20 +
@@ -26,7 +26,8 @@
 fo_expr.cpp
 script_exprs.cpp
 update_exprs.cpp
-function_item_expr.cpp)
+function_item_expr.cpp
+pragma.cpp)
 
 IF (NOT ZORBA_NO_FULL_TEXT)
   LIST(APPEND EXPRESSION_SRCS

=== modified file 'src/compiler/expression/expr.cpp'
--- src/compiler/expression/expr.cpp	2012-06-28 04:14:03 +
+++ src/compiler/expression/expr.cpp	2012-06-29 17:23:20 +
@@ -955,14 +955,6 @@
 /***
 
 /
-pragma::pragma(store::Item_t name, std::string const content)
-  :
-  theQName(name),
-  theContent(content)
-{
-}
-
-
 extension_expr::extension_expr(
 static_context* sctx,
 const QueryLoc loc)

=== modified file 'src/compiler/expression/expr.h'
--- src/compiler/expression/expr.h	2012-06-28 04:14:03 +
+++ src/compiler/expression/expr.h	2012-06-29 17:23:20 +
@@ -29,6 +29,7 @@
 #include functions/signature.h
 
 #include compiler/expression/var_expr.h
+#include compiler/expression/pragma.h
 
 #include context/static_context.h
 #include context/namespace_context.h
@@ -765,22 +766,6 @@
 /***//**
 
 /
-class pragma : public SimpleRCObject
-{
-  friend class expr;
-
-public:
-  store::Item_t theQName;
-  std::string theContent;
-
-public:
-  pragma(store::Item_t name, std::string const content);
-};
-
-
-/***//**
-
-/
 class extension_expr : public expr 
 {
   friend class ExprIterator;

=== modified file 'src/compiler/expression/expr_base.cpp'
--- src/compiler/expression/expr_base.cpp	2012-06-28 04:14:03 +
+++ src/compiler/expression/expr_base.cpp	2012-06-29 17:23:20 +
@@ -541,6 +541,30 @@
 
 
 /***
+
+/
+BoolAnnotationValue expr::getContainsPragma() const
+{
+  return (BoolAnnotationValue)
+ ((theFlags1  CONTAINS_PRAGMA_MASK)  CONTAINS_PRAGMA);
+}
+
+
+void expr::setContainsPragma(BoolAnnotationValue v)
+{
+  theFlags1 = ~CONTAINS_PRAGMA_MASK;
+  theFlags1 |= (v  CONTAINS_PRAGMA);
+}
+
+
+bool expr::containsPragma() const
+{
+  BoolAnnotationValue v = getContainsPragma();
+  return (v == ANNOTATION_TRUE || v == ANNOTATION_TRUE_FIXED);
+}
+
+
+/***
   This annotation tells whether the expr must produce nodes that belong to 
   standalone trees or not. A tree is standalone if it does not contain 
   references to other trees. Such references are created when the optimizer 

=== modified file 'src/compiler/expression/expr_base.h'
--- src/compiler/expression/expr_base.h	2012-06-28 04:14:03 +
+++ src/compiler/expression/expr_base.h	2012-06-29 17:23:20 +
@@ -151,7 +151,8 @@
 CONTAINS_RECURSIVE_CALL = 12,
 PROPAGATES_INPUT_NODES  = 14,
 WILL_BE_SERIALIZED  = 16,
-MUST_COPY_NODES = 18
+

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/feature-pragma_no_copy-2012-06-29T17-23-58.019Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Zorba Build Bot
Validation queue job feature-pragma_no_copy-2012-06-29T17-23-58.019Z is 
finished. The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1. Got: 1 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into 
lp:zorba has been updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Matthias Brantner
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into 
lp:zorba has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/feature-pragma_no_copy-2012-06-29T21-33-59.318Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into 
lp:zorba failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 
(message):
  Validation queue job feature-pragma_no_copy-2012-06-29T21-33-59.318Z is
  finished.  The final status was:

  

  1 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into 
lp:zorba has been updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into 
lp:zorba has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please 
seek review and approval of these new revisions.
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-pragma_no_copy into lp:zorba

2012-06-29 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/feature-pragma_no_copy into 
lp:zorba has been updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-pragma_no_copy/+merge/112816
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp