The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into
lp:zorba has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
--
https://code.launchpad.net/~zorba-coders/zorba
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/get-namespace-bindings-2012-01-10T08-12-08.927Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
Your team Zorba Coders is subscribed to branch
Validation queue job get-namespace-bindings-2012-01-10T08-12-08.927Z is
finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1.
Got: 1 Approve, 1 Needs Fixing.
--
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into
lp:zorba has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
--
https://code.launchpad.net/~zorba-coders/zorba
The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into
lp:zorba has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
--
https://code.launchpad.net/~zorba-coders/zorba
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/get-namespace-bindings-2012-01-10T16-00-10.868Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
Your team Zorba Coders is subscribed to branch
The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into
lp:zorba has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
--
https://code.launchpad.net/~zorba-coders/zorba/get
One more thing. Could we pass the NsBindings parameter as reference without
breaking backwards compatibly?
No, at least not for createElementNode(); it would break binary compatibility.
If you don't mind that, I could make the change - it should still be source-
compatible, at least.
It
Review: Approve
Ok, I moved NsBindings to zorba:: scope (in item.h), and changed
createElementNode() to also use it (and clients of createElementNode() to use
it also).
I've changed the usages of createElementNode() in non-core modules as well, but
they compile fine without changes
The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into
lp:zorba has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
--
https://code.launchpad.net/~zorba-coders/zorba
Validation queue job get-namespace-bindings-2012-01-06T02-19-10.63Z is
finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1.
Got: 1 Approve, 1 Needs Fixing.
--
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Needs Fixing
One more thing. Could we pass the NsBindings parameter as reference without
breaking backwards compatibly?
Also, before merging, could you please mention the API extension in the
ChangeLog?
--
One more thing. Could we pass the NsBindings parameter as reference without
breaking backwards compatibly?
No, at least not for createElementNode(); it would break binary compatibility.
If you don't mind that, I could make the change - it should still be
source-compatible, at least.
Also,
Regarding vector vs. map, after thinking about it a bit, I agree with you that
map would be at least a bit better user experience. However,
ItemFactory::createElementNode() takes a vectorpair already, and that
can't be changed. I think probably it's best that getNamespaceBindings() be
is requested to review the proposed merge of
lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba.
=== modified file 'doc/cxx/examples/simple.cpp'
--- doc/cxx/examples/simple.cpp 2011-06-14 14:21:49 +
+++ doc/cxx/examples/simple.cpp 2011-12-31 09:17:24 +
@@ -33,14 +33,14 @@
std::cout
The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into
lp:zorba has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
--
https://code.launchpad.net/~zorba-coders/zorba
The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into
lp:zorba has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187
--
https://code.launchpad.net/~zorba-coders/zorba
19 matches
Mail list logo