[Zorba-coders] [Merge] lp:~zorba-coders/zorba/memory-leak-array-append into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/memory-leak-array-append into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/memory-leak-array-append/+merge/118960 -- https://code.launchpad.net/~zorba-coders/zorba/memory-leak-array-append/+merge/118960 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/memory-leak-array-append into lp:zorba
Validation queue job memory-leak-array-append-2012-08-29T15-10-54.382Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/memory-leak-array-append/+merge/118960 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/memory-leak-array-append into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/memory-leak-array-append-2012-08-29T15-10-54.382Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/memory-leak-array-append/+merge/118960 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/memory-leak-array-append into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/memory-leak-array-append into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/memory-leak-array-append/+merge/118960 -- https://code.launchpad.net/~zorba-coders/zorba/memory-leak-array-append/+merge/118960 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/memory-leak-array-append into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/memory-leak-array-append/+merge/118960 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/memory-leak-array-append into lp:zorba
Review: Approve Change looks good. Validated (using valgrind) that the memory that was lost when running test/rbkt/Queries/zorba/jsoniq/arr_append_01.xq is not lost anymore after applying this patch. -- https://code.launchpad.net/~zorba-coders/zorba/memory-leak-array-append/+merge/118960 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/memory-leak-array-append into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/memory-leak-array-append into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/memory-leak-array-append/+merge/118960 -- https://code.launchpad.net/~zorba-coders/zorba/memory-leak-array-append/+merge/118960 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/memory-leak-array-append into lp:zorba
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/memory-leak-array-append/+merge/118960 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/memory-leak-array-append into lp:zorba
Validation queue job memory-leak-array-append-2012-08-09T14-16-30.864Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/memory-leak-array-append/+merge/118960 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/memory-leak-array-append into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/memory-leak-array-append-2012-08-09T14-16-30.864Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/memory-leak-array-append/+merge/118960 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/memory-leak-array-append into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/memory-leak-array-append into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/memory-leak-array-append/+merge/118960 -- https://code.launchpad.net/~zorba-coders/zorba/memory-leak-array-append/+merge/118960 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/memory-leak-array-append into lp:zorba
Ghislain Fourny has proposed merging lp:~zorba-coders/zorba/memory-leak-array-append into lp:zorba. Requested reviews: Till Westmann (tillw) Matthias Brantner (matthias-brantner) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/memory-leak-array-append/+merge/118960 Fixing a memory leak in append update primitive. -- https://code.launchpad.net/~zorba-coders/zorba/memory-leak-array-append/+merge/118960 Your team Zorba Coders is subscribed to branch lp:zorba. === modified file 'src/store/naive/simple_pul.cpp' --- src/store/naive/simple_pul.cpp 2012-07-24 08:48:48 + +++ src/store/naive/simple_pul.cpp 2012-08-09 13:44:20 + @@ -1737,6 +1737,10 @@ mergeTargetedUpdateLists(thisPul, thisPul->theJSONArrayReplaceValueList, otherPul->theJSONArrayReplaceValueList); + + mergeTargetedUpdateLists(thisPul, + thisPul->theJSONArrayAppendList, + otherPul->theJSONArrayAppendList); #endif ++thisIte; @@ -2633,6 +2637,7 @@ cleanList(theJSONArrayInsertList); cleanList(theJSONArrayDeleteList); cleanList(theJSONArrayReplaceValueList); + cleanList(theJSONArrayAppendList); #endif cleanIndexDeltas(); @@ -2661,6 +2666,7 @@ switchPulInPrimitivesList(theJSONArrayInsertList); switchPulInPrimitivesList(theJSONArrayDeleteList); switchPulInPrimitivesList(theJSONArrayReplaceValueList); + switchPulInPrimitivesList(theJSONArrayAppendList); #endif switchPulInPrimitivesList(theCreateCollectionList); -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
