Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-1022495-and-1022494 into lp:zorba

2012-09-11 Thread Chris Hillery
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bugs-1022495-and-1022494/+merge/114185
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-1022495-and-1022494 into lp:zorba

2012-09-11 Thread Chris Hillery
Review: Needs Fixing

More modules need changing, coming soon.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bugs-1022495-and-1022494/+merge/114185
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-1022495-and-1022494 into lp:zorba

2012-09-11 Thread Chris Hillery
Review: Approve

Should be all done now.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bugs-1022495-and-1022494/+merge/114185
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-1022495-and-1022494 into lp:zorba

2012-09-11 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bugs-1022495-and-1022494 into 
lp:zorba has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bugs-1022495-and-1022494/+merge/114185
-- 
https://code.launchpad.net/~zorba-coders/zorba/bugs-1022495-and-1022494/+merge/114185
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-1022495-and-1022494 into lp:zorba

2012-09-11 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/bugs-1022495-and-1022494-2012-09-12T04-38-44.886Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/bugs-1022495-and-1022494/+merge/114185
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-1022495-and-1022494 into lp:zorba

2012-09-11 Thread Zorba Build Bot
Validation queue job bugs-1022495-and-1022494-2012-09-12T04-38-44.886Z is 
finished. The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/bugs-1022495-and-1022494/+merge/114185
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-1022495-and-1022494 into lp:zorba

2012-07-10 Thread Dennis Knochenwefel
Dennis Knochenwefel has proposed merging 
lp:~zorba-coders/zorba/bugs-1022495-and-1022494 into lp:zorba.

Requested reviews:
  Matthias Brantner (matthias-brantner)
  Chris Hillery (ceejatec)
Related bugs:
  Bug #1022494 in Zorba: fetch_bogus2 fails due to flworfound.org change
  https://bugs.launchpad.net/zorba/+bug/1022494
  Bug #1022495 in Zorba: versioning/import5 fails due to flworfound.org change
  https://bugs.launchpad.net/zorba/+bug/1022495

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bugs-1022495-and-1022494/+merge/114185

fixing bugs #1022495 and #1022494
-- 
https://code.launchpad.net/~zorba-coders/zorba/bugs-1022495-and-1022494/+merge/114185
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'test/rbkt/Queries/CMakeLists.txt'
--- test/rbkt/Queries/CMakeLists.txt	2012-07-09 20:45:24 +
+++ test/rbkt/Queries/CMakeLists.txt	2012-07-10 13:14:23 +
@@ -590,6 +590,3 @@
 EXPECTED_FAILURE(test/rbkt/zorba/windowing/tumbling17 899364)
 EXPECTED_FAILURE(test/rbkt/zorba/windowing/tumbling21 899364)
 
-# Failing due to flworfound.org hosting changes.
-EXPECTED_FAILURE(test/rbkt/zorba/versioning/import5 1022495)
-EXPECTED_FAILURE(test/rbkt/zorba/fetch/fetch_bogus2 1022494)

=== modified file 'test/rbkt/Queries/zorba/fetch/fetch_bogus2.xq'
--- test/rbkt/Queries/zorba/fetch/fetch_bogus2.xq	2012-06-28 04:14:03 +
+++ test/rbkt/Queries/zorba/fetch/fetch_bogus2.xq	2012-07-10 13:14:23 +
@@ -1,4 +1,4 @@
 (: Fetch a valid module URI but as SOME_CONTENT :)
 import module namespace fetch = http://www.zorba-xquery.com/modules/fetch;;
 
-fetch:content(http://www.flworfound.org/modules/ext;, SOME_CONTENT)
+fetch:content(http://zorba-tests.28msec.us/doesnotexist;, SOME_CONTENT)

=== modified file 'test/rbkt/Queries/zorba/versioning/import5.xq'
--- test/rbkt/Queries/zorba/versioning/import5.xq	2012-06-28 04:14:03 +
+++ test/rbkt/Queries/zorba/versioning/import5.xq	2012-07-10 13:14:23 +
@@ -1,4 +1,4 @@
 (: Test that importing a non-existent explicit version gets an error. :)
-import module namespace vm = http://www.flworfound.org/modules/ver#2.2!;;
+import module namespace vm = http://zorba-tests.28msec.us/zorba-test-module.xq#2.2!;;
 
 vm:version()

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-1022495-and-1022494 into lp:zorba

2012-07-10 Thread Zorba Build Bot
Validation queue job bugs-1022495-and-1022494-2012-07-10T13-16-14.485Z is 
finished. The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/bugs-1022495-and-1022494/+merge/114185
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-1022495-and-1022494 into lp:zorba

2012-07-10 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1. Got: 2 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bugs-1022495-and-1022494/+merge/114185
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-1022495-and-1022494 into lp:zorba

2012-07-10 Thread Chris Hillery
Review: Needs Fixing

This doesn't test quite the same thing that it used to. Those tests were 
previously *valid* module URIs (that is, there actually was a module with that 
namespace) used in incorrect ways.

The modules in question are declared in test/rbkt/modules. In order to fix this 
properly, the definition of those modules and every test that makes use of them 
will need to be updated to the new domain name. It's not hard, but it's 
tedious, which is why I wanted to wait until we were sure we have an unchanging 
domain name to do it.

If this zorba-tests.28msec.us domain is guaranteed to be there forever, then I 
could probably do a global search/replace in perl pretty quickly.

-- 
https://code.launchpad.net/~zorba-coders/zorba/bugs-1022495-and-1022494/+merge/114185
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp