Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-10 Thread Chris Hillery
Review: Approve I've added a ChangeLog comment. I did NOT change createElementNode() to accept NsBindings by reference, because it turns out it's not even a source-compatible change. You can no longer do things like this to pass no namespace bindings: theResponse =

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-10 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-10 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/get-namespace-bindings-2012-01-10T08-12-08.927Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187 Your team Zorba Coders is subscribed to branch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-10 Thread Zorba Build Bot
Validation queue job get-namespace-bindings-2012-01-10T08-12-08.927Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-10 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1. Got: 1 Approve, 1 Needs Fixing. -- https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-10 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187 -- https://code.launchpad.net/~zorba-coders/zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-10 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-10 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-10 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/get-namespace-bindings-2012-01-10T16-00-10.868Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187 Your team Zorba Coders is subscribed to branch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-10 Thread Zorba Build Bot
Validation queue job get-namespace-bindings-2012-01-10T16-00-10.868Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-10 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187 -- https://code.launchpad.net/~zorba-coders/zorba/get

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-06 Thread Matthias Brantner
One more thing. Could we pass the NsBindings parameter as reference without breaking backwards compatibly? No, at least not for createElementNode(); it would break binary compatibility. If you don't mind that, I could make the change - it should still be source- compatible, at least. It

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-05 Thread Chris Hillery
Review: Approve Ok, I moved NsBindings to zorba:: scope (in item.h), and changed createElementNode() to also use it (and clients of createElementNode() to use it also). I've changed the usages of createElementNode() in non-core modules as well, but they compile fine without changes

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-05 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-05 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/get-namespace-bindings-2012-01-06T02-19-10.63Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187 Your team Zorba Coders is subscribed to branch lp:zorba.

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-05 Thread Zorba Build Bot
Validation queue job get-namespace-bindings-2012-01-06T02-19-10.63Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-05 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1. Got: 1 Approve, 1 Needs Fixing. -- https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-05 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187 -- https://code.launchpad.net/~zorba-coders/zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-05 Thread Matthias Brantner
Review: Needs Fixing One more thing. Could we pass the NsBindings parameter as reference without breaking backwards compatibly? Also, before merging, could you please mention the API extension in the ChangeLog? --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-05 Thread Chris Hillery
One more thing. Could we pass the NsBindings parameter as reference without breaking backwards compatibly? No, at least not for createElementNode(); it would break binary compatibility. If you don't mind that, I could make the change - it should still be source-compatible, at least. Also,

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-04 Thread Matthias Brantner
Regarding vector vs. map, after thinking about it a bit, I agree with you that map would be at least a bit better user experience. However, ItemFactory::createElementNode() takes a vectorpair already, and that can't be changed. I think probably it's best that getNamespaceBindings() be

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-04 Thread Chris Hillery
No, I don't think so. Because the internal NsBindings uses zstring (not zorba::String) I was talking about the public zorba::ItemFactory::createElementNode() method. It takes a std::vectorstd::pairzorba::String, zorba::String just like getNamespaceBindings() does. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-04 Thread Matthias Brantner
No, I don't think so. Because the internal NsBindings uses zstring (not zorba::String) I was talking about the public zorba::ItemFactory::createElementNode() method. It takes a std::vectorstd::pairzorba::String, zorba::String just like getNamespaceBindings() does. Oh, sorry. Yes, that

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2012-01-03 Thread Matthias Brantner
Review: Needs Fixing Needs Fixing: include/zorba/store_consts.h already provides an NsScoping enum. Comment: An alternative return value could be a map (which is nothing else than an efficient vector containing pairs). --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2011-12-31 Thread Chris Hillery
is requested to review the proposed merge of lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba. === modified file 'doc/cxx/examples/simple.cpp' --- doc/cxx/examples/simple.cpp 2011-06-14 14:21:49 + +++ doc/cxx/examples/simple.cpp 2011-12-31 09:17:24 + @@ -33,14 +33,14 @@ std::cout

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2011-12-31 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2011-12-31 Thread Zorba Build Bot
the proposed merge of lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba

2011-12-31 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/get-namespace-bindings into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/get-namespace-bindings/+merge/87187 -- https://code.launchpad.net/~zorba-coders/zorba