Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba

2013-08-14 Thread Chris Hillery
Review: Approve

I cleaned up a few more references to XQuery in the doc, and a couple other 
doc bits. Looks good now.
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba

2013-08-14 Thread Sorin Marian Nasoi
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba

2013-08-14 Thread Zorba Build Bot
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba

2013-08-14 Thread Zorba Build Bot
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba

2013-08-14 Thread Zorba Build Bot
Validation queue succeeded - proposal merged!
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba

2013-08-14 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/update3.0_zorba-query-module into 
lp:zorba has been updated.

Status: Needs review = Merged

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba

2013-08-14 Thread Zorba Build Bot
Validation queue result for 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756

Stage CommitZorba failed.

Check console output at http://jenkins.lambda.nu/job/CommitZorba/126/console to 
view the results.
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba

2013-08-13 Thread Zorba Build Bot
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba

2013-08-13 Thread Zorba Build Bot
Voting criteria failed for the following merge proposals:

https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756
 :
Votes: {'Pending': 2}
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba

2013-08-13 Thread Zorba Build Bot
Validation queue result for 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756

Stage CommitZorba failed.

Check console output at http://jenkins.lambda.nu/job/CommitZorba/122/console to 
view the results.
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba

2013-08-13 Thread Zorba Build Bot
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba

2013-08-13 Thread Zorba Build Bot
Voting criteria failed for the following merge proposals:

https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756
 :
Votes: {'Pending': 2}
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba

2013-08-13 Thread Zorba Build Bot
Validation queue result for 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756

Stage CommitZorba failed.

Check console output at http://jenkins.lambda.nu/job/CommitZorba/123/console to 
view the results.
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_zorba-query-module into lp:zorba

2013-08-13 Thread Chris Hillery
Review: Needs Fixing

Two small issues:

1. The module version number should be changed back to 1.0, since the name has 
changed so it's not the same module anymore. Don't forget to update both 
CMakeLists.txt and the module text itself, as well as (at least) FOTS driver 
where it is imported.

2. Can you try remove the word XQuery as much as possible from the module 
XQDoc? eg, instead of XQuery program, just write query, I think. In the 
main header comment, you could spell out that a query is either an XQuery or a 
JSONiq query.

Sorin: it looks like all the changes to FOTS driver are mechanical, eg. 
changing xqxq: to zq:. However, please review to make sure there are no 
surprises there.
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_zorba-query-module/+merge/179756
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp