Review: Needs Fixing
http://json.org/ says that not only '' and '\' need to be escaped with a
backslash but also a solidus '/'.
And, some control characters have special backspace escapes: backspace (x8 -
\b), formfeed (xC - \f), newline (xA - \n), carriage return (xD - \r) and
HTab (x9 -
json.org says that '/' *MAY* be escaped, but it's not *REQUIRED* for it to be
so.
As for the rest, I've added code to emit them. (The original code didn't emit
them either.) Note that it wasn't wrong, just less pretty.
I added a test (within the limits of what Zorba accepts in characters).
Review: Needs Fixing
cannot test it on windows as it doesn't currently build on windows (this
doesn't have anything to do with this branch).
on linux:
The following tests FAILED:
1104 - test/rbkt/zorba/jsoniq/coll_dyn_03 (Failed)
--
I think that query is wrong since there are newline literals in strings rather
than \n.
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Actually, the query may be OK, but the expected result is wrong. I've fixed it.
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~paul-lucas/zorba/bug-1025622 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636
Validation queue job bug-1025622-2012-07-19T18-07-03.448Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~paul-lucas/zorba/bug-1025622 into lp:zorba has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636
Your team
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/bug-1025622 into
lp:zorba.
Requested reviews:
Dennis Knochenwefel (dennis-knochenwefel)
Paul J. Lucas (paul-lucas)
Related bugs:
Bug #1025622 in Zorba: incorrect JSON serialization of supplementory plane
code points
The proposal to merge lp:~paul-lucas/zorba/bug-1025622 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-1025622-2012-07-18T23-51-03.584Z/log.html
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Needs Fixing
Cool, thanks. Please add a couple test cases including the problem query
described in the bug report; also, add a note to the Changelog mentioning the
bug fix.
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636
Your team Zorba Coders is subscribed to
Validation queue job bug-1025622-2012-07-18T23-51-03.584Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Approve, 1 Needs Fixing, 1 Pending.
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
The proposal to merge lp:~paul-lucas/zorba/bug-1025622 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636
I added a mention in the change log and also the one test (can't think of
others).
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
s/supplementory/supplementary/
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
20 matches
Mail list logo
