Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123163 into lp:zorba

2013-04-01 Thread Nicolae Brinza
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123163 into lp:zorba

2013-04-01 Thread Matthias Brantner
Review: Approve

Removing errors breaks api compatibility. I leave it for Chris
to take a decision on whether this needs to be fixed.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123163 into lp:zorba

2013-04-01 Thread Paul J. Lucas
 Removing errors breaks api compatibility.

Removing what errors?  Which API?
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123163 into lp:zorba

2013-04-01 Thread Matthias Brantner

On Apr 1, 2013, at 12:05 PM, Paul J. Lucas p...@lucasmail.org wrote:

 Removing errors breaks api compatibility.
 
 Removing what errors?  
FOFI0001 and FOFI0002


 Which API?
 include/zorba/pregenerated/diagnostic_list.h

 -- 
 https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
 You are reviewing the proposed merge of lp:~zorba-coders/zorba/bug-1123163 
 into lp:zorba.


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123163 into lp:zorba

2013-04-01 Thread Chris Hillery
Review: Approve

As they were likely unused, I don't have a problem with those removals. Not 
sure how to handle this situation more generally going forward.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123163 into lp:zorba

2013-04-01 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1123163 into lp:zorba has been 
updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123163 into lp:zorba

2013-04-01 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/bug-1123163-2013-04-02T00-02-44.075Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123163 into lp:zorba

2013-04-01 Thread Zorba Build Bot
Validation queue job bug-1123163-2013-04-02T00-02-44.075Z is finished. The 
final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123163 into lp:zorba

2013-04-01 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/bug-1123163 into lp:zorba has been 
updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123163 into lp:zorba

2013-03-31 Thread Paul J. Lucas
The proposal to merge lp:~zorba-coders/zorba/bug-1123163 into lp:zorba has been 
updated.

Description changed to:

Rewrote format-integer() code -- fixed all bugs.  Note that tests 049, 050, and 
052 should not be run because we're electing not to implement the functionality.

Also some format-date() code clean-up.

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123163 into lp:zorba

2013-03-31 Thread Paul J. Lucas
The proposal to merge lp:~zorba-coders/zorba/bug-1123163 into lp:zorba has been 
updated.

Description changed to:

Rewrote format-integer() code -- fixed all bugs.  Note that tests 049, 050, and 
052 should not be run because we're electing not to implement the functionality.

Also some format-date() code clean-up as well as factoring common code out.

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123163 into lp:zorba

2013-03-31 Thread Paul J. Lucas
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123163 into lp:zorba

2013-03-31 Thread Paul J. Lucas
The proposal to merge lp:~zorba-coders/zorba/bug-1123163 into lp:zorba has been 
updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123163 into lp:zorba

2013-03-31 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/bug-1123163-2013-04-01T02-54-19.028Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123163 into lp:zorba

2013-03-31 Thread Zorba Build Bot
Validation queue job bug-1123163-2013-04-01T02-54-19.028Z is finished. The 
final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123163 into lp:zorba

2013-03-31 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1, Needs Information  1, Resubmit  1. Got: 1 
Approve.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123163 into lp:zorba

2013-03-31 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bug-1123163 into lp:zorba has been 
updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1123163/+merge/156322
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp