Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-914655 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-914655 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-914655 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 -- https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-914655 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-914655-2012-04-16T08-11-01.617Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-914655 into lp:zorba
Validation queue job bug-914655-2012-04-16T08-11-01.617Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-914655 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-914655 into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 -- https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-914655 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-914655 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 -- https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-914655 into lp:zorba
Validation queue job bug-914655-2012-04-15T16-56-58.153Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-914655 into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 2 Approve, 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-914655 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-914655 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 -- https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-914655 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-914655 into lp:zorba has been updated. Commit Message changed to: Fix for bug #914655. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 -- https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-914655 into lp:zorba
Review: Approve Looks good to me. Could the problem be reproduced without debugger? If so, we should add a test for it. Also adding Markos as a reviewer. -- https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-914655 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-914655 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 -- https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-914655 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-914655-2012-04-14T06-16-05.653Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-914655 into lp:zorba
Validation queue job bug-914655-2012-04-14T06-16-05.653Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-914655 into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 2 Approve, 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-914655 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-914655 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 -- https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-914655 into lp:zorba
Looks good to me. Could the problem be reproduced without debugger? If so, we should add a test for it. Good point. I found a test to add. -- https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-914655 into lp:zorba
David Graf has proposed merging lp:~zorba-coders/zorba/bug-914655 into lp:zorba.
Requested reviews:
David Graf (davidagraf)
Matthias Brantner (matthias-brantner)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922
Fix for bug #914655.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/runtime/eval/eval.cpp'
--- src/runtime/eval/eval.cpp 2012-04-08 21:39:25 +
+++ src/runtime/eval/eval.cpp 2012-04-13 15:36:25 +
@@ -62,6 +62,20 @@
{
}
+///**
+
+/
+void
+EvalIteratorState::reset(PlanState aPlanState)
+{
+ PlanIteratorState::reset(aPlanState);
+ // When an exception is thrown during an EvalIterator::nextImpl invocation
+ // or when the EvalIterator doesn't return all resulting items of an other reason,
+ // the PlanWrapper is not properly destroyed. Therefore, we destroy it in the reset
+ // to prevent troubles the next time the EvalIterator is used.
+ thePlanWrapper = 0;
+}
+
///**
=== modified file 'src/runtime/eval/eval.h'
--- src/runtime/eval/eval.h 2012-03-28 05:19:57 +
+++ src/runtime/eval/eval.h 2012-04-13 15:36:25 +
@@ -37,6 +37,8 @@
EvalIteratorState();
~EvalIteratorState();
+
+ void reset(PlanState);
};
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-914655 into lp:zorba
Fix for bug #914655. -- https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-914655 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-914655/+merge/101922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
