[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
Attempt to merge into lp:zorba failed due to conflicts: text conflict in src/store/naive/simple_pul.cpp -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-966706-2012-05-03T10-09-44.874Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
Validation queue job bug-966706-2012-05-03T10-09-44.874Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
Attempt to merge into lp:zorba failed due to conflicts: text conflict in src/store/naive/simple_pul.cpp -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
This is ready for review again. -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
Review: Approve Looks good. I have disabled some debug output in rev. 10748. -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
Review: Approve
It would be nice to have 2 comments explaining
1) the modification of the parameter in simple_index_value.cpp:380 and 674 and
2) the role of key2 in Store::populateValueIndex.
It would also be nice to use the typedef here:
=== modified file 'src/store/naive/simple_pul.cpp'
--- src/store/naive/simple_pul.cpp 2012-04-27 19:58:40 +
+++ src/store/naive/simple_pul.cpp 2012-04-27 20:03:20 +
@@ -1463,8 +1463,8 @@
{
csize numRoots = rootNodes.size();
- std::vectorCollectionPul*::const_iterator collIte =
theCollectionPuls.begin();
- std::vectorCollectionPul*::const_iterator collEnd =
theCollectionPuls.end();
+ CollectionPuls::const_iterator collIte = theCollectionPuls.begin();
+ CollectionPuls::const_iterator collEnd = theCollectionPuls.end();
for (; collIte != collEnd; ++collIte)
{
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
Review: Needs Fixing
It seems that automatic indexes are not maintained if a node is deleted. The
following example shows this:
library module:
module namespace seq = http://www.foo.com/default;;
import module namespace ddl =
http://www.zorba-xquery.com/modules/store/static/collections/ddl;;
import module namespace dml =
http://www.zorba-xquery.com/modules/store/static/collections/dml;;
import module namespace iddl =
http://www.zorba-xquery.com/modules/store/static/indexes/ddl;;
import module namespace idml =
http://www.zorba-xquery.com/modules/store/static/indexes/dml;;
declare namespace an = http://www.zorba-xquery.com/annotations;;
declare collection seq:counters as node()*;
declare %an:automatic %an:unique %an:value-equality index seq:counters-by-uri
on nodes dml:collection(xs:QName(seq:counters))
by xs:string(@uri) as xs:string;
declare %an:sequential function seq:init()
{
ddl:create(xs:QName(seq:counters));
iddl:create(xs:QName(seq:counters-by-uri));
dml:insert-nodes(xs:QName(seq:counters), foo uri=1/);
};
declare function seq:index ()
{
idml:probe-index-point-value(xs:QName(seq:counters-by-uri), 1)
};
declare %an:sequential function seq:reset ()
{
dml:delete-nodes(idml:probe-index-point-value(xs:QName(seq:counters-by-uri),
1));
};
main module:
import module namespace seq = http://www.foo.com/default; at default.xq;
seq:init();
variable $foo := seq:index();
seq:reset();
variable $bar := seq:index();
$foo, $bar
The expected result is 'foo uri=1/foo uri=1/' but should be 'foo
uri=1/'.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
I have fixed your test, but now I have a problem with test index/undo3.xq. Its result is non-deterministic. Most of the time it returns the correct result, but sometimes not. And valgrind does not show any errors :( -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
I have implemented undo for incrementally maintained indexes. -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-966706-2012-04-23T12-28-50.058Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 2 Approve, 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
Matthias Brantner has proposed merging lp:~zorba-coders/zorba/bug-966706 into
lp:zorba.
Requested reviews:
Markos Zaharioudakis (markos-za)
Till Westmann (tillw)
Related bugs:
Bug #966706 in Zorba: key uniqueness of value equality index not enforced
https://bugs.launchpad.net/zorba/+bug/966706
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
fixed bug #966706 (key uniqueness of value equality index not enforced)
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'ChangeLog'
--- ChangeLog 2012-04-10 15:41:57 +
+++ ChangeLog 2012-04-11 07:12:20 +
@@ -16,8 +16,12 @@
* Fixed bug #967428 (do not hoist index creation outside a try-catch)
* Fixed performance problem with the findNodeSources function of the no-copy rule
* Fixed bug #872234 (prevent a rewritting to take place in case of sequential expr)
+ TREE
* Fixed bug #912586, #912593 and #912722 (assertion failures with lax validation)
* Fixed bug #949910 (has-children may be invoked on all nodes). Internally, zorba::store::Item::getChildren() now returns NULL on node classes without offspring (instead of raising an error).
+===
+ * Fixed bug #966706 (key uniqueness of value equality index not enforced)
+ MERGE-SOURCE
version 2.2
=== modified file 'src/store/naive/simple_pul.cpp'
--- src/store/naive/simple_pul.cpp 2012-03-28 05:19:57 +
+++ src/store/naive/simple_pul.cpp 2012-04-11 07:12:20 +
@@ -1746,6 +1746,16 @@
CollectionPul* pul = collIte-second;
applyList(pul-theDeleteCollectionList);
}
+
+// Need to do this here because refreshIndices can raise an error (e.g. if
+// the unique constraint of an index is violated)
+for (collIte = theCollectionPuls.begin(); collIte != collEnd; ++collIte)
+{
+ CollectionPul* pul = collIte-second;
+ // Refresh each incrementally maintained index using its before and after
+ // deltas.
+ pul-refreshIndices();
+}
}
catch (...)
{
@@ -2228,10 +2238,6 @@
{
try
{
-// Refresh each incrementally maintained index using its before and after
-// deltas.
-refreshIndices();
-
// If necessary, adjust the position of trees inside this collection.
if (theAdjustTreePositions)
{
=== added file 'test/rbkt/ExpQueryResults/zorba/index/unique.xml.res'
--- test/rbkt/ExpQueryResults/zorba/index/unique.xml.res 1970-01-01 00:00:00 +
+++ test/rbkt/ExpQueryResults/zorba/index/unique.xml.res 2012-04-11 07:12:20 +
@@ -0,0 +1,1 @@
+zerr:ZDDY0024 zerr:ZDDY0024
=== added file 'test/rbkt/Queries/zorba/index/unique.xq'
--- test/rbkt/Queries/zorba/index/unique.xq 1970-01-01 00:00:00 +
+++ test/rbkt/Queries/zorba/index/unique.xq 2012-04-11 07:12:20 +
@@ -0,0 +1,27 @@
+import module namespace u = http://www.zorba-xquery.com/unique-index; at unique.xqlib;
+
+import module namespace dml = http://www.zorba-xquery.com/modules/store/static/collections/dml;;
+import module namespace idml = http://www.zorba-xquery.com/modules/store/static/indexes/dml;;
+
+declare namespace zerr = http://www.zorba-xquery.com/errors;;
+declare namespace err = http://www.w3.org/2005/xqt-errors;;
+
+u:create-db();
+
+try
+{{
+ (dml:insert-nodes($u:auctions1, person id=1/),
+ dml:insert-nodes($u:auctions1, person id=1/));
+ ()
+}} catch * {
+ $err:code, dml:collection($u:auctions1)
+},
+
+try
+{{
+ (dml:insert-nodes($u:auctions2, person id=1/),
+ dml:insert-nodes($u:auctions2, person id=1/));
+ ()
+}} catch * {
+ $err:code, dml:collection($u:auctions2)
+}
=== added file 'test/rbkt/Queries/zorba/index/unique.xqlib'
--- test/rbkt/Queries/zorba/index/unique.xqlib 1970-01-01 00:00:00 +
+++ test/rbkt/Queries/zorba/index/unique.xqlib 2012-04-11 07:12:20 +
@@ -0,0 +1,36 @@
+module namespace auctions = http://www.zorba-xquery.com/unique-index;;
+
+import module namespace ddl = http://www.zorba-xquery.com/modules/store/static/collections/ddl;;
+import module namespace iddl = http://www.zorba-xquery.com/modules/store/static/indexes/ddl;;
+import module namespace dml = http://www.zorba-xquery.com/modules/store/static/collections/dml;;
+import module namespace idml = http://www.zorba-xquery.com/modules/store/static/indexes/dml;;
+
+declare namespace ann = http://www.zorba-xquery.com/annotations;;
+
+declare variable $auctions:auctions1 := xs:QName(auctions:auctions1);
+declare variable $auctions:PersonId1 := xs:QName(auctions:PersonId1);
+declare variable $auctions:auctions2 := xs:QName(auctions:auctions2);
+declare variable $auctions:PersonId2 := xs:QName(auctions:PersonId2);
+
+declare collection auctions:auctions1 as node()*;
+
+declare %ann:unique %ann:automatic %ann:value-equality index auctions:PersonId1
+on nodes dml:collection(xs:QName(auctions:auctions1))
+by xs:string(./@id) as xs:string;
+
+declare collection auctions:auctions2 as node()*;
+
+declare
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
Attempt to merge into lp:zorba failed due to conflicts: text conflict in ChangeLog -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-966706-2012-04-11T07-20-03.19Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
Validation queue job bug-966706-2012-04-11T07-20-03.19Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 3 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba
Review: Needs Fixing The problem is that now an index refresh must be undoable. I am looking at the code to think wat is the best way to do the undo. -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
