Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/cleanup-guestbook.xq into lp:zorba

2012-06-15 Thread Ghislain Fourny
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/cleanup-guestbook.xq/+merge/110413
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/cleanup-guestbook.xq into lp:zorba

2012-06-15 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/cleanup-guestbook.xq into lp:zorba 
has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/cleanup-guestbook.xq/+merge/110413
-- 
https://code.launchpad.net/~zorba-coders/zorba/cleanup-guestbook.xq/+merge/110413
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/cleanup-guestbook.xq into lp:zorba

2012-06-15 Thread Zorba Build Bot
Validation queue job cleanup-guestbook.xq-2012-06-15T16-02-59.705Z is finished. 
The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/cleanup-guestbook.xq/+merge/110413
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/cleanup-guestbook.xq into lp:zorba

2012-06-15 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/cleanup-guestbook.xq into lp:zorba 
has been updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/cleanup-guestbook.xq/+merge/110413
-- 
https://code.launchpad.net/~zorba-coders/zorba/cleanup-guestbook.xq/+merge/110413
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/cleanup-guestbook.xq into lp:zorba

2012-06-14 Thread Till Westmann
Till Westmann has proposed merging lp:~zorba-coders/zorba/cleanup-guestbook.xq 
into lp:zorba.

Requested reviews:
  Till Westmann (tillw)
  Ghislain Fourny (gislenius)

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/cleanup-guestbook.xq/+merge/110413

remove unnecessary annotations and clean-up indentation
-- 
https://code.launchpad.net/~zorba-coders/zorba/cleanup-guestbook.xq/+merge/110413
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'test/unit/guestbook.xq'
--- test/unit/guestbook.xq	2012-05-03 12:31:51 +
+++ test/unit/guestbook.xq	2012-06-14 20:56:22 +
@@ -21,10 +21,10 @@
 
 declare namespace ann = http://www.zorba-xquery.com/annotations;; 
 
-declare %ann:ordered collection guestbook:entries as node()*;
+declare collection guestbook:entries as node()*;
 declare variable $guestbook:entries as xs:QName := xs:QName(guestbook:entries);
 
-declare %ann:sequential function guestbook:list() 
+declare function guestbook:list() 
 {  
   let $entries := dml:collection($guestbook:entries)
   let $num_entries := fn:count($entries)
@@ -38,11 +38,11 @@
 };
 
 declare function guestbook:window() {
- let $x := 1 to 1000
- for tumbling window $w in $x
- start at $s when fn:true()
- end at $e when $e - $s eq 51
- return window{ $w }/window
+  let $x := 1 to 1000
+  for tumbling window $w in $x
+  start at $s when fn:true()
+  end at $e when $e - $s eq 51
+  return window{ $w }/window
 };
 
 

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/cleanup-guestbook.xq into lp:zorba

2012-06-14 Thread Till Westmann
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/cleanup-guestbook.xq/+merge/110413
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/cleanup-guestbook.xq into lp:zorba

2012-06-14 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/cleanup-guestbook.xq into lp:zorba 
has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/cleanup-guestbook.xq/+merge/110413
-- 
https://code.launchpad.net/~zorba-coders/zorba/cleanup-guestbook.xq/+merge/110413
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/cleanup-guestbook.xq into lp:zorba

2012-06-14 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/cleanup-guestbook.xq-2012-06-14T21-30-02.066Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/cleanup-guestbook.xq/+merge/110413
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/cleanup-guestbook.xq into lp:zorba

2012-06-14 Thread Zorba Build Bot
Validation queue job cleanup-guestbook.xq-2012-06-14T21-30-02.066Z is finished. 
The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/cleanup-guestbook.xq/+merge/110413
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/cleanup-guestbook.xq into lp:zorba

2012-06-14 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1. Got: 1 Approve, 1 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/cleanup-guestbook.xq/+merge/110413
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp