Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_disputed_tc_2 into lp:zorba

2013-05-05 Thread Paul J. Lucas 
Review: Disapprove

I've already fixed two of the bugs (a separate merge proposal is awaiting 
Matthias' approval), and I'll probably fix the 3rd soon, so there's not that 
much point in approving this.
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_disputed_tc_2/+merge/162233
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_disputed_tc_2 into lp:zorba

2013-05-02 Thread Sorin Marian Nasoi 
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_disputed_tc_2/+merge/162233
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_disputed_tc_2 into lp:zorba

2013-05-02 Thread Sorin Marian Nasoi 
Sorin Marian Nasoi has proposed merging 
lp:~zorba-coders/zorba/fix_disputed_tc_2 into lp:zorba.

Commit message:
- removed 3 test-cases marked as "disputed". Added new bug numbers from LP.

Requested reviews:
  Paul J. Lucas (paul-lucas)
  Sorin Marian Nasoi (sorin.marian.nasoi)

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix_disputed_tc_2/+merge/162233
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_disputed_tc_2/+merge/162233
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'test/fots/CMakeLists.txt'
--- test/fots/CMakeLists.txt	2013-05-02 01:21:38 +
+++ test/fots/CMakeLists.txt	2013-05-02 19:54:28 +
@@ -119,9 +119,6 @@
 #All these entries should have a *valid* opened bug number from W3C bugzilla.
 EXPECTED_FOTS_FAILURE (DISPUTED prod-SchemaImport qischema040 21339)
 EXPECTED_FOTS_FAILURE (DISPUTED prod-SchemaImport qischema040a 21339)
-EXPECTED_FOTS_FAILURE (DISPUTED fn-format-integer format-integer-044 21448)
-EXPECTED_FOTS_FAILURE (DISPUTED fn-format-date format-date-en152 21558)
-EXPECTED_FOTS_FAILURE (DISPUTED fn-format-dateTime format-dateTime-en152 21558)
 EXPECTED_FOTS_FAILURE (DISPUTED prod-OrderByClause orderBy20 21619)
 EXPECTED_FOTS_FAILURE (DISPUTED prod-OrderByClause orderBy21 21619)
 EXPECTED_FOTS_FAILURE (DISPUTED prod-FunctionDecl function-decl-reserved-function-names-001 21568)
@@ -178,7 +175,10 @@
 EXPECTED_FOTS_FAILURE (fn-environment-variable environment-variable-005 0)
 EXPECTED_FOTS_FAILURE (fn-environment-variable environment-variable-006 0)
 EXPECTED_FOTS_FAILURE (fn-environment-variable environment-variable-007 0)
+EXPECTED_FOTS_FAILURE (fn-format-date format-date-en152 1175752)
+EXPECTED_FOTS_FAILURE (fn-format-dateTime format-dateTime-en152 1175752)
 EXPECTED_FOTS_FAILURE (fn-format-dateTime format-dateTime-006 0)
+EXPECTED_FOTS_FAILURE (fn-format-integer format-integer-044 1162631)
 EXPECTED_FOTS_FAILURE (fn-format-number numberformat41 1167427)
 EXPECTED_FOTS_FAILURE (fn-format-number numberformat42 1167427)
 EXPECTED_FOTS_FAILURE (fn-format-number numberformat60a 1167609)

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp