Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/move-xqxq-core into lp:zorba

2012-10-26 Thread Juan Zacarias
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/move-xqxq-core/+merge/131295
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/move-xqxq-core into lp:zorba

2012-10-26 Thread Juan Zacarias
The proposal to merge lp:~zorba-coders/zorba/move-xqxq-core into lp:zorba has 
been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/move-xqxq-core/+merge/131295
-- 
https://code.launchpad.net/~zorba-coders/zorba/move-xqxq-core/+merge/131295
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/move-xqxq-core into lp:zorba

2012-10-26 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/move-xqxq-core-2012-10-26T14-50-00.735Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/move-xqxq-core/+merge/131295
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/move-xqxq-core into lp:zorba

2012-10-26 Thread Zorba Build Bot
Validation queue job move-xqxq-core-2012-10-26T14-50-00.735Z is finished. The 
final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/move-xqxq-core/+merge/131295
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/move-xqxq-core into lp:zorba

2012-10-24 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/move-xqxq-core into lp:zorba has 
been updated.

Commit Message changed to:

Moved XQXQ into Zorba core.

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/move-xqxq-core/+merge/131295
-- 
https://code.launchpad.net/~zorba-coders/zorba/move-xqxq-core/+merge/131295
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/move-xqxq-core into lp:zorba

2012-10-24 Thread Chris Hillery
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/move-xqxq-core/+merge/131295
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/move-xqxq-core into lp:zorba

2012-10-24 Thread Matthias Brantner
Review: Approve

Conditional approval because everything seems to work.

However, the ChangeLog should be updated and an email should be sent to the 
list letting everybody know that they have to remove xqxq from their 
zorba_modules directories.
-- 
https://code.launchpad.net/~zorba-coders/zorba/move-xqxq-core/+merge/131295
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/move-xqxq-core into lp:zorba

2012-10-24 Thread Chris Hillery
I have pushed a ChangeLog change.

Tested locally: If I bump the XQXQ version number to 1.1, it can actually 
co-exist with the non-core module. Should I do this for convenience, or is it 
better to force people to remove the old one?
-- 
https://code.launchpad.net/~zorba-coders/zorba/move-xqxq-core/+merge/131295
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/move-xqxq-core into lp:zorba

2012-10-24 Thread Matthias Brantner
 I have pushed a ChangeLog change.
 
 Tested locally: If I bump the XQXQ version number to 1.1, it can actually co-
 exist with the non-core module. Should I do this for convenience, or is it
 better to force people to remove the old one?
Good question. My feeling is that the old one should be removed because both of 
the modules provide exactly the same functionality.
-- 
https://code.launchpad.net/~zorba-coders/zorba/move-xqxq-core/+merge/131295
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/move-xqxq-core into lp:zorba

2012-10-24 Thread Chris Hillery
 My feeling is that the old one should be removed because both
 of the modules provide exactly the same functionality.

I tend to agree. Ok, I won't push that change, and I'll send out an email.

Juan, please review soon; thanks!
-- 
https://code.launchpad.net/~zorba-coders/zorba/move-xqxq-core/+merge/131295
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp