Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
Your team Zorba Coders
Validation queue succeeded - proposal merged!
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
Your team Zorba Coders
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
Stage ZorbaVQ failed.
Check console output at http://jenkins.lambda.nu/job/ZorbaVQ/92/console to view
the results.
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
Your
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Commit Message changed to:
Changed module's errors to the new modules guidelines; Potential fix for
execvpe() on Macs
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba
Nicolae Brinza has proposed merging lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module.
Commit message:
Changed module's errors to the new modules guidelines; Potential fix for
execvpe() on Macs
Requested reviews:
Nicolae Brinza (nbrinza)
Ghislain Fourny (gislenius)
Related
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
Attempt to merge into lp:zorba/process-module failed due to conflicts:
text conflict in src/process-2.xq.src/process.cpp
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-06-27T15-10-41.002Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
Validation queue job process-2-2013-06-27T15-10-41.002Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1, Needs Information 1, Resubmit 1. Got: 1
Approve, 1 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
Your team Zorba Coders is subscribed to branch
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-06-13T10-31-56.151Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
The attempt to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:281
(message):
Validation queue job process-2-2013-06-13T10-31-56.151Z is finished
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
FYI, you're going to need to merge changes from lp:zorba/process-module in
order for the build to succeed. Paul's been moving #include files around on the
Zorba trunk which affects many non-core modules.
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
Your team Zorba
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
I've merged Paul's change -- it was only a one line change.
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-06-13T11-03-45.577Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Validation queue job process-2-2013-06-13T11-03-45.577Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge
Review: Approve
I made some final changes, i.e. moved the files and improved the documentation.
Concerning me, it's ready to go.
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list:
For some reason, the commits to my checked-out branch are not pushed
automatically, and I forgot to do it manually. It is pushed now.
I've also fixed all issues you reported except for the namespace change to
zorba.io. As far as I understood, it will be done for all modules at once --
it is
Matthias,
They URI messages won't appear anymore, but I've done it by calling abort()
instead of exit() in the child fork() in the process module, because:
-- it will keep the Zorba URIs leaks messages in the Release build
-- the exit code in the case of an error is lost anyway due to the
Review: Needs Fixing
- I didn't see the changes you described in the last comment. Did you not push
them?
- Why does the module use XQuery instead of JSONiq? I think it should use
JSONiq and not use prefixes for types etc.
- we might have to change the namespace to zorba.io
- comments should
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-05-27T14-21-35.131Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
I've fixed all the issues except for the leaks problem. I have not removed the
printing of the URIs because it would disable them for the entire Zorba engine.
Even if the messages are removed there is still the problem of the exit code,
which cannot be fixed easily now.
--
--
Validation queue job process-2-2013-05-27T14-21-35.131Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1, Needs Information 1, Resubmit 1. Got: 1
Approve, 1 Needs Fixing.
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
Your team Zorba Coders is subscribed to branch
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
Let's not worry about the leaks for now. Instead, we should simply disable the
debug output printing the referenced uris.
I think we should bring the init/shutdown problem to the Zorba team. This has
been bothering us and others for quite some time. Zorba 3.0 is the only time to
fix this.
Regarding the referenced URI messages -- these are indeed coming from the
StringPool as leaked entries. When the main process is fork()'ed, the child
process is basically a copy of the parent process with all the statically
allocated objects duplicated. When the child process calls exit(),
Nicolae Brinza has proposed merging lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module.
Commit message:
Version 2.0 of the process module, allows running executables directly, without
invoking bash/cmd.exe
Requested reviews:
Nicolae Brinza (nbrinza)
Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-05-17T12-29-40.913Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
The attempt to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job process-2-2013-05-17T12-29-40.913Z is finished
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-05-17T13-03-41.447Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
The attempt to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job process-2-2013-05-17T13-03-41.447Z is finished
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-05-17T13-34-44.754Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
The attempt to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job process-2-2013-05-17T13-34-44.754Z is finished
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-05-17T13-53-40.588Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
The attempt to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job process-2-2013-05-17T13-53-40.588Z is finished
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-05-17T14-27-39.824Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
The attempt to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job process-2-2013-05-17T14-27-39.824Z is finished
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-05-17T14-42-40.749Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
The attempt to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job process-2-2013-05-17T14-42-40.749Z is finished
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
There are additional revisions which have not been approved in review. Please
seek review and approval of these new revisions.
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Nicolae Brinza has proposed merging lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module.
Commit message:
Version 2.0 of the process module, allows running executables directly, without
invoking bash/cmd.exe
Requested reviews:
Nicolae Brinza (nbrinza)
Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Commit Message changed to:
Version 2.0 of the process module, allows running executables directly, without
invoking bash/cmd.exe
For more details, see:
https://code.launchpad.net/~zorba
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-05-17T14-50-41.743Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
The attempt to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job process-2-2013-05-17T14-50-41.743Z is finished
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/process-2-2013-05-17T15-29-41.901Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Validation queue job process-2-2013-05-17T15-29-41.901Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1, Needs Information 1, Resubmit 1. Got: 1
Approve, 1 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
Your team Zorba Coders is subscribed to branch
The proposal to merge lp:~zorba-coders/zorba/process-2 into
lp:zorba/process-module has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415
--
https://code.launchpad.net/~zorba-coders/zorba/process-2
Review: Needs Fixing
- I like the signatures and the documentation
- The two modules should both live in the same branch process (subdirectories
process/v1 and process/v2) for the versioning to work the v2 one needs to be
added first and then the v1 one. If we don't want to change all of our
84 matches
Mail list logo