Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geo-module into lp:zorba/geo-module

2013-07-10 Thread Juan Zacarias
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geo-module/+merge/170212
Your team Zorba Coders is subscribed to branch lp:zorba/geo-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geo-module into lp:zorba/geo-module

2013-07-10 Thread Zorba Build Bot
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geo-module/+merge/170212

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geo-module/+merge/170212
Your team Zorba Coders is subscribed to branch lp:zorba/geo-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geo-module into lp:zorba/geo-module

2013-07-10 Thread Zorba Build Bot
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geo-module/+merge/170212

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geo-module/+merge/170212
Your team Zorba Coders is subscribed to branch lp:zorba/geo-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geo-module into lp:zorba/geo-module

2013-07-10 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/update3.0_geo-module into 
lp:zorba/geo-module has been updated.

Status: Needs review = Merged

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geo-module/+merge/170212
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geo-module/+merge/170212
Your team Zorba Coders is subscribed to branch lp:zorba/geo-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geo-module into lp:zorba/geo-module

2013-07-10 Thread Zorba Build Bot
Validation queue succeeded - proposal merged!
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geo-module/+merge/170212
Your team Zorba Coders is subscribed to branch lp:zorba/geo-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geo-module into lp:zorba/geo-module

2013-07-10 Thread Zorba Build Bot
Validation queue result for 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geo-module/+merge/170212

Stage CommitZorba failed.

Check console output at http://jenkins.lambda.nu/job/CommitZorba/19/console to 
view the results.
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geo-module/+merge/170212
Your team Zorba Coders is subscribed to branch lp:zorba/geo-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geo-module into lp:zorba/geo-module

2013-07-09 Thread Chris Hillery
Review: Needs Fixing

1. Very sorry for the mis-information, but this module should NOT have been 
moved into the zorba.io namespace. EXpath modules should remain in their 
expath.org/ns namespace.

2. Remove the how to build the module information from the XQDoc; XQDoc 
should only contain information on *using* the module, not building it. Move 
this information into a top-level README.txt file in the module.

3. Are there any errors which may be raised by these module functions? If so, 
are they documented?

4. Why did you change the GEOS_VERSION_PATCH check in geo_functions.cpp ?
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geo-module/+merge/170212
Your team Zorba Coders is subscribed to branch lp:zorba/geo-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geo-module into lp:zorba/geo-module

2013-07-09 Thread Juan Zacarias
 1. Very sorry for the mis-information, but this module should NOT have been
 moved into the zorba.io namespace. EXpath modules should remain in their
 expath.org/ns namespace.
 
 2. Remove the how to build the module information from the XQDoc; XQDoc
 should only contain information on *using* the module, not building it. Move
 this information into a top-level README.txt file in the module.
ok

 
 3. Are there any errors which may be raised by these module functions? If so,
 are they documented?
Actually there are, I will update it.

 
 4. Why did you change the GEOS_VERSION_PATCH check in geo_functions.cpp ?
It was breaking my windows build of the module, not sure why it wasn't 
happening before.
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geo-module/+merge/170212
Your team Zorba Coders is subscribed to branch lp:zorba/geo-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geo-module into lp:zorba/geo-module

2013-07-09 Thread Chris Hillery
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geo-module/+merge/170212
Your team Zorba Coders is subscribed to branch lp:zorba/geo-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp