[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-14 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/updrevalidate into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-14 Thread Zorba Build Bot
Validation queue job updrevalidate-2011-10-14T08-10-00.964Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorb

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-14 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/updrevalidate-2011-10-14T08-10-00.964Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-14 Thread Federico Cavalieri
The proposal to merge lp:~zorba-coders/zorba/updrevalidate into lp:zorba has been updated. Status: Rejected => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/793

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-14 Thread Federico Cavalieri
The proposal to merge lp:~zorba-coders/zorba/updrevalidate into lp:zorba has been updated. Status: Approved => Rejected For more details, see: https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/793

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-14 Thread Federico Cavalieri
The proposal to merge lp:~zorba-coders/zorba/updrevalidate into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-14 Thread Federico Cavalieri
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-c

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-14 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/updrevalidate into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-14 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-14 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/updrevalidate into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Federico Cavalieri
> > Why variable numUpdates in PULImpl::mergeUpdateList is declared, assigned > but > > never read? > > Good question :) The easy answer is to just remove it. But I think it can > actually be used to replace the myList.size() in the 2 for loops at lines 1289 > and 1308. Even though new entries can

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Markos Zaharioudakis
> Why variable numUpdates in PULImpl::mergeUpdateList is declared, assigned but > never read? Good question :) The easy answer is to just remove it. But I think it can actually be used to replace the myList.size() in the 2 for loops at lines 1289 and 1308. Even though new entries can be added in

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Federico Cavalieri
Why variable numUpdates in PULImpl::mergeUpdateList is declared, assigned but never read? -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorb

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Federico Cavalieri
> Sure, but to me it looks like no change has been made at all (Preview Diff > contains only the word Empty) and no "In a few minutes the diff will be > updated". Maybe I just have to wait... Yes I just had to wait -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 Your

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Federico Cavalieri
Sure, but to me it looks like no change has been made at all (Preview Diff contains only the word Empty) and no "In a few minutes the diff will be updated". Maybe I just have to wait... -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 Your team Zorba Coders is subscri

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-c

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Markos Zaharioudakis
Federico, I forgot to submit some cosmetic changes to this branch before pushing the "approve" button. So, now I have created this new merge proposal. Can you please review? Thanks!. -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 Your team Zorba Coders is subscribed

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Markos Zaharioudakis
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/updrevalidate into lp:zorba. Requested reviews: Federico Cavalieri (fcavalieri) Markos Zaharioudakis (markos-za) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79331 -- https://code.

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/updrevalidate into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79187 -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79187

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Zorba Build Bot
Validation queue job updrevalidate-2011-10-13T16-27-57.947Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorb

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/updrevalidate-2011-10-13T16-27-57.947Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Federico Cavalieri
The proposal to merge lp:~zorba-coders/zorba/updrevalidate into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79187 -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Federico Cavalieri
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-c

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/updrevalidate into lp:zorba

2011-10-13 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/updrevalidate/+merge/79187 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-c