Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2012-01-18 Thread Chris Hillery
Code does not compile. I would fix if this branch was owned by ~zorba-coders, but since it's ~danielturcanu, we'll need Daniel to fix it. [ 13%] Building CXX object src/CMakeFiles/zorba_simplestore.dir/api/xqueryimpl.cpp.o .In file included from ../../src/api/xqueryimpl.cpp:58:

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2012-01-18 Thread Daniel Turcanu
In my debugging I saw that the flwor_expr is outside the udf. So when compiling a udf, probably the optimizer is changing the expression tree in other places as well, probably the caller of the udf, but I cannot say for sure. This woulnd't surprise me, it should be normal for an optimizer. --

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2012-01-18 Thread Daniel Turcanu
Daniel Turcanu has proposed merging lp:~danielturcanu/zorba/plan-serializer into lp:zorba. Requested reviews: Chris Hillery (ceejatec) Markos Zaharioudakis (markos-za) Zorba Coders (zorba-coders) For more details, see:

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2012-01-18 Thread Daniel Turcanu
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Commit Message changed to: Fix in plan serializer about preparing user_functions plan for serialization. For more details, see:

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2012-01-18 Thread Chris Hillery
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/89025 --

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2012-01-18 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/plan-serializer-2012-01-18T16-04-09.348Z/log.html -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/89025 Your team Zorba Coders is requested to review the proposed merge of

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2012-01-18 Thread Zorba Build Bot
The attempt to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:273 (message): Validation queue job plan-serializer-2012-01-18T16-04-09.348Z is finished.

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2012-01-18 Thread Zorba Build Bot
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/89025 --

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2012-01-18 Thread Chris Hillery
zorba_data-converters_module/converters/base64/binaryReadWrite.xq Failed /home/ceej/zo/testing/zorbatest/tester/remotequeue/plan-serializer-2012-01-18T16-04-09.348Z/bzr/zorba/build/src/libzorba_simplestore.so.2.1.0 [0x7fde24a51399]

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2012-01-17 Thread Markos Zaharioudakis
I would like to understand this better. What is the problem that this change fixes? -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/88783 Your team Zorba Coders is requested to review the proposed merge of lp:~danielturcanu/zorba/plan-serializer into lp:zorba. --

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2012-01-17 Thread Daniel Turcanu
The user_functions were compiled during plan serialization, and this modified some expr trees that were already serialized. I had to ensure that all user_functions are compiled before plan serialization is started. -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/88783

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2012-01-17 Thread Daniel Turcanu
For example in one test, in flwor_expr object, theClauses was receiving another flwor_clause in the vector, which made the vector to increase and move to another space. But the initial flwor_clause had already been serialized, and its address was registered for address duplication detection.

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2012-01-16 Thread Daniel Turcanu
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/88783 --

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-29 Thread Daniel Turcanu
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Commit Message changed to: Fixing plan serializer memory leaks For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86959 --

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-29 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/plan-serializer-2011-12-29T08-09-47.208Z/log.html -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86959 Your team Zorba Coders is subscribed to branch lp:zorba. --

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-29 Thread Zorba Build Bot
Validation queue job plan-serializer-2011-12-29T08-09-47.208Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86959 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-29 Thread noreply
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86959 --

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-28 Thread Daniel Turcanu
Review: Approve +one -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86959 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-28 Thread Chris Hillery
FYI, Daniel/Matthias - this proposal will need a commit message in order to get merged... -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86959 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-27 Thread Daniel Turcanu
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86959 --

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-27 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86959 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-23 Thread Daniel Turcanu
Daniel Turcanu has proposed merging lp:~danielturcanu/zorba/plan-serializer into lp:zorba. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86807 Fixed memory leak in serialization of Diagnostic

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-23 Thread Daniel Turcanu
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86807 --

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-23 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/plan-serializer-2011-12-23T14-18-07.233Z/log.html -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86807 Your team Zorba Coders is requested to review the proposed merge of

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-23 Thread Zorba Build Bot
Validation queue job plan-serializer-2011-12-23T14-18-07.233Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86807 Your team Zorba Coders is requested to review the proposed merge of

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-23 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1. Got: 1 Pending. -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86807 Your team Zorba Coders is requested to review the proposed merge of lp:~danielturcanu/zorba/plan-serializer into

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-23 Thread Zorba Build Bot
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86807 --

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-23 Thread Matthias Brantner
Daniel, could you please commit the fix for the plan serializer separately from disabling the module test? Otherwise it will be hard for Chris to find out what you did. -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86807 Your team Zorba Coders is requested to review

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-22 Thread Daniel Turcanu
Daniel Turcanu has proposed merging lp:~danielturcanu/zorba/plan-serializer into lp:zorba. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86714 Fixed plan serialization of udf_function --

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-22 Thread Daniel Turcanu
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86714 --

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-22 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/plan-serializer-2011-12-22T14-45-09.912Z/log.html -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86714 Your team Zorba Coders is requested to review the proposed merge of

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-22 Thread Zorba Build Bot
Validation queue job plan-serializer-2011-12-22T14-45-09.912Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86714 Your team Zorba Coders is requested to review the proposed merge of

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-22 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1. Got: 1 Pending. -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86714 Your team Zorba Coders is requested to review the proposed merge of lp:~danielturcanu/zorba/plan-serializer into

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-22 Thread Zorba Build Bot
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86714 --

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-22 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86714 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-22 Thread Matthias Brantner
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86714 --

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-22 Thread Zorba Build Bot
Validation queue job plan-serializer-2011-12-22T17-05-15.429Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86714 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-22 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1. Got: 1 Approve, 2 Pending. -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86714 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-22 Thread Zorba Build Bot
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86714 --

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-22 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86714 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-22 Thread Markos Zaharioudakis
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86714 --

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-22 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/plan-serializer-2011-12-23T06-19-09.247Z/log.html -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86714 Your team Zorba Coders is subscribed to branch lp:zorba. --

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-22 Thread Zorba Build Bot
Validation queue job plan-serializer-2011-12-23T06-19-09.247Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86714 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-12-22 Thread noreply
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86714 --

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-11-21 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/plan-serializer-2011-11-21T23-20-41.803Z/log.html -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79528 Your team Zorba Coders is subscribed to branch lp:zorba. --

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-11-21 Thread Zorba Build Bot
The attempt to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:272 (message): Validation queue job plan-serializer-2011-11-21T23-20-41.803Z is finished.

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-11-21 Thread Zorba Build Bot
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79528 --

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-11-21 Thread Matthias Brantner
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79528 --

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-11-21 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/plan-serializer-2011-11-22T03-33-01.027Z/log.html -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79528 Your team Zorba Coders is subscribed to branch lp:zorba. --

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-11-21 Thread Zorba Build Bot
Validation queue job plan-serializer-2011-11-22T03-33-01.027Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79528 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-11-21 Thread noreply
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79528 --

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-11-17 Thread Matthias Brantner
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79528 --

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-11-16 Thread David Graf
Review: Approve -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79528 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-11-16 Thread Matthias Brantner
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Commit Message changed to: Fixed bug #872850 about plan serializer crash For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79528 --

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-11-16 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: text conflict in ChangeLog -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79528 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-11-16 Thread Matthias Brantner
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79528 --

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-11-16 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: text conflict in ChangeLog -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79528 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-11-16 Thread Zorba Build Bot
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79528 --

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-11-15 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79528 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-10-18 Thread David Graf
Review: Approve -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79162 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-10-17 Thread Daniel Turcanu
1. What I did was fixing the plan serializer. This means running all the zorba tests and making them work. If it doesn't belong to the tumbling windows, then it's probably another failing test. 2. If that test already exist, I will delete it. --

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-10-17 Thread David Graf
Hey Daniel Ok. Can you just additionally add the test from the diff from my bug report? -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79162 Your team Zorba Coders is requested to review the proposed merge of lp:~danielturcanu/zorba/plan-serializer into lp:zorba. --

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-10-17 Thread Daniel Turcanu
Daniel Turcanu has proposed merging lp:~danielturcanu/zorba/plan-serializer into lp:zorba. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79528 Fixed bug #872850 about plan serializer crash Updated

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-10-17 Thread Daniel Turcanu
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79528 --

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-10-13 Thread David Graf
Hello Daniel Thanks for fixing the issue that fast. Unfortunately, I didn't approve the patch because of two comments I have: 1) Does the fix in src/compiler/expression/expr.cpp belongs do the tumbling window for fix or is this something else? If yes, we need an extra test for this. Or even

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-10-12 Thread Daniel Turcanu
Daniel Turcanu has proposed merging lp:~danielturcanu/zorba/plan-serializer into lp:zorba. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79160 Fixed bug #872850 about plan serializer crash --

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-10-12 Thread Daniel Turcanu
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79160 --

Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-10-12 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: text conflict in ChangeLog -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79160 Your team Zorba Coders is requested to review the proposed merge of lp:~danielturcanu/zorba/plan-serializer into lp:zorba. --

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-10-12 Thread Zorba Build Bot
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79160 --

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-10-12 Thread Daniel Turcanu
Daniel Turcanu has proposed merging lp:~danielturcanu/zorba/plan-serializer into lp:zorba. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79162 Fixed bug #872850 about plan serializer crash --

[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba

2011-10-12 Thread Daniel Turcanu
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/79162 --