[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2013-01-04 Thread Paul J. Lucas
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498 --

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-08-08 Thread Markos Zaharioudakis
Review: Disapprove There are several problems: 1. The new string pool is not thread-safe (the current one is) 2. The check made in ~StringPool() must be implemented in the new pool as well 3. Most of the time, the strings that are inserted in the pool are char * strings (for example, during

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-08-07 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-08-07 Thread Matthias Brantner
Review: Needs Fixing The old string pool should be removed if it's not used anymore (instead of ifdefing it out). -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-08-07 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-08-08T05-22-02.016Z/log.html -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498 Your team Zorba Coders is subscribed to branch lp:zorba.

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-08-07 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Approve, 1 Needs Fixing, 3 Pending. -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498 Your team Zorba Coders is subscribed to branch lp:zorba. --

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-08-07 Thread Zorba Build Bot
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498 --

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-31 Thread Paul J. Lucas
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba. Requested reviews: Paul J. Lucas (paul-lucas) For more details, see: https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498 Added pool class and replaced StringPool. --

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-31 Thread Paul J. Lucas
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498 --

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-31 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-07-31T17-35-59.766Z/log.html -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498 Your team Zorba Coders is subscribed to branch lp:zorba.

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-31 Thread Zorba Build Bot
Validation queue job feature-unordered_map-2012-07-31T17-35-59.766Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-31 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Pending. -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-31 Thread Zorba Build Bot
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498 --

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-12 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-12 Thread Chris Hillery
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328 --

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-12 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-07-13T00-16-08.126Z/log.html -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328 Your team Zorba Coders is subscribed to branch lp:zorba.

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-12 Thread Zorba Build Bot
Validation queue job feature-unordered_map-2012-07-13T00-16-08.126Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-12 Thread noreply
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328 --

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-10 Thread Paul J. Lucas
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba. Requested reviews: Paul J. Lucas (paul-lucas) For more details, see: https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328 Fixed typo. --

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-10 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-09 Thread Paul J. Lucas
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba. Requested reviews: Paul J. Lucas (paul-lucas) For more details, see: https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013 Fixed warnings. --

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-09 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-09 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-09 Thread Paul J. Lucas
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013 --

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-09 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-07-09T17-45-03.094Z/log.html -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013 Your team Zorba Coders is subscribed to branch lp:zorba.

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-09 Thread Paul J. Lucas
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013 --

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Markos Zaharioudakis
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657 --

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-06-28T23-43-07.109Z/log.html -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657 Your team Zorba Coders is subscribed to branch lp:zorba.

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Zorba Build Bot
Validation queue job feature-unordered_map-2012-06-28T23-43-07.109Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread noreply
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657 --

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Paul J. Lucas
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba. Requested reviews: Paul J. Lucas (paul-lucas) For more details, see: https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679 Added the missing specialization for

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Matthias Brantner
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679 --

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-06-29T02-17-56.706Z/log.html -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679 Your team Zorba Coders is subscribed to branch lp:zorba.

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Zorba Build Bot
Validation queue job feature-unordered_map-2012-06-29T02-17-56.706Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Approve, 1 Pending. -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Zorba Build Bot
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679 --

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Matthias Brantner
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679 --

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-06-29T03-29-54.186Z/log.html -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679 Your team Zorba Coders is subscribed to branch lp:zorba.

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Zorba Build Bot
Validation queue job feature-unordered_map-2012-06-29T03-29-54.186Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread noreply
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679 --