[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2013-01-04 Thread Paul J. Lucas
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba 
has been updated.

Status: Needs review = Rejected

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-08-08 Thread Markos Zaharioudakis
Review: Disapprove

There are several problems:

1. The new string pool is not thread-safe (the current one is)

2. The check made in ~StringPool() must be implemented in the new pool as well

3. Most of the time, the strings that are inserted in the pool are char * 
strings (for example, during doc loading, libxml gives chrar* strings to the 
loader). The StringPool::insertc() method is there to optimize this case: it 
will avoid the creation of a zstring (and the resulting string copy) if the 
string is already in the pool, which is the most common case. This optimization 
is lost with the new pool.

4. I think there is a bug in BasicItemFactory::createAnyURI(). The AnyUriItem 
constructor does a destructive assignment (calls take() on the input zstring). 
So, if the expression *theUriPool-insert(value).first returns a reference to 
the zstring that is in the pool, that zstring will be cleared.

I am not against this change in principle, but at the same time I don't 
consider it important enough to spend much time on it. So, I would prefer if 
this is simply dropped.
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-08-07 Thread Paul J. Lucas
Review: Approve


-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-08-07 Thread Matthias Brantner
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba 
has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-08-07 Thread Matthias Brantner
Review: Needs Fixing

The old string pool should be removed if it's not used anymore (instead of 
ifdefing it out).
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-08-07 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-08-08T05-22-02.016Z/log.html
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-08-07 Thread Zorba Build Bot
Validation queue job feature-unordered_map-2012-08-08T05-22-02.016Z is 
finished. The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-08-07 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1. Got: 1 Approve, 1 Needs Fixing, 3 Pending.
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-08-07 Thread Zorba Build Bot
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba 
has been updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-31 Thread Paul J. Lucas
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/feature-unordered_map 
into lp:zorba.

Requested reviews:
  Paul J. Lucas (paul-lucas)

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498

Added pool class and replaced StringPool.
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/store/naive/loader_dtd.cpp'
--- src/store/naive/loader_dtd.cpp	2012-07-24 08:48:48 +
+++ src/store/naive/loader_dtd.cpp	2012-07-31 17:29:20 +
@@ -1305,11 +1305,9 @@
   if (prefix == NULL)
 prefix = ;
 
-  zstring pooledNs;
-  store.getNamespacePool().insertc(nsuri, pooledNs);
 
   bindings[i].first = prefix;
-  bindings[i].second = pooledNs;
+  bindings[i].second = *store.getNamespacePool().insert(nsuri).first;
 
   LOADER_TRACE1(namespace decl: [  prefix   :  nsuri  ]);
   i++;

=== modified file 'src/store/naive/loader_fast.cpp'
--- src/store/naive/loader_fast.cpp	2012-07-24 08:48:48 +
+++ src/store/naive/loader_fast.cpp	2012-07-31 17:29:20 +
@@ -691,11 +691,8 @@
 if (prefix == NULL)
   prefix = ;
 
-zstring pooledNs;
-store.getNamespacePool().insertc(nsuri, pooledNs);
-
 bindings[i].first = prefix;
-bindings[i].second = pooledNs;
+bindings[i].second = *store.getNamespacePool().insert(nsuri).first;
 
 LOADER_TRACE1(namespace decl: [  prefix   :  nsuri  ]);
   }

=== modified file 'src/store/naive/qname_pool.cpp'
--- src/store/naive/qname_pool.cpp	2012-07-24 08:48:48 +
+++ src/store/naive/qname_pool.cpp	2012-07-31 17:29:20 +
@@ -157,8 +157,7 @@
   if (pre == NULL) pre = ;
   ZORBA_FATAL(ln != NULL  *ln != '\0', );
 
-  zstring pooledNs;
-  theNamespacePool-insertc(ns, pooledNs);
+  zstring const pooledNs(*theNamespacePool-insert(ns).first);
 
   ulong hval = hashfun::h32(pre, hashfun::h32(ln, hashfun::h32(ns)));
 
@@ -247,8 +246,7 @@
 
   bool normalized = pre.empty();
 
-  zstring pooledNs;
-  theNamespacePool-insert(ns, pooledNs);
+  zstring const pooledNs(*theNamespacePool-insert(ns).first);
 
   ulong hval = hashfun::h32(pre.c_str(),
 hashfun::h32(ln.c_str(),

=== modified file 'src/store/naive/qname_pool.h'
--- src/store/naive/qname_pool.h	2012-07-24 08:48:48 +
+++ src/store/naive/qname_pool.h	2012-07-31 17:29:20 +
@@ -25,11 +25,10 @@
 #include common/common.h
 
 #include atomic_items.h
+#include string_pool.h
 
 namespace zorba { namespace simplestore {
 
-class StringPool;
-
 /***
 
   theCache   : An array of QName slots that is managed as a cache. This

=== modified file 'src/store/naive/simple_item_factory.cpp'
--- src/store/naive/simple_item_factory.cpp	2012-07-24 08:48:48 +
+++ src/store/naive/simple_item_factory.cpp	2012-07-31 17:29:20 +
@@ -112,9 +112,7 @@
 
 bool BasicItemFactory::createAnyURI(store::Item_t result, const char* value)
 {
-  zstring str;
-  theUriPool-insertc(value, str);
-  result = new AnyUriItem(str);
+  result = new AnyUriItem(*theUriPool-insert(value).first);
   return true;
 }
 

=== modified file 'src/store/naive/simple_item_factory.h'
--- src/store/naive/simple_item_factory.h	2012-07-24 08:48:48 +
+++ src/store/naive/simple_item_factory.h	2012-07-31 17:29:20 +
@@ -26,6 +26,7 @@
 #include zorbatypes/schema_types.h
 
 #include tree_id.h
+#include string_pool.h
 
 namespace zorba
 {
@@ -39,7 +40,6 @@
 namespace simplestore
 {
 
-class StringPool;
 typedef StringPool UriPool;
 class QNamePool;
 class OrdPath;

=== modified file 'src/store/naive/store.cpp'
--- src/store/naive/store.cpp	2012-07-24 08:48:48 +
+++ src/store/naive/store.cpp	2012-07-31 17:29:20 +
@@ -78,7 +78,7 @@
 /***
   Store static data
 /
-const ulong Store::NAMESPACE_POOL_SIZE = 128;
+const ulong Store::NAMESPACE_POOL_SIZE = 127; // really should be prime
 const ulong Store::DEFAULT_DOCUMENT_SET_SIZE = 32;
 const ulong Store::DEFAULT_URI_COLLECTION_SET_SIZE = 32;
 const ulong Store::DEFAULT_INDICES_SET_SIZE = 32;
@@ -147,8 +147,8 @@
 
 theNamespacePool = new StringPool(NAMESPACE_POOL_SIZE);
 
-theNamespacePool-insertc(, theEmptyNs);
-theNamespacePool-insertc(XS_URI, theXmlSchemaNs);
+theEmptyNs = *theNamespacePool-insert().first;
+theXmlSchemaNs = *theNamespacePool-insert(XS_URI).first;
 
 theQNamePool = new QNamePool(QNamePool::MAX_CACHE_SIZE, theNamespacePool);
 

=== modified file 'src/store/naive/store.h'
--- src/store/naive/store.h	2012-07-24 08:48:48 +
+++ src/store/naive/store.h	2012-07-31 17:29:20 +
@@ -35,6 +35,7 @@
 #include store/api/index.h
 #include store/api/ic.h
 #endif
+#include 

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-31 Thread Paul J. Lucas
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba 
has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-31 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-07-31T17-35-59.766Z/log.html
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-31 Thread Zorba Build Bot
Validation queue job feature-unordered_map-2012-07-31T17-35-59.766Z is 
finished. The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-31 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1. Got: 1 Pending.
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-31 Thread Zorba Build Bot
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba 
has been updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-12 Thread Chris Hillery
Review: Approve


-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-12 Thread Chris Hillery
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba 
has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-12 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-07-13T00-16-08.126Z/log.html
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-12 Thread Zorba Build Bot
Validation queue job feature-unordered_map-2012-07-13T00-16-08.126Z is 
finished. The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-12 Thread noreply
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba 
has been updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-10 Thread Paul J. Lucas
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/feature-unordered_map 
into lp:zorba.

Requested reviews:
  Paul J. Lucas (paul-lucas)

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328

Fixed typo.
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/util/unordered_map.h'
--- src/util/unordered_map.h	2012-06-05 14:16:41 +
+++ src/util/unordered_map.h	2012-07-11 04:13:23 +
@@ -46,7 +46,7 @@
  * As such, it lacks member functions that use r-value references.
  *
  * @tparam KeyType They map's key type.
- * @tparam MappedType The type the keys are mapped to.
+ * @tparam ValueType The type the keys are mapped to.
  * @tparam KeyHash The unary_function to use for generating hash codes.
  * @tparam KeyEqual The binary_function to use to test for key equality.
  * @tparam Allocator The allocator to use.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-10 Thread Paul J. Lucas
Review: Approve


-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-09 Thread Paul J. Lucas
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/feature-unordered_map 
into lp:zorba.

Requested reviews:
  Paul J. Lucas (paul-lucas)

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013

Fixed warnings.
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/unit_tests/instantiate_unordered_map.cpp'
--- src/unit_tests/instantiate_unordered_map.cpp	2012-06-26 01:08:10 +
+++ src/unit_tests/instantiate_unordered_map.cpp	2012-07-09 17:31:25 +
@@ -22,6 +22,7 @@
 
 static void instantiate() {
   return;
+  instantiate(); // eliminates defined but not used warning
 
   typedef unordered_mapstring,int map_type;
 

=== modified file 'src/util/hash/hashtable.h'
--- src/util/hash/hashtable.h	2012-06-05 14:16:41 +
+++ src/util/hash/hashtable.h	2012-07-09 17:31:25 +
@@ -609,8 +609,8 @@
   void rehash_impl( size_type new_n_bkt );
 
   node **buckets_;
+  KeyEqual equal_;
   hasher hasher_;
-  KeyEqual equal_;
   KeyExtract key_of;
   size_type n_bkt_;
   size_type n_elt_;

=== modified file 'src/util/hash/hashtable.tcc'
--- src/util/hash/hashtable.tcc	2012-06-05 14:16:41 +
+++ src/util/hash/hashtable.tcc	2012-07-09 17:31:25 +
@@ -84,9 +84,9 @@
 
 ZORBA_HASHTABLE_TEMPLATE
 ZORBA_HASHTABLE_CLASS::hashtable_base( size_type bucket_count,
-  hasher const hash,
-  key_equal const equal,
-  allocator_type const alloc ) :
+   hasher const hash,
+   key_equal const equal,
+   allocator_type const alloc ) :
   equal_( equal ),
   hasher_( hash ),
   n_bkt_( bucket_count ),

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-09 Thread Paul J. Lucas
Review: Approve


-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-09 Thread Matthias Brantner
Review: Approve


-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-09 Thread Paul J. Lucas
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba 
has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-09 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-07-09T17-45-03.094Z/log.html
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-09 Thread Zorba Build Bot
The attempt to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba 
failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 
(message):
  Validation queue job feature-unordered_map-2012-07-09T17-45-03.094Z is
  finished.  The final status was:

  

  2 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-09 Thread Zorba Build Bot
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba 
has been updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-09 Thread Paul J. Lucas
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba 
has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-09 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-07-09T22-27-55.487Z/log.html
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-09 Thread Zorba Build Bot
The attempt to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba 
failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 
(message):
  Validation queue job feature-unordered_map-2012-07-09T22-27-55.487Z is
  finished.  The final status was:

  

  Undetermined, probably an error - please email chill...@lambda.nu with the
  number of this job!


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-09 Thread Zorba Build Bot
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba 
has been updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-09 Thread Paul J. Lucas
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba 
has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-09 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-07-09T23-13-58.367Z/log.html
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-09 Thread Zorba Build Bot
Validation queue job feature-unordered_map-2012-07-09T23-13-58.367Z is 
finished. The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-07-09 Thread noreply
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba 
has been updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Matthias Brantner
Review: Approve


-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Markos Zaharioudakis
Review: Approve


-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Markos Zaharioudakis
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba 
has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-06-28T23-43-07.109Z/log.html
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Zorba Build Bot
Validation queue job feature-unordered_map-2012-06-28T23-43-07.109Z is 
finished. The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread noreply
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba 
has been updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Paul J. Lucas
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/feature-unordered_map 
into lp:zorba.

Requested reviews:
  Paul J. Lucas (paul-lucas)

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679

Added the missing specialization for hashunique_ptrT,D.
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
Your team Zorba Coders is subscribed to branch lp:zorba.
-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Paul J. Lucas
Review: Approve


-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Matthias Brantner
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba 
has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-06-29T02-17-56.706Z/log.html
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Zorba Build Bot
Validation queue job feature-unordered_map-2012-06-29T02-17-56.706Z is 
finished. The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1. Got: 1 Approve, 1 Pending.
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Zorba Build Bot
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba 
has been updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Matthias Brantner
Review: Approve


-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Matthias Brantner
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba 
has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-06-29T03-29-54.186Z/log.html
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread Zorba Build Bot
Validation queue job feature-unordered_map-2012-06-29T03-29-54.186Z is 
finished. The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba

2012-06-28 Thread noreply
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba 
has been updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp