Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread Till Westmann
I've changed the catch(...) in translator.cpp and I've put the correct exception message back into the test. However, I don't see why the exception is reported twice, if the test fails. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge/108894 Your team Zorba Coders is

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread Till Westmann
Till Westmann has proposed merging lp:~zorba-coders/zorba/bug-1009366 into lp:zorba. Requested reviews: Markos Zaharioudakis (markos-za) Chris Hillery (ceejatec) Related bugs: Bug #1009366 in Zorba: access denied error message for module URIs does not contain location information

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge/110410 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-1009366 into lp:zorba has been updated. Commit Message changed to: add location information to ZXQP0029_URI_ACCESS_DENIED For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge/110410 -- https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-1009366 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge/110410 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1009366-2012-06-14T20-56-11.007Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge/110410 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread Zorba Build Bot
Validation queue job bug-1009366-2012-06-14T20-56-11.007Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge/110410 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 2 Approve, 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge/110410 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bug-1009366 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge/110410 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread Chris Hillery
Review: Approve I think I mis-read the diff last time when I mentioned the double output of exceptions (I didn't see it as two separate catch() clauses). Latest changes look fine. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge/110410 Your team Zorba Coders is subscribed

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1009366 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge/110410 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1009366-2012-06-14T23-40-03.247Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge/110410 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread Zorba Build Bot
Validation queue job bug-1009366-2012-06-14T23-40-03.247Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge/110410 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/bug-1009366 into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge/110410 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge/110410

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-09 Thread Chris Hillery
Please add the correct exception message back in test_userdefined_uri_resolvers, so that it is clear when the test passes. Also, as it is, if the test fails you will report the exception twice; that's probably not necessary. Other than that and Markos' comment, looks fine. --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-06 Thread Till Westmann
Till Westmann has proposed merging lp:~zorba-coders/zorba/bug-1009366 into lp:zorba. Requested reviews: Chris Hillery (ceejatec) Markos Zaharioudakis (markos-za) Related bugs: Bug #1009366 in Zorba: access denied error message for module URIs does not contain location information