Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba

2013-04-10 Thread Cezar Andrei
since they are different bugs I would merge this one and keep the bug opened or 
add a new bug for the rest.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1160028-valType/+merge/157193
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba

2013-04-10 Thread Sorin Marian Nasoi
 since they are different bugs I would merge this one and keep the bug opened
 or add a new bug for the rest.
Added lp:1167400 for the 9 remaining failures.

The 4 failures in prod-FunctionCall: FunctionCall-003, FunctionCall-005, 
FunctionCall-007, FunctionCall-008
are fixed: checked in r11361.

-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1160028-valType/+merge/157193
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba

2013-04-10 Thread Sorin Marian Nasoi
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1160028-valType/+merge/157193
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba

2013-04-10 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba 
has been updated.

Commit Message changed to:

Fix for bug1160028. Fix URI of the type when validating with xsi:type attribute 
specified.

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1160028-valType/+merge/157193
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1160028-valType/+merge/157193
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba

2013-04-10 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please 
seek review and approval of these new revisions.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1160028-valType/+merge/157193
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba

2013-04-10 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba 
has been updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1160028-valType/+merge/157193
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1160028-valType/+merge/157193
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba

2013-04-10 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba 
has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1160028-valType/+merge/157193
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1160028-valType/+merge/157193
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba

2013-04-10 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/bug1160028-valType-2013-04-10T15-50-06.234Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1160028-valType/+merge/157193
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba

2013-04-10 Thread Zorba Build Bot
Validation queue job bug1160028-valType-2013-04-10T15-50-06.234Z is finished. 
The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1160028-valType/+merge/157193
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba

2013-04-10 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba 
has been updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1160028-valType/+merge/157193
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1160028-valType/+merge/157193
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba

2013-04-04 Thread Cezar Andrei
Cezar Andrei has proposed merging lp:~zorba-coders/zorba/bug1160028-valType 
into lp:zorba.

Requested reviews:
  Cezar Andrei (cezar-andrei)
  Sorin Marian Nasoi (sorin.marian.nasoi)
Related bugs:
  Bug #1160028 in Zorba: validate type failures (at least 14)
  https://bugs.launchpad.net/zorba/+bug/1160028

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1160028-valType/+merge/157193

Fix for bug1160028. Fix URI of the type when validating with xsi:type attribute 
specified.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1160028-valType/+merge/157193
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/types/schema/SchemaValidatorFilter.cpp'
--- src/types/schema/SchemaValidatorFilter.cpp	2013-02-26 04:12:43 +
+++ src/types/schema/SchemaValidatorFilter.cpp	2013-04-04 18:24:31 +
@@ -1028,7 +1028,9 @@
 {
   const ElemStack::StackElem* topElem = fElemStack.topElement();
   DatatypeValidator *currentDV = 0;
-  if(topElem-fThisElement-isDeclared())
+  if(topElem-fThisElement-isDeclared() ||
+ theXsiType  // this is when there is no schema import but xsiType is used
+)
   {
 ComplexTypeInfo *currentTypeInfo = ((XercSchemaValidator*)fValidator)-getCurrentTypeInfo();
 if(currentTypeInfo)

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba

2013-04-04 Thread Cezar Andrei
Review: Approve

Fix for bug1160028. Fix URI of the type when validating with xsi:type attribute 
specified.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1160028-valType/+merge/157193
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba

2013-04-04 Thread Cezar Andrei
The proposal to merge lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba 
has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1160028-valType/+merge/157193
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1160028-valType/+merge/157193
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1160028-valType into lp:zorba

2013-04-04 Thread Sorin Marian Nasoi
I see that the proposed change fixes only one failure from bug lp:1160028.

If you want I can approbe the change but you have to open a new bug for the 
remaining 13 failures from bug lp:1160028,

The alternative off course if to keep the bind to lp:1160028 and try to fix the 
remaining 13 failures.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1160028-valType/+merge/157193
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp