Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/csv-fixes into lp:zorba

2014-01-16 Thread Paul J. Lucas
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202007
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/csv-fixes into lp:zorba

2014-01-16 Thread Paul J. Lucas
The proposal to merge lp:~zorba-coders/zorba/csv-fixes into lp:zorba has been 
updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202007
-- 
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202007
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/csv-fixes into lp:zorba

2014-01-16 Thread Paul J. Lucas
Paul J. Lucas has proposed merging lp:~zorba-coders/zorba/csv-fixes into 
lp:zorba.

Commit message:
1. Now reporting error location for objects that are not convertible to string.
2. Now checking to ensure field-names is an array.
3. Better error messages.
4. Fixed some comments.

Requested reviews:
  Paul J. Lucas (paul-lucas)

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202007

1. Now reporting error location for objects that are not convertible to string.
2. Now checking to ensure field-names is an array.
3. Better error messages.
4. Fixed some comments.
-- 
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202007
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'NOTICE.txt'
--- NOTICE.txt	2014-01-10 02:36:58 +
+++ NOTICE.txt	2014-01-16 21:49:33 +
@@ -482,7 +482,8 @@
 Copyright: 2000 D. J. Bernstein
 Website: http://cr.yp.to/ftpparse.html
 
-  Commercial use is fine, if you let me know what programs you're using this in.
+  Commercial use is fine, if you let me know what programs you're
+  using this in.
 
 
 External libraries used by this project:

=== modified file 'include/zorba/internal/ztd.h'
--- include/zorba/internal/ztd.h	2013-12-14 00:45:54 +
+++ include/zorba/internal/ztd.h	2014-01-16 21:49:33 +
@@ -92,8 +92,9 @@
   typedef char yes[2];
 
   /**
-   * This dummy class is used to make the matching of the dummy operator()
-   * \e worse than the global \c operator(), if any.
+   * This dummy class is used to make the matching of the dummy
+   * \c operatorlt;lt;() \e worse than the global \c operatorlt;lt;(),
+   * if any.
*/
   struct any_t {
 templatetypename T any_t( T const );
@@ -101,23 +102,24 @@
 
   /**
* This dummy operator is matched only when there is \e no global
-   * operator() otherwise declared for type \c T.
+   * \c operatorlt;lt;() otherwise declared for type \c T.
*
* @return Returns a \c no that selects defined(no).
*/
   no operator( std::ostream const, any_t const );
 
   /**
-   * This function is matched only when there \e is a global \c operator()
-   * declared for type \c T because \c operator()'s return type is
-   * \c std::ostream.
+   * This function is matched only when there \e is a global
+   * \c operatorlt;lt;() declared for type \c T because
+   * \c operatorlt;lt;()'s return type is \c std::ostream.
*
* @return Returns a yes whose \c sizeof() equals \c sizeof(yes).
*/
   yes defined( std::ostream );
 
   /**
-   * This function is matched only when the dummy \c operator() is matched.
+   * This function is matched only when the dummy \c operatorlt;lt;() is
+   * matched.
*
* @return Returns a no whose \c sizeof() equals \c sizeof(no).
*/
@@ -125,8 +127,10 @@
 
   /**
* The implementation class that can be used to determine whether a given
-   * type \c T has a global codestd::ostream operator(std::ostream,T
-   * const)/code defined for it.  However, do not use this class directly.
+   * type \c T has a global
+   * codestd::ostream operatorlt;lt;(std::ostream,T const)/code
+   * defined for it.
+   * However, do not use this class directly.
*
* @tparam T The type to check.
*/
@@ -136,8 +140,8 @@
 static T const t;
   public:
 /**
- * This is \c true only when the type \c T has a global \c operator()
- * declared for it.
+ * This is \c true only when the type \c T has a global
+ * \c operatorlt;lt;() declared for it.
  * \hideinitializer
  */
 static bool const value = sizeof( defined( s  t ) ) == sizeof( yes );
@@ -147,8 +151,8 @@
 /**
  * \internal
  * A class that can be used to determine whether a given type \c T has a global
- * codestd::ostream operator(std::ostream,T const)/code defined for
- * it.
+ * codestd::ostream operatorlt;lt;(std::ostream,T const)/code defined
+ * for it.
  * For example:
  * \code
  * templatetypename T inline

=== modified file 'include/zorba/pregenerated/diagnostic_list.h'
--- include/zorba/pregenerated/diagnostic_list.h	2013-12-18 06:15:17 +
+++ include/zorba/pregenerated/diagnostic_list.h	2014-01-16 21:49:33 +
@@ -1001,6 +1001,8 @@
 
 extern ZORBA_DLL_PUBLIC ZorbaCSVErrorCode INVALID_OPTION;
 
+extern ZORBA_DLL_PUBLIC ZorbaCSVErrorCode INVALID_VALUE;
+
 extern ZORBA_DLL_PUBLIC ZorbaCSVErrorCode MISSING_VALUE;
 
 extern ZORBA_DLL_PUBLIC ZorbaCSVErrorCode EXTRA_VALUE;

=== modified file 'modules/json/json-csv.jq'
--- modules/json/json-csv.jq	2013-09-26 23:15:11 +
+++ modules/json/json-csv.jq	2014-01-16 21:49:33 +
@@ -134,9 +134,13 @@
  :  /dl
  : @return a sequence of zero or more JSON objects where each key is a field
  : name and each value is a parsed value.
- : @error csv:INVALID_OPTION if the codequote-char/code,
- : codequote-escape/code, or codeseparator/code option is given
- : and it's not a single ASCII character.
+ : @error csv:INVALID_OPTION if a value of codefield-names/code is 

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/csv-fixes into lp:zorba

2014-01-16 Thread Zorba Build Bot
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202007

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
-- 
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202007
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/csv-fixes into lp:zorba

2014-01-16 Thread Zorba Build Bot
Voting criteria failed for the following merge proposals:

https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202007 :
Votes: {'Approve': 1, 'Pending': 1}
-- 
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202007
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/csv-fixes into lp:zorba

2014-01-16 Thread Zorba Build Bot
Validation queue result for 
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202007

Stage CommitZorba failed.

Check console output at 
http://jenkins.lambda.nu:8180/job/CommitZorba/273/console to view the results.
-- 
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202007
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/csv-fixes into lp:zorba

2014-01-16 Thread Matthias Brantner
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202007
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/csv-fixes into lp:zorba

2014-01-16 Thread Zorba Build Bot
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202007

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
-- 
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202007
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/csv-fixes into lp:zorba

2014-01-16 Thread Paul J. Lucas
Review: Needs Fixing


-- 
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202007
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/csv-fixes into lp:zorba

2014-01-16 Thread Zorba Build Bot
Voting criteria failed for the following merge proposals:

https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202007 :
Votes: {'Approve': 1, 'Needs Fixing': 1}
-- 
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202007
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/csv-fixes into lp:zorba

2014-01-16 Thread Zorba Build Bot
Validation queue result for 
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202007

Stage CommitZorba failed.

Check console output at 
http://jenkins.lambda.nu:8180/job/CommitZorba/274/console to view the results.
-- 
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202007
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/csv-fixes into lp:zorba

2014-01-16 Thread Paul J. Lucas
The proposal to merge lp:~zorba-coders/zorba/csv-fixes into lp:zorba has been 
updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202019
-- 
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202019
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/csv-fixes into lp:zorba

2014-01-16 Thread Paul J. Lucas
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202019
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/csv-fixes into lp:zorba

2014-01-16 Thread Zorba Build Bot
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202019

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
-- 
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202019
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/csv-fixes into lp:zorba

2014-01-16 Thread Paul J. Lucas
Paul J. Lucas has proposed merging lp:~zorba-coders/zorba/csv-fixes into 
lp:zorba.

Commit message:
1. Now reporting error location for objects that are not convertible to string.
2. Now checking to ensure field-names is an array.
3. Better error messages.
4. Fixed some comments.

Requested reviews:
  Paul J. Lucas (paul-lucas)

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202019

1. Now reporting error location for objects that are not convertible to string.
2. Now checking to ensure field-names is an array.
3. Better error messages.
4. Fixed some comments.
-- 
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202019
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'NOTICE.txt'
--- NOTICE.txt	2014-01-10 02:36:58 +
+++ NOTICE.txt	2014-01-16 23:23:15 +
@@ -482,7 +482,8 @@
 Copyright: 2000 D. J. Bernstein
 Website: http://cr.yp.to/ftpparse.html
 
-  Commercial use is fine, if you let me know what programs you're using this in.
+  Commercial use is fine, if you let me know what programs you're
+  using this in.
 
 
 External libraries used by this project:

=== modified file 'include/zorba/internal/ztd.h'
--- include/zorba/internal/ztd.h	2013-12-14 00:45:54 +
+++ include/zorba/internal/ztd.h	2014-01-16 23:23:15 +
@@ -92,8 +92,9 @@
   typedef char yes[2];
 
   /**
-   * This dummy class is used to make the matching of the dummy operator()
-   * \e worse than the global \c operator(), if any.
+   * This dummy class is used to make the matching of the dummy
+   * \c operatorlt;lt;() \e worse than the global \c operatorlt;lt;(),
+   * if any.
*/
   struct any_t {
 templatetypename T any_t( T const );
@@ -101,23 +102,24 @@
 
   /**
* This dummy operator is matched only when there is \e no global
-   * operator() otherwise declared for type \c T.
+   * \c operatorlt;lt;() otherwise declared for type \c T.
*
* @return Returns a \c no that selects defined(no).
*/
   no operator( std::ostream const, any_t const );
 
   /**
-   * This function is matched only when there \e is a global \c operator()
-   * declared for type \c T because \c operator()'s return type is
-   * \c std::ostream.
+   * This function is matched only when there \e is a global
+   * \c operatorlt;lt;() declared for type \c T because
+   * \c operatorlt;lt;()'s return type is \c std::ostream.
*
* @return Returns a yes whose \c sizeof() equals \c sizeof(yes).
*/
   yes defined( std::ostream );
 
   /**
-   * This function is matched only when the dummy \c operator() is matched.
+   * This function is matched only when the dummy \c operatorlt;lt;() is
+   * matched.
*
* @return Returns a no whose \c sizeof() equals \c sizeof(no).
*/
@@ -125,8 +127,10 @@
 
   /**
* The implementation class that can be used to determine whether a given
-   * type \c T has a global codestd::ostream operator(std::ostream,T
-   * const)/code defined for it.  However, do not use this class directly.
+   * type \c T has a global
+   * codestd::ostream operatorlt;lt;(std::ostream,T const)/code
+   * defined for it.
+   * However, do not use this class directly.
*
* @tparam T The type to check.
*/
@@ -136,8 +140,8 @@
 static T const t;
   public:
 /**
- * This is \c true only when the type \c T has a global \c operator()
- * declared for it.
+ * This is \c true only when the type \c T has a global
+ * \c operatorlt;lt;() declared for it.
  * \hideinitializer
  */
 static bool const value = sizeof( defined( s  t ) ) == sizeof( yes );
@@ -147,8 +151,8 @@
 /**
  * \internal
  * A class that can be used to determine whether a given type \c T has a global
- * codestd::ostream operator(std::ostream,T const)/code defined for
- * it.
+ * codestd::ostream operatorlt;lt;(std::ostream,T const)/code defined
+ * for it.
  * For example:
  * \code
  * templatetypename T inline

=== modified file 'include/zorba/pregenerated/diagnostic_list.h'
--- include/zorba/pregenerated/diagnostic_list.h	2013-12-18 06:15:17 +
+++ include/zorba/pregenerated/diagnostic_list.h	2014-01-16 23:23:15 +
@@ -1001,6 +1001,8 @@
 
 extern ZORBA_DLL_PUBLIC ZorbaCSVErrorCode INVALID_OPTION;
 
+extern ZORBA_DLL_PUBLIC ZorbaCSVErrorCode INVALID_CSV_VALUE;
+
 extern ZORBA_DLL_PUBLIC ZorbaCSVErrorCode MISSING_VALUE;
 
 extern ZORBA_DLL_PUBLIC ZorbaCSVErrorCode EXTRA_VALUE;

=== modified file 'modules/json/json-csv.jq'
--- modules/json/json-csv.jq	2013-09-26 23:15:11 +
+++ modules/json/json-csv.jq	2014-01-16 23:23:15 +
@@ -134,9 +134,14 @@
  :  /dl
  : @return a sequence of zero or more JSON objects where each key is a field
  : name and each value is a parsed value.
- : @error csv:INVALID_OPTION if the codequote-char/code,
- : codequote-escape/code, or codeseparator/code option is given
- : and it's not a single ASCII character.
+ : @error csv:INVALID_OPTION if a value of codefield-names/code 

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/csv-fixes into lp:zorba

2014-01-16 Thread Matthias Brantner
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202019
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/csv-fixes into lp:zorba

2014-01-16 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/csv-fixes into lp:zorba has been 
updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202019
-- 
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202019
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/csv-fixes into lp:zorba

2014-01-16 Thread Zorba Build Bot
Validation queue succeeded - proposal merged!
-- 
https://code.launchpad.net/~zorba-coders/zorba/csv-fixes/+merge/202019
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp