Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-30 Thread Chris Hillery
Review: Approve I still don't love the additional dependency, but I think it probably makes sense not to roll our own UUID libs, so I'll approve this. I wonder if the RQ machine will have it?... -- https://code.launchpad.net/~zorba-coders/zorba/feature-uuid/+merge/118268 Your team Zorba Coders

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-30 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/feature-uuid into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-uuid/+merge/118268 -- https://code.launchpad.net/~zorba-coders/zorba/feature-uuid/+merge

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-30 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/feature-uuid-2012-08-31T01-04-21.504Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/feature-uuid/+merge/118268 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-30 Thread Zorba Build Bot
Validation queue job feature-uuid-2012-08-31T01-04-21.504Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/feature-uuid/+merge/118268 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-30 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/feature-uuid into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-uuid/+merge/118268 -- https://code.launchpad.net/~zorba-coders/zorba/feature-uuid/+merge/118268

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-28 Thread Paul J. Lucas
I added a mention to the build documentation. Approve now? -- https://code.launchpad.net/~zorba-coders/zorba/feature-uuid/+merge/118268 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-21 Thread Matthias Brantner
1. Are the things you compile/link against on Windows and Mac guaranteed to exist? (ie, do I only need to find libuuid on Linux platforms) Yes. 2. What should happen if I *don't* find it? Can the UUID code be made optional at compile time? Would that mean we need a ZORBA_WITH_UUID or

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-21 Thread Chris Hillery
Also, as far as I understood, we already depended on libuuid before. As far as I can tell, no, we didn't. But, if we should have a hard requirement, so be it. As I said, it looks like it's pretty much standard on Linux. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-21 Thread Paul J. Lucas
As far as I can tell, no, we didn't. But, if we should have a hard requirement, so be it. As I said, it looks like it's pretty much standard on Linux. Chris: Can you therefore please add the CMake magic to test for libuuid when not on Mac/Windows? Thanks. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-21 Thread Chris Hillery
Review: Needs Fixing Turns out this is less standard than I thought. On my standard Ubuntu installation, I cannot compile this branch without installing the uuid-dev Ubuntu package, which is where uuid/uuid.h comes from. I have added a bit of CMake stuff to check that -luuid works if

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-15 Thread Paul J. Lucas
My only concern is that for non-Apple, non-Windows platforms, you add -luuid to the link line, but there's no CMake stuff to search for a uuid library or to ensure that such an option will compile/link successfully. Is it a guarantee that it will always be available, at least on Linux? Good

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-15 Thread Chris Hillery
Good catch. I don't suppose you could add the relevant CMake stuff to find libuuid? 1. Are the things you compile/link against on Windows and Mac guaranteed to exist? (ie, do I only need to find libuuid on Linux platforms) 2. What should happen if I *don't* find it? Can the UUID code be made

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-15 Thread Paul J. Lucas
1. Are the things you compile/link against on Windows and Mac guaranteed to exist? (ie, do I only need to find libuuid on Linux platforms) Yes. 2. What should happen if I *don't* find it? Can the UUID code be made optional at compile time? Would that mean we need a ZORBA_WITH_UUID or

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-14 Thread Chris Hillery
Review: Needs Information My only concern is that for non-Apple, non-Windows platforms, you add -luuid to the link line, but there's no CMake stuff to search for a uuid library or to ensure that such an option will compile/link successfully. Is it a guarantee that it will always be available,

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-07 Thread Paul J. Lucas
Actually, I just removed all the problematic code so it should compile on Windows. Please try again. -- https://code.launchpad.net/~zorba-coders/zorba/feature-uuid/+merge/118268 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-07 Thread Rodolfo Ochoa
Review: Approve Yep, that works! -- https://code.launchpad.net/~zorba-coders/zorba/feature-uuid/+merge/118268 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-06 Thread Matthias Brantner
Review: Needs Fixing Doesn't build on 32-bit Ubuntu 11.04 with g++ 4.5.2. [ 68%] Building CXX object src/CMakeFiles/zorba_simplestore.dir/unit_tests/test_uuid.cpp.o In file included from /home/mbrantner/zorba/sandbox/src/unit_tests/test_uuid.cpp:20:0:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-06 Thread Paul J. Lucas
It should be fixed. -- https://code.launchpad.net/~zorba-coders/zorba/feature-uuid/+merge/118268 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-06 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-uuid/+merge/118268 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-06 Thread Rodolfo Ochoa
Review: Needs Fixing From Windows compiling I'm having: Error 88 error C2440: '=' : cannot convert from 'u_long (__stdcall *)(u_long)' to 'uint32_t' C:\dev\feature-uuid\src\runtime\random\random_impl.cpp 141 1 zorba_simplestore Error 89 error C2440: '=' : cannot

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-06 Thread Paul J. Lucas
Rodolfo: I don't understand why there are errors. I actually test compiled this under Windows using Windows 7 and Visual Studio 2010. According to http://msdn.microsoft.com/en-us/library/windows/desktop/ms740075(v=vs.85).aspx, ntohs is declared in Winsock2.h which I include. Any ideas? --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-05 Thread Paul J. Lucas
Paul J. Lucas has proposed merging lp:~zorba-coders/zorba/feature-uuid into lp:zorba. Requested reviews: Rodolfo Ochoa (rodolfo-ochoa) Matthias Brantner (matthias-brantner) Paul J. Lucas (paul-lucas) For more details, see:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-05 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-uuid/+merge/118268 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-05 Thread Paul J. Lucas
Chris: please look at the CMake stuff I changed. Rodolfo: please look at the Windows-specific stuff (including the Windows-specific CMake stuff). -- https://code.launchpad.net/~zorba-coders/zorba/feature-uuid/+merge/118268 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing