Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-18 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-18 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-18 Thread Sorin Marian Nasoi
The proposal to merge lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-18 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job fix_bug_962255-2012-05-18T14-34-05.391Z is finished

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-18 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-18 Thread Sorin Marian Nasoi
The proposal to merge lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-18 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/fix_bug_962255-2012-05-18T15-42-06.591Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-18 Thread Zorba Build Bot
Validation queue job fix_bug_962255-2012-05-18T15-42-06.591Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-18 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-17 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba has been updated. Commit Message changed to: Update modules_svg generation target. Add mechanism for core build to detect whether a given non-core module exists (by URI). Use that method to check for graphviz before

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-17 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba has been updated. Description changed to: For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-17 Thread Chris Hillery
Review: Approve Ok, I have added the changes discussed. xqdoc now depends on modules_svg (Sorin, you had it the other way around, but I think this is what you meant). modules_svg will be a dummy target if the Graphviz modules is not declared. If it is declared, it will generate the .svg file.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-17 Thread Sorin Marian Nasoi
Ok, I have added the changes discussed. xqdoc now depends on modules_svg (Sorin, you had it the other way around, but I think this is what you meant). modules_svg will be a dummy target if the Graphviz modules is not declared. If it is declared, it will generate the .svg file. Nope, the way it

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-17 Thread Sorin Marian Nasoi
Review: Needs Fixing -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-17 Thread Chris Hillery
I'm a bit confused then... I thought the whole point of this exercise was to ensure that the graph was regenerated every time. But with the dependencies the way you say, the modules_svg target will only ever be executed by hand. Am I missing something? --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-16 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-16 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba has been updated. Commit Message changed to: Partial fix for lp:962255. Branch lp:~zorba-coders/zorba/fix_bug_962255_image_module is the other part of the fix. For more details, see: https://code.launchpad.net/~zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-16 Thread Chris Hillery
Is there any difference between the old zorba_module_dependencies.xqi and the new zorba_module_dependencies.xqy ? Why was the filename changed? Besides that, though, as mentioned on the other merge proposal, I don't think you can move the modules_svg target out of the core like this. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-16 Thread Sorin Marian Nasoi
Is there any difference between the old zorba_module_dependencies.xqi and the new zorba_module_dependencies.xqy ? Why was the filename changed? Besides that, though, as mentioned on the other merge proposal, I don't think you can move the modules_svg target out of the core like this. What is

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-16 Thread Sorin Marian Nasoi
Is there any difference between the old zorba_module_dependencies.xqi and the new zorba_module_dependencies.xqy ? Why was the filename changed? The module itself was mostly re-written, but the reason for the extension change is XQDT: xqy is not a default extension for XQuery, while xqi is. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-16 Thread Chris Hillery
Ok, so as discussed, the reason you moved the modules_svg target and associated dependencies was because you could not otherwise know whether Graphviz was available. If so, then please do the following: 1. Change this fix_bug_962255 branch to always create the modules_svg target (as it

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-16 Thread Sorin Marian Nasoi
Is there any difference between the old zorba_module_dependencies.xqi and the new zorba_module_dependencies.xqy ? Why was the filename changed? The module itself was mostly re-written, but the reason for the extension change is XQDT: xqy is not a default extension for XQuery, while xqi is.