[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-04-18 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/fn_envvars-2012-04-18T10-58-20.547Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-04-18 Thread Zorba Build Bot
Validation queue job fn_envvars-2012-04-18T10-58-20.547Z is finished. The final 
status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-04-18 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/fn_envvars into lp:zorba has been 
updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-04-16 Thread Juan Zacarias
The proposal to merge lp:~zorba-coders/zorba/fn_envvars into lp:zorba has been 
updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-04-16 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/fn_envvars-2012-04-16T17-29-09.092Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-04-16 Thread Zorba Build Bot
Validation queue job fn_envvars-2012-04-16T17-29-09.092Z is finished. The final 
status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-04-16 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1. Got: 1 Approve, 1 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-04-16 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/fn_envvars into lp:zorba has been 
updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-04-13 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/fn_envvars into lp:zorba has been 
updated.

Commit Message changed to:

Bug #930157: fn:available-environment-variables Implementation
Bug #930158: fn:environment-variables Implementation
Bug #930160: fn:uri-collection Implementation
Bug #930161: fn:unparsed-text Implementation
Bug #930162: fn:unparsed-text-available Implementation

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101876
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101876
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-04-13 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/fn_envvars into lp:zorba has been 
updated.

Commit Message changed to:

Bug #930157: fn:available-environment-variables Implementation
Bug #930158: fn:environment-variables Implementation
Bug #930160: fn:uri-collection Implementation
Bug #930161: fn:unparsed-text Implementation
Bug #930162: fn:unparsed-text-available Implementation

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101880
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101880
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-04-13 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/fn_envvars into lp:zorba has been 
updated.

Commit Message changed to:

Bug #930157: fn:available-environment-variables Implementation
Bug #930158: fn:environment-variables Implementation
Bug #930160: fn:uri-collection Implementation
Bug #930161: fn:unparsed-text Implementation
Bug #930162: fn:unparsed-text-available Implementation

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-04-13 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/fn_envvars into lp:zorba has been 
updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-04-13 Thread Matthias Brantner
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-04-13 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/fn_envvars-2012-04-13T10-25-07.592Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-04-13 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/fn_envvars into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 
(message):
  Validation queue job fn_envvars-2012-04-13T10-25-07.592Z is finished.  The
  final status was:

  

  4 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-04-13 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/fn_envvars into lp:zorba has been 
updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/101882
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-04-09 Thread Juan Zacarias
all changes done
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-03-29 Thread Chris Hillery
Regarding point 2: Remember that the StreamReleaser and the istream must always 
be kept together as a pair, and the StreamReleaser must be the only way that 
you clean up the istream. Here, you are deleting the istream directly (bad), 
and by setting the StreamReleaser on theStreamResource to nullptr, you're 
breaking up the pair (also bad).

In this case, the StreamResource is already maintaining the pair, and so you 
can actually make your life easier by just maintaining ownership of the 
StreamResource and making sure that IT is deleted when you're done. In that 
case you never have to look at StreamReleaser at all. To do this:

 - In FnUnparsedTextLinesIterator::nextImpl(), change lResource.get() to 
lResource.release(). By doing this, you take ownership of the StreamResource 
(so that the auto_ptr won't delete it).

 - Later in the same function, don't call 
state-theStreamResource-setStreamReleaser(nullptr);.

 - In FnUnparsedTextLinesIteratorState::reset(), just delete theStreamResource, 
and then set theStream  and theStreamResource to 0. Deleting the StreamResource 
will correctly clean up the stream by calling the StreamReleaser.

If I understand Matthias, you will also need to delete theStreamResource in the 
state's destructor, in case of exceptions. (That's why you set 
theStreamResource to 0 in reset(), so you can't accidentally delete it twice.)
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-03-22 Thread Juan Zacarias
Errors are Fixed
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-03-15 Thread Juan Zacarias
 - the unparsed-text-lines function doesn't really stream because it
 materializes all the lines in a vector before returning them. Instead, the
 iterator should keep the istream in it's state and return the lines as they
 are parsed from the stream.
Just one question about this, the Item returned by the function for each line 
should be a Stream then?
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-03-15 Thread Matthias Brantner
  - the unparsed-text-lines function doesn't really stream because it
  materializes all the lines in a vector before returning them. Instead, the
  iterator should keep the istream in it's state and return the lines as they
  are parsed from the stream.
 Just one question about this, the Item returned by the function for each line
 should be a Stream then?
No, I don't think that's necessary. A line should be relatively short. It would 
probably be overhead to stream a single line.
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-03-14 Thread Juan Zacarias
the errors mentioned should be solved now.
let me know if there is any other thing to be changed before merging.
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-03-14 Thread Matthias Brantner
Review: Needs Fixing

- the unparsed-text-lines function doesn't really stream because it 
materializes all the lines in a vector before returning them. Instead, the 
iterator should keep the istream in it's state and return the lines as they are 
parsed from the stream.
- the two readDocument functions share a lot of code which should be factorized
- please add spaces after keywords like if and while to be consistent with the 
other conventions in the sequences_impl.cpp file
- Normilize = Normalize
- wrong comment for the FnUnparsedTextLinesIterator::nextImpl function (14.8.6 
fn:unparsed-text-lines)
- I think the unparsed-text-lines function returns an eventually empty last 
line. However, the spec says that it shouldn't return such an empty string.
- unparsed-text-lines should return the empty sequence if there are no lines in 
the input. However, it seems to raise FOUT1170.
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-02-29 Thread Sorin Marian Nasoi
I ran
ctest -R xquery_3_0
on this branch, and:

- the following functions from FO 3.0 spec are still not implemented:
filter#2 fold-left#3 fold-right#3 function-lookup#2 map#2 map-pairs#3 
parse-xml-fragment#1 unparsed-text-lines#1 unparsed-text-lines#2 has-children#0 
nilled#0 path#0 path#1

- the following functions are in the fn namespace (according to the 
introspection module) and the FO 3.0 spec state that they should not be there:
parse-xml#2 partial-apply#2 partial-apply#3

So it seems that all functions linked to this commit are implemented.
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-02-28 Thread Juan Zacarias
 - It's unclear when the original stream for unparsed-text is released. This
 seems to be a memory leak.
for the original stream of unparsed-text which variable you mean?
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-02-28 Thread Matthias Brantner
  - It's unclear when the original stream for unparsed-text is released. This
  seems to be a memory leak.
 for the original stream of unparsed-text which variable you mean?
Yes, the stream you receive from the StreamResource contains a stream which is 
wrapped into a streamable string. The stream in the streamable string is 
released but the original one isn't. I think you need to remember it in a map 
and release it when the stream you created is released.
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-02-28 Thread Juan Zacarias
   - It's unclear when the original stream for unparsed-text is released.
 This
   seems to be a memory leak.
  for the original stream of unparsed-text which variable you mean?
 Yes, the stream you receive from the StreamResource contains a stream which is
 wrapped into a streamable string. The stream in the streamable string is
 released but the original one isn't. I think you need to remember it in a map
 and release it when the stream you created is released.

One more doubt regarding this, I got a little bit confused while trying to fix 
this, the one you mean is the stream that is inside the StreamResource, is the 
one that needs to be released right? since I had to set the StreamReleaser of 
it to a nullptr
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-02-27 Thread Juan Zacarias
I will make all those changes, Thanks.

and answering your questions

 - you can check using transcode::is_necessary if a encoding is supported
If I am not wrong I am using it that way.

 - What's the default encoding for unparsed-text?
UTF-8

The thing with the encoding is that the encoding is defined in the call of the 
function unparsed-text and unparsed-text-available being initialized with UTF-8 
as a default, should I change the default definition to be inside readDocument 
function so that you don't have to defined in each function?
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-02-27 Thread Matthias Brantner
 I will make all those changes, Thanks.
 
 and answering your questions
 
  - you can check using transcode::is_necessary if a encoding is supported
 If I am not wrong I am using it that way.
My bad, I meant transcode::is_supported should be used.

   - What's the default encoding for unparsed-text?
 UTF-8
OK, got it. It's fine as it is.

-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-02-25 Thread Matthias Brantner
Review: Needs Fixing

- dynamic_context::get_environment_variable(const zstring varname)

should be

dynamic_context::get_environment_variable(const zstring varname)

- spaces before (. for example if (...) instead of if(...)

- all new functions in sequences_impl.cpp are indented with two spaces. the 
other functions are not

- if(result)
{
  STACK_PUSH(true, state);
}
STACK_PUSH(false, state);

could be written as STACK_PUSH(result!=NULL, state);

- In FnEnvironmentVariableIterator::nextImpl, the check  if(consumeNext(item, 
theChildren[0].getp(),planState)) is not necessary. consumeNext always returns 
true because the functions is defined to accept xs:string (not xs:string?)

- item-getString() returns a const zstring. This should be the type of the 
variable.

- store::Item_t item2 is not used in the function

- In FnAvailableEnvironmentVariablesIterator::nextImpl, the line a = 
result-getStringValue().c_str(); and the variable a don't seem to be necessary

- The environment-related functions should be specified using

zorba:methods 
  zorba:accessesDynCtx returnValue=true/
  
/zorba:methods

- All the lines after 14.8.5 fn:unparsed-text  have windows line endings

- you can check using transcode::is_necessary if a encoding is supported

- It's unclear when the original stream for unparsed-text is released. This 
seems to be a memory leak. 

- The unparsed-text related functions should be specified as

zorba:methods 
  zorba:accessesDynCtx returnValue=true/
  
  zorba:isSource returnValue=true/  
  
/zorba:methods

- What's the default encoding for unparsed-text?
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-02-24 Thread Juan Zacarias
 I'm not entirely sure but the diff now only shows whitespace differences in
 generated files. I didn't find any change which adds one of the new functions.

The diff below just show the diff for the errors in which the error codes 
FOUT1170 and FOUT1190 where added the diffs for the implementation should be on
sequence_impl.cpp for unparsed-text(), unparsed-text-available(), 
environment-variable(), available-environments-variables()
and in collections_impl.cpp there is uri-collection()
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-02-23 Thread Juan Zacarias
 Why did you delete NOTICE.txt?
I am not really sure why that happened but it should be there now
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is requested to review the proposed merge of 
lp:~zorba-coders/zorba/fn_envvars into lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fn_envvars into lp:zorba

2012-02-23 Thread Matthias Brantner
Review: Needs Information

I'm not entirely sure but the diff now only shows whitespace differences in 
generated files. I didn't find any change which adds one of the new functions.
-- 
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp