[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2013-01-30 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/fots_driver into lp:zorba has been updated. Commit Message changed to: FOTS test driver changes: 1. Use xqxq:delete-query to release resources, 2. Comments, 3. Cosmetic changes, 4. Small performance improvements For more details, see: https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2013-01-30 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/fots_driver into lp:zorba has been updated. Description changed to: FOTS test driver changes: 1. Use xqxq:delete-query to release resources, 2. Comments, 3. Cosmetic changes, 4. Small performance improvements For more details, see: https

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2013-01-30 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/145128 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2013-01-30 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/fots_driver into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/145128 -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2013-01-30 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/fots_driver-2013-01-30T11-30-30.217Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/145128 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2013-01-30 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/fots_driver into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job fots_driver-2013-01-30T11-30-30.217Z is finished. The final

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2013-01-30 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/fots_driver into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/145128 -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2013-01-30 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/fots_driver into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/145128 -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2013-01-30 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/fots_driver-2013-01-30T13-43-32.011Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/145128 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2013-01-30 Thread Zorba Build Bot
Validation queue job fots_driver-2013-01-30T13-43-32.011Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/145128 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2013-01-30 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/fots_driver into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/145128 -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/145128

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2013-01-22 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/144209 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2013-01-22 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fots_driver into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/144209 -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2013-01-22 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/fots_driver-2013-01-23T00-31-49.728Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/144209 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2013-01-22 Thread Zorba Build Bot
Validation queue job fots_driver-2013-01-23T00-31-49.728Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/144209 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2013-01-22 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/fots_driver into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/144209 -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/144209

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2013-01-21 Thread Markos Zaharioudakis
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/fots_driver into lp:zorba. Commit message: minor improvements + comments + cosmetic changes in fots_driver Requested reviews: Markos Zaharioudakis (markos-za) Related bugs: Bug #918156 in Zorba: fots driver for Zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2013-01-21 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/144209 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-21 Thread Nicolae Brinza
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/133988 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-21 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/133988 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-21 Thread Sorin Marian Nasoi
The proposal to merge lp:~zorba-coders/zorba/fots_driver into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/133988 -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-21 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/fots_driver-2012-11-21T16-16-58.217Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/133988 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-21 Thread Zorba Build Bot
Validation queue job fots_driver-2012-11-21T16-16-58.217Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/133988 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-21 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/fots_driver into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/133988 -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/133988

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-19 Thread Nicolae Brinza
I'm not calling them anything. These are the standard streams http://en.wikipedia.org/wiki/Standard_streams . stderr is used to signal errors. Is it possible to redirect the output of trace() to stdout, or not use trace() at all? --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-19 Thread Sorin Marian Nasoi
I'm not calling them anything. These are the standard streams http://en.wikipedia.org/wiki/Standard_streams . stderr is used to signal errors. Is it possible to redirect the output of trace() to stdout, or not use trace() at all? Waiting for minutes without any information about what the

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-19 Thread Nicolae Brinza
I'm not calling them anything. These are the standard streams http://en.wikipedia.org/wiki/Standard_streams . stderr is used to signal errors. Is it possible to redirect the output of trace() to stdout, or not use trace() at all? Waiting for minutes without any information about what

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-19 Thread Sorin Marian Nasoi
The function env:add-var-decl() does not take type declarations into account (i.e., the as attribute of a param element). I have added the missing information in the driver. However I did not see any improvement in the no. of tests passing: this is caused by the fact that the value of the

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-19 Thread Markos Zaharioudakis
Also, what is the purpose of the (starts-with($param/@select,')) condition in env:add-var-decl-with-value() and env:add-var-decl-without-value()? Usually a select value that starts and ends with ' means a relative URI that the driver needs to resolve against the base URI of the

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-19 Thread Sorin Marian Nasoi
Also, what is the purpose of the (starts-with($param/@select,')) condition in env:add-var-decl-with-value() and env:add-var-decl-without-value()? Usually a select value that starts and ends with ' means a relative URI that the driver needs to resolve against the base URI of the

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-19 Thread Sorin Marian Nasoi
Markos, can I please ask why did you make r11137 as part of the fots-driver branch and not directly into lp:zorba? As far as I see the changes in r11137 deal with XQXQ code. The changes in fots-driver branch deal with adding some modules in test/fots- driver folder so they are not related in

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-18 Thread Markos Zaharioudakis
The function env:add-var-decl() does not take type declarations into account (i.e., the as attribute of a param element). Also, what is the purpose of the (starts-with($param/@select,')) condition in env:add-var-decl-with-value() and env:add-var-decl-without-value()? --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-18 Thread Sorin Marian Nasoi
Why is the ouptut of cli.xq sent to stderr instead of stdout ? There is no stderr/stdout because the driver is not C++. http://my.zorba-xquery.com/dokuwiki/doku.php?id=zorba_fots_driver#usual_cli_output_when_running_test_cases The output CLI is in XML form and is send to the file where the

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-16 Thread Nicolae Brinza
Why is the ouptut of cli.xq sent to stderr instead of stdout ? -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/133988 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-15 Thread Ghislain Fourny
Hi Sorin, That looks very good! I have the feeling the code for eval:assert-any-of could be simplified along the lines of: let $results :=  for $tmp in $expResult/*  return result{    for $r in eval:check-assertion($result,        $tmp,        $code,        $errorDescription,        

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-15 Thread Ghislain Fourny
There are a few occurrences of if ($cond) then () else $result which can probably be simplified along the lines of: $result[$cond] -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/133988 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-15 Thread Ghislain Fourny
Sorry, I meant $result[not($cond)] (depending on whether it's on the then side or on the else side). -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/133988 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-15 Thread Ghislain Fourny
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/133988 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-14 Thread Sorin Marian Nasoi
Fix typo: rezults.xml Use max line length of 80 characters. Remove newline in example: zorba -f -q ... Done in http://bazaar.launchpad.net/~zorba-coders/zorba/fots_driver/revision/11131 -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/133988 Your team Zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-14 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/133988 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-14 Thread Cezar Andrei
Review: Approve One suggestion would be to add one more switch to output a certain test case into a file to be really easy to debug it quickly. -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/133988 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-14 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/133988 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-14 Thread Markos Zaharioudakis
1. It appears that dependencies are checked twice: in driver:run() and driver:test(). Isn't this redundant, or am I missing something?. 2. The parameters $testSetPrefixes and $testCasePrefixes of driver:run() and driver:fots-run() have misleading names. They don't hold prefixes anymore but

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-14 Thread Sorin Marian Nasoi
One suggestion would be to add one more switch to output a certain test case into a file to be really easy to debug it quickly. I added lp:1079006 for this. -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/133988 Your team Zorba Coders is subscribed to branch lp:zorba. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-14 Thread Sorin Marian Nasoi
1. It appears that dependencies are checked twice: in driver:run() and driver:test(). Isn't this redundant, or am I missing something?. It's a feature not a bug :) As stated in the http://my.zorba-xquery.com/dokuwiki/doku.php?id=fots#dependencies A dependency can be set: - either at the test

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-14 Thread Sorin Marian Nasoi
Please replace: Example: there is a HOF dependency added at the test case level and HOF is not supported (*yet* by Zorba) with Example: there is a HOF dependency added at the test SET level and HOF is not supported (*yet* by Zorba) One can not edit a comment once it is in Launchpad... --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-14 Thread Markos Zaharioudakis
2. The parameters $testSetPrefixes and $testCasePrefixes of driver:run() and driver:fots-run() have misleading names. They don't hold prefixes anymore but full test-set and test-case names. Can you rename to just $testSets and $testCases? $testSetPrefixes is a prefix: Did you try

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-14 Thread Markos Zaharioudakis
1. It appears that dependencies are checked twice: in driver:run() and driver:test(). Isn't this redundant, or am I missing something?. It's a feature not a bug :) As stated in the http://my.zorba- xquery.com/dokuwiki/doku.php?id=fots#dependencies A dependency can be set: - either at

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-14 Thread Sorin Marian Nasoi
And there is in fact a bug here: in cli.xq the first call to driver:fots-run() converts the $testSetPrefixes to test-set names by calling d:list-test-sets(). This is correct. But the 2nd call to driver:fots-run() passes $testSetPrefixes directly. This is incorrect. I see what you mean about

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-14 Thread Sorin Marian Nasoi
Assuming the typo correction above, yes it makes sense. But I am not complaining about adding the 3.0 version declaration. I am complaining about the call to check-dependencies at line 437. At line 246 the call to check-dependencies checks the test set dependencies. That is correct IMO. At

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-14 Thread Sorin Marian Nasoi
And there is in fact a bug here: in cli.xq the first call to driver:fots- run() converts the $testSetPrefixes to test-set names by calling d:list-test- sets(). This is correct. But the 2nd call to driver:fots-run() passes $testSetPrefixes directly. This is incorrect. I see what you

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-13 Thread Paul J. Lucas
Review: Needs Fixing Fix typo: rezults.xml Use max line length of 80 characters. Remove newline in example: zorba -f -q ... -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/133988 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-13 Thread Markos Zaharioudakis
Sorin, we to make sure that we don't break the fots driver as we make changes in its code. So before this branch can be merged, the fots driver should be hooked-up with the RQ. -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/133988 Your team Zorba Coders is subscribed

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-13 Thread Sorin Marian Nasoi
Sorin, we to make sure that we don't break the fots driver as we make changes in its code. So before this branch can be merged, the fots driver should be hooked-up with the RQ. +1 @Markos: I first wanted people to take a look at the code, play with it, review it. After I fix the issues they

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-12 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/133988 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots_driver into lp:zorba

2012-11-12 Thread Juan Zacarias
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fots_driver/+merge/133988 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :