Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job jsoniq-roundtrip-2012-09-21T05-41-03.33Z is finished

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-roundtrip-2012-09-21T07-06-03.989Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Zorba Build Bot
Validation queue job jsoniq-roundtrip-2012-09-21T07-06-03.989Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Needs Fixing, 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Chris Hillery
Review: Approve Approve the serialization changes. I skimmed the relevant tests as well. I didn't dive deeply into the implementation of the roundtrip functions. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Matthias Brantner
Review: Needs Fixing - JNTY0023 doesn't exist in the spec - jn:decode-from-roundtrip should return item()*, e.g. it could also return atomics - Probably not related to this proposal but it's strange that the following example doesn't raise a sequence-type matching error (in this branch)

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Till Westmann
- JNTY0023 doesn't exist in the spec I've sent an e-mail to the list to add it to the spec. - jn:decode-from-roundtrip should return item()*, e.g. it could also return atomics - Probably not related to this proposal but it's strange that the following example doesn't raise a sequence-type

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-roundtrip-2012-09-21T18-48-12.23Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Zorba Build Bot
Validation queue job jsoniq-roundtrip-2012-09-21T18-48-12.23Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 2 Approve, 1 Needs Fixing. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-roundtrip-2012-09-21T20-22-01.521Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-20 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-20 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-roundtrip-2012-09-21T03-03-12.864Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-20 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job jsoniq-roundtrip-2012-09-21T03-03-12.864Z is finished

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-20 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-20 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-20 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-roundtrip-2012-09-21T04-13-03.065Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-20 Thread Paul J. Lucas
BTW: Why are the enum types so monstrously long? In this particular case, Zorba_jsoniq_multiple_items_t can be replaced by a bool. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-20 Thread Paul J. Lucas
Review: Needs Fixing s/Cannot/can not/ Please don't use Uppercase as you would a normal sentence. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-20 Thread Zorba Build Bot
Validation queue job jsoniq-roundtrip-2012-09-21T04-13-03.065Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-20 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Needs Fixing, 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-20 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-20 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-20 Thread Till Westmann
s/Cannot/can not/ Please don't use Uppercase as you would a normal sentence. fixed -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-20 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-roundtrip-2012-09-21T05-41-03.33Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-20 Thread Till Westmann
BTW: Why are the enum types so monstrously long? In this particular case, Zorba_jsoniq_multiple_items_t can be replaced by a bool. Not sure. I agree that there are many ways in which this could be done differently. But I would like to keep the diff small so that it is easier to see what was