Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-29 Thread Ghislain Fourny
Thanks Markos, I renamed the functions to attachToCollection/detachFromCollection. Tree IDs are needed in Sausalito, and I thought it would make sense in Zorba too even if it is not used yet. This keeps the diff between Zorba and Sausalito small... --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-29 Thread Ghislain Fourny
The proposal to merge lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-29 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-static-casts-2012-08-29T09-15-57.932Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 Your team Zorba Coders is subscribed to branch lp:zorba. --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-29 Thread Zorba Build Bot
Validation queue job jsoniq-static-casts-2012-08-29T09-15-57.932Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-29 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Approve, 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-29 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-29 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-29 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-29 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-static-casts-2012-08-29T10-14-02.99Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 Your team Zorba Coders is subscribed to branch lp:zorba. --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-29 Thread Zorba Build Bot
Validation queue job jsoniq-static-casts-2012-08-29T10-14-02.99Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-29 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-28 Thread Ghislain Fourny
Thanks Matthias, I missed this one! -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-28 Thread Markos Zaharioudakis
Ghislain, it seems that the jsoniq tree id is not currently used anywhere. Do you envision that it will ever be needed somewhere? If not, let's remove it. Also, I don't like the fix unfix names. What about addInCollection and removeFromCollection? (but this is up to you, I will approve anyway).

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-27 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-27 Thread Matthias Brantner
Review: Approve JSONItem::unfix contains a return statement before an assertion. Not sure if that's on purpose. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-27 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-static-casts-2012-08-27T16-42-57.41Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 Your team Zorba Coders is subscribed to branch lp:zorba. --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-27 Thread Zorba Build Bot
Validation queue job jsoniq-static-casts-2012-08-27T16-42-57.41Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-27 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Approve, 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-27 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-17 Thread Ghislain Fourny
I would say Zorba 2.7. I opened a but and marked it accordingly. The static casts are important as they could cause crashes. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-17 Thread Chris Hillery
If it's done and working, no reason not to merge it immediately. Releases sometimes have to wait for features, but the reverse is not usually true unless the feature includes a backwards-incompatible change. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-09 Thread Ghislain Fourny
Ghislain Fourny has proposed merging lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba. Requested reviews: Markos Zaharioudakis (markos-za) Matthias Brantner (matthias-brantner) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-09 Thread Ghislain Fourny
The proposal to merge lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-09 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-static-casts-2012-08-09T13-50-04.515Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 Your team Zorba Coders is subscribed to branch lp:zorba. --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-09 Thread Zorba Build Bot
Validation queue job jsoniq-static-casts-2012-08-09T13-50-04.515Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-09 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 3 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-09 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-09 Thread Markos Zaharioudakis
Ghislain, has this been scheduled for a release? If so, which one? -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :