Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba

2012-03-28 Thread Cezar Andrei
Review: Approve After a closer look the bugs are fixed and all the new testcase check for specific errors. Indeed the message can be misleading in the case of bug #912722 but not totaly incorect (depending on the implented algorithm) and the error code is correct. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba

2012-03-28 Thread Cezar Andrei
Review: Approve Fixed conflict and merged latest from trunk. -- https://code.launchpad.net/~zorba-coders/zorba/bugs-912586-912593-912722/+merge/99767 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba

2012-03-28 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bugs-912586-912593-912722/+merge/99767 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba

2012-03-28 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~zorba-coders/zorba/bugs-912586-912593-912722/+merge/99767 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba

2012-01-24 Thread Federico Cavalieri
I transferred the bugs to Cezar, thanks. They are blocking the merge of the PUL production/application. When those are fixed I think there will be another very small issue to cope with validation, which occur when I try to validate an element against a specific type definition. However, maybe

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba

2012-01-24 Thread Cezar Andrei
I'm not sure, if I figure the right Xerces Error code for it should be easy but prom past this was quite tricky. Cezar On Tue, Jan 24, 2012 at 8:04 AM, Federico Cavalieri fcavalier...@gmail.comwrote: I transferred the bugs to Cezar, thanks. They are blocking the merge of the PUL

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba

2012-01-23 Thread Markos Zaharioudakis
Markos is correct, if a/ element is inside root element than, root has a complex type and is not a simple type which anysimpleType represents. This should make the validation failing in the example from bug #912722 even if lax is specified. So this doesn't fix the bug #912722, at least the

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba

2012-01-20 Thread Markos Zaharioudakis
Federico, I am approving this, but my knowledge of XML Schema and Zorba's implementation of it is not good enough to do a real review. So, I am also adding Cezar as a reviewer. For example, after your fix, the query in bug #912722 complains that no declaration found for element 'a'. But, I

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba

2012-01-20 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bugs-912586-912593-912722/+merge/87749 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba

2012-01-20 Thread Cezar Andrei
Review: Needs Fixing Markos is correct, if a/ element is inside root element than, root has a complex type and is not a simple type which anysimpleType represents. This should make the validation failing in the example from bug #912722 even if lax is specified. So this doesn't fix the bug