Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
Review: Disapprove There are several problems: 1. The new string pool is not thread-safe (the current one is) 2. The check made in ~StringPool() must be implemented in the new pool as well 3. Most of the time, the strings that are inserted in the pool are "char *" strings (for example, during doc loading, libxml gives chrar* strings to the loader). The StringPool::insertc() method is there to optimize this case: it will avoid the creation of a zstring (and the resulting string copy) if the string is already in the pool, which is the most common case. This optimization is lost with the new pool. 4. I think there is a bug in BasicItemFactory::createAnyURI(). The AnyUriItem constructor does a destructive assignment (calls take() on the input zstring). So, if the expression *theUriPool->insert(value).first returns a reference to the zstring that is in the pool, that zstring will be cleared. I am not against this change in principle, but at the same time I don't consider it important enough to spend much time on it. So, I would prefer if this is simply dropped. -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 1 Approve, 1 Needs Fixing, 3 Pending. -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
Review: Needs Fixing The old string pool should be removed if it's not used anymore (instead of ifdefing it out). -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 1 Pending. -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
The attempt to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job feature-unordered_map-2012-07-09T22-27-55.487Z is finished. The final status was: Undetermined, probably an error - please email chill...@lambda.nu with the number of this job! Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
The attempt to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job feature-unordered_map-2012-07-09T17-45-03.094Z is finished. The final status was: 2 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 1 Approve, 1 Pending. -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
