Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210677-autoptr into lp:zorba

2013-09-17 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210677-autoptr into lp:zorba

2013-09-17 Thread Chris Hillery
Well, crap. Didn't see that with all the other changes. Now what... -- https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210677-autoptr into lp:zorba

2013-09-17 Thread Paul J. Lucas
Review: Needs Fixing This MP is touching .csv files. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210677-autoptr into lp:zorba

2013-09-16 Thread Paul J. Lucas
Review: Needs Fixing There don't seem to be enough #include zorba/internal/unique_ptr.h in the .cpp files, e.g., src/util/singleton.h. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210677-autoptr into lp:zorba

2013-09-10 Thread Chris Hillery
Changes made as suggested. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210677-autoptr into lp:zorba

2013-08-30 Thread Paul J. Lucas
Review: Approve Approving, but you might want to fix the following: * s/an unique_ptr/a unique_ptr/ * There are places where a unique_ptr variable is explicitly initialized with NULL. This is unnecessary. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455 Your

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1210677-autoptr into lp:zorba

2013-08-15 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :