Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Well, crap. Didn't see that with all the other changes. Now what...
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Review: Needs Fixing
This MP is touching .csv files.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Review: Needs Fixing
There don't seem to be enough #include zorba/internal/unique_ptr.h in the
.cpp files, e.g., src/util/singleton.h.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Changes made as suggested.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
Approving, but you might want to fix the following:
* s/an unique_ptr/a unique_ptr/
* There are places where a unique_ptr variable is explicitly initialized with
NULL. This is unnecessary.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Your
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
7 matches
Mail list logo