Using the usual exit codes convention, as per our todays' talk.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
The attempt to merge lp:~zorba-coders/zorba/bug1086323-processExitCode into
lp:zorba/process-module failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job
Review: Needs Fixing
The module comments still list the -2000 / -1000 return value numbers.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list:
Paul (not sure if you were on the conf call today) : we decided that we should
fix just this problem in the process module for now, to allow it to
consistently report exit status across Linux distributions and hopefully MacOS.
As for the other issues you and I raised, I will file new bugs which
It would be great if you could test this on MacOS, and vote Approve if there
are no other issues.
I could test it if there were a test I could run.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
Your team Zorba Coders is subscribed to branch
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Needs Fixing, 2 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
Your team Zorba Coders is subscribed to branch
Review: Approve
I have checked on Fedora and these are the returned codes:
- if a test ends in a SEG FAULT = exit-code = 139
- if a test reaches an ASSERT = exit code = 134
So I approve this proposal but at least someone on Ubuntu (ideally also on
MacOS) should confirm that they get the same
Fixed xqdoc.
Also I tested it on Ubuntu, segfault comes with exit code 139.
To test it one needs to call process:exec on a program that ends with a
segmentation fault.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
Your team Zorba Coders is
Review: Approve
Verified (with Sorin's repro script in email) that this works on Ubuntu.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list:
On Mac OS X 10.8.2, it prints:
139 0
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Review: Approve
After discussion with Chris, I'm approving this despite it not working on Mac
OS X since the short-term goal is to have this working on Linux where having it
working on Mac OS X is a nice-to-have.
The test that was supposed to SEGFAULT did; the test that was supposed to have
Follow-up: after running a new query to call a C program:
#include stdlib.h
int main() {
abort();
}
it prints 134. Hence, the process-module fix works but the HOF code behaves
differently on Mac OS X.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/138266
Review: Needs Fixing
1. Why return made-up numbers, e.g., -1000, etc? Why not simply return the
actual exit status? Of course this implies that you'd have to implement XQuery
functions that do the equivalent of the W* macros. Either that, or return XML
data, e.g.:
process id=1234
The attempt to merge lp:~zorba-coders/zorba/bug1086323-processExitCode into
lp:zorba/process-module failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job
I assume using made-up exit codes was so the new information could fit into the
existing result schema, for backwards compatibility. Still, I think it probably
would be better to improve the schema and bump the module version number. If
there is any way for the results to be the same on posix
Interesting Ubuntu and Fedora don't implement this the same way.
On Ubuntu running a bash script or the process xq script which calls a program
that segFaults, the exit code is 139. The macro WIFEXITED(stat) returns true
and WEXITSTATUS(stat) returns 139. Which btw means acording to the link
it's executing a shell with the commands, this way one can have access to shell
commands.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1086323-processExitCode/+merge/137966
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list:
It's my opinion that that is not a valuable feature, and the downsides outweigh
its usefulness. Also, users can do this themselves if they require it by
executing a shell or cmd. We should not do it for them, or at the very least
this should not be the default.
--
18 matches
Mail list logo
