Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/destroy-annotation-qnames into lp:zorba

2012-04-16 Thread Zorba Build Bot 
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1. Got: 1 Approve, 2 Needs Fixing.
-- 
https://code.launchpad.net/~zorba-coders/zorba/destroy-annotation-qnames/+merge/97824
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/destroy-annotation-qnames into lp:zorba

2012-04-16 Thread Markos Zaharioudakis 
Review: Approve

I made a fix to take into account synchronization in clear() method
-- 
https://code.launchpad.net/~zorba-coders/zorba/destroy-annotation-qnames/+merge/97824
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/destroy-annotation-qnames into lp:zorba

2012-04-13 Thread Ghislain Fourny 
Yes indeed, it should actually completely solve the memory leak that way.
-- 
https://code.launchpad.net/~zorba-coders/zorba/destroy-annotation-qnames/+merge/97824
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/destroy-annotation-qnames into lp:zorba

2012-04-10 Thread Markos Zaharioudakis 
Review: Needs Fixing

I think a better solution is to redefine the clear method for the 
ItemHandleHashMap class.
-- 
https://code.launchpad.net/~zorba-coders/zorba/destroy-annotation-qnames/+merge/97824
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/destroy-annotation-qnames into lp:zorba

2012-03-16 Thread Zorba Build Bot 
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1. Got: 3 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/destroy-annotation-qnames/+merge/97824
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/destroy-annotation-qnames into lp:zorba

2012-03-16 Thread Matthias Brantner 
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/destroy-annotation-qnames/+merge/97824
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp