Thanks Markos, I renamed the functions to
attachToCollection/detachFromCollection. Tree IDs are needed in Sausalito, and
I thought it would make sense in Zorba too even if it is not used yet. This
keeps the diff between Zorba and Sausalito small...
--
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Approve, 2 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Thanks Matthias, I missed this one!
--
https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Ghislain, it seems that the jsoniq tree id is not currently used anywhere. Do
you envision that it will ever be needed somewhere? If not, let's remove it.
Also, I don't like the fix unfix names. What about addInCollection and
removeFromCollection? (but this is up to you, I will approve anyway).
Review: Approve
JSONItem::unfix contains a return statement before an assertion. Not sure if
that's on purpose.
--
https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Approve, 2 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
I would say Zorba 2.7. I opened a but and marked it accordingly.
The static casts are important as they could cause crashes.
--
https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
If it's done and working, no reason not to merge it immediately. Releases
sometimes have to wait for features, but the reverse is not usually true unless
the feature includes a backwards-incompatible change.
--
https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 3 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Ghislain, has this been scheduled for a release? If so, which one?
--
https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
11 matches
Mail list logo