Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uri_module into lp:zorba

2012-03-05 Thread Matthias Brantner
- fixed the parameter for the transcoding stream
- changed the code such that plus-decoding is done before percent-decoding as 
stated in the docs
- added a note about the assumptions on the input to be ascii-only
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-uri_module/+merge/96005
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uri_module into lp:zorba

2012-03-05 Thread Chris Hillery
Review: Approve

Typo: characeters in the doc of all three uri.xq functions. Other than that, 
changes look good. I'll approve now so you can merge after correcting the typo.
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-uri_module/+merge/96005
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uri_module into lp:zorba

2012-03-05 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please 
seek review and approval of these new revisions.
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-uri_module/+merge/96005
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uri_module into lp:zorba

2012-03-05 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/feature-uri_module into lp:zorba 
failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 
(message):
  Validation queue job feature-uri_module-2012-03-05T23-11-19.724Z is
  finished.  The final status was:

  

  2 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-uri_module/+merge/96005
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uri_module into lp:zorba

2012-03-05 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/feature-uri_module into lp:zorba 
failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 
(message):
  Validation queue job feature-uri_module-2012-03-06T00-39-09.268Z is
  finished.  The final status was:

  

  2 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-uri_module/+merge/96005
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uri_module into lp:zorba

2012-03-05 Thread Chris Hillery
The downside of building this functionality into Zorba: In release mode, the 
.xq file isn't read, so the implemented-in-XQuery functions don't exist. I 
don't remember the right solution, though.
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-uri_module/+merge/96005
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uri_module into lp:zorba

2012-02-23 Thread Matthias Brantner
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-uri_module/+merge/94492
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uri_module into lp:zorba

2012-02-23 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/feature-uri_module into lp:zorba 
failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 
(message):
  Validation queue job feature-uri_module-2012-02-24T03-31-06.652Z is
  finished.  The final status was:

  

  2 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-uri_module/+merge/94492
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp