Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-18 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: 

text conflict in cmake_modules/ZorbaModule.cmake
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/102377
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-18 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/module-schema-tools into lp:zorba 
failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 
(message):
  Validation queue job module-schema-tools-2012-04-18T07-13-04.737Z is
  finished.  The final status was:

  

  1 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/102377
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-18 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/module-schema-tools into lp:zorba 
failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 
(message):
  Validation queue job module-schema-tools-2012-04-18T08-39-07.752Z is
  finished.  The final status was:

  

  3 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/102377
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-18 Thread Matthias Brantner
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/102377
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-18 Thread Chris Hillery
Review: Approve

Think I finally got the dependency tracking working. It's ugly but at least 
works.
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/102377
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-18 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: 

contents conflict in NOTICE.txt
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/102377
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-18 Thread Chris Hillery
Hooray!
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/102377
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-17 Thread Cezar Andrei
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/102001
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-17 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/module-schema-tools into lp:zorba 
failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 
(message):
  Validation queue job module-schema-tools-2012-04-17T15-15-59.439Z is
  finished.  The final status was:

  

  No tests were run - build or configure step must have failed.

  Not commiting changes.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/102001
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-17 Thread Cezar Andrei
Chris, can you check the cmake build dependencies for util-jvm module. I see 
the same error on my box when I use make -j12.

[ 95%] Built target modlib69_xqxq.xq
[ 95%] Built target modlib56_hmac.xq
Scanning dependencies of target modlib70_util-jvm.xq
[ 95%] Scanning dependencies of target modlib71_schema-tools.xq
.Building CXX object 
zorba_modules/zorba_util-jvm_module/src/CMakeFiles/modlib70_util-jvm.xq.dir/util-jvm.xq.src/util-jvm.cpp.o
make[2]: *** No rule to make target 
`LIB_PATH/com/zorba-xquery/www/modules/libutil-jvm_1.0.so', needed by 
`LIB_PATH/com/zorba-xquery/www/modules/libschema-tools_1.0.so'.  Stop.
make[2]: *** Waiting for unfinished jobs
[ 95%] Building CXX object 
zorba_modules/zorba_schema-tools_module/src/CMakeFiles/modlib71_schema-tools.xq.dir/schema-tools.xq.src/schema-tools.cpp.o
[ 95%] Building CXX object 
zorba_modules/zorba_util-jvm_module/src/CMakeFiles/modlib70_util-jvm.xq.dir/util-jvm.xq.src/JavaVMSingleton.cpp.o
Linking CXX shared library 
../../../LIB_PATH/com/zorba-xquery/www/modules/libutil-jvm_1.0.so
make[1]: *** 
[zorba_modules/zorba_schema-tools_module/src/CMakeFiles/modlib71_schema-tools.xq.dir/all]
 Error 2
make[1]: *** Waiting for unfinished jobs
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/102001
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-17 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please 
seek review and approval of these new revisions.
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/102001
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-17 Thread Cezar Andrei
Review: Approve

Fixed erroneous merging of swig files.
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/102377
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-17 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/module-schema-tools into lp:zorba 
failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 
(message):
  Validation queue job module-schema-tools-2012-04-17T19-20-05.192Z is
  finished.  The final status was:

  

  1 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/102377
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-15 Thread Matthias Brantner
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/102001
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-14 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: 

text conflict in ChangeLog
text conflict in src/api/staticcontextimpl.h
text conflict in src/precompiled/stdafx.h
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/101796
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-14 Thread Chris Hillery
Review: Approve

I merged from the trunk, but I wasn't totally sure that I did the right thing 
with stdafx.h. So I re-submitted the proposal so Matthias and Cezar could have 
a chance to re-review.

As far as I can tell, stdafx.h was never explicitly changed on the 
module-schema-tools branch; the only commits which affected it were merges from 
the trunk. So I don't know why there were merge conflicts now. But I just made 
it identical to the current trunk. If that's OK, then you two should go ahead 
and re-approve.
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/102001
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-14 Thread Chris Hillery
There is a feature in CMake that DECLARE_ZORBA_JAR(..TARGET..) depends on 
which, it turns out, was only implemented correctly as of CMake 2.8.4. (See 
http://public.kitware.com/Bug/view.php?id=11332 .) The remote queue was running 
CMake 2.8.2, which is why the build failed.

I have upgraded the queue to run CMake 2.8.7, so hopefully it'll work this time.

I note that there doesn't appear to be any documentation for this new Java 
stuff as yet, but wherever it ends up, it should be noted that CMake = 2.8.4 
is required.
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/102001
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-14 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/module-schema-tools into lp:zorba 
failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 
(message):
  Validation queue job module-schema-tools-2012-04-14T08-25-03.504Z is
  finished.  The final status was:

  

  No tests were run - build or configure step must have failed.

  Not commiting changes.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/102001
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-14 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/module-schema-tools into lp:zorba 
failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 
(message):
  Validation queue job module-schema-tools-2012-04-14T08-42-58.716Z is
  finished.  The final status was:

  

  No tests were run - build or configure step must have failed.

  Not commiting changes.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/102001
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-14 Thread Chris Hillery
Grumble. Sometimes I hate CMake. This stuff works just fine on my machine, but 
for whatever reason the dependencies just aren't working out right on the 
remote queue machine. I've spent the last hour trying to make it work right and 
have so far failed. I'll have to take another crack at it either over the 
weekend or on Monday; sorry.

By the by, if I manually run make again, it gets past this point. However, 
then it gets a bunch of SWIG errors:


In file included from 
/home/ceej/zo/testing/zorbatest/tester/remotequeue/module-schema-tools-2012-04-14T08-42-58.716Z/bzr/zorba/build/swig/python/zorba_apiPYTHON_wrap.cxx:3478:
/home/ceej/zo/testing/zorbatest/tester/remotequeue/module-schema-tools-2012-04-14T08-42-58.716Z/bzr/zorba/build/swig/python/StaticContext.h:115:
 error: ‘TypeIdentifier’ does not name a type
/home/ceej/zo/testing/zorbatest/tester/remotequeue/module-schema-tools-2012-04-14T08-42-58.716Z/bzr/zorba/build/swig/python/StaticContext.h:116:
 error: ‘TypeIdentifier’ does not name a type
/home/ceej/zo/testing/zorbatest/tester/remotequeue/module-schema-tools-2012-04-14T08-42-58.716Z/bzr/zorba/build/swig/python/StaticContext.h:117:
 error: ‘TypeIdentifier’ does not name a type
/home/ceej/zo/testing/zorbatest/tester/remotequeue/module-schema-tools-2012-04-14T08-42-58.716Z/bzr/zorba/build/swig/python/StaticContext.h:119:
 error: expected ‘,’ or ‘...’ before ‘’ token
/home/ceej/zo/testing/zorbatest/tester/remotequeue/module-schema-tools-2012-04-14T08-42-58.716Z/bzr/zorba/build/swig/python/StaticContext.h:119:
 error: ISO C++ forbids declaration of ‘TypeIdentifier’ with no type

and a bunch more like that. That doesn't have anything to do with my CMake 
changes, and will have to be solved as well. Any ideas?
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/102001
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-14 Thread Cezar Andrei
Unless when you updated cmake you updated swig too, no other idea comes to mind.

I have cmake 2.8.5 and swig 1.3.40 on my box and works fine.
 
 That doesn't have anything to do with my CMake
 changes, and will have to be solved as well. Any ideas?
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/102001
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-13 Thread Matthias Brantner
Review: Needs Information

Should the classpath in the static context be serialized? I forgot our 
decision, is this member needed at all?
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/101796
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-13 Thread Chris Hillery
It looks like the classpath in static_context is orphaned; nothing sets it or 
references it. I'll take that out.
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/101796
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-13 Thread Chris Hillery
Removed. Matthias, if that was your only comment, go ahead and vote Approve.
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/101796
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-13 Thread Matthias Brantner
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/101796
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-13 Thread Chris Hillery
I'll need Cezar to set the commit message; I'm not sure if he just copied
the Description or not. Unfortunately if you go back to the previous
revision of the Proposal it doesn't show the commit message from that
version...

-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/101796
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-13 Thread Cezar Andrei
I've set the commit message, but build is not triggered, do I need to resubmit 
the proposal?
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/101796
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-13 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please 
seek review and approval of these new revisions.
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/101796
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-12 Thread Cezar Andrei
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/101796
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-12 Thread Chris Hillery
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/101796
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-11 Thread Cezar Andrei
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/101639
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-04-11 Thread Chris Hillery
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/101639
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-03-20 Thread Cezar Andrei
Removed IStream swig class and references.
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/98485
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-03-20 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1. Got: 3 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/98485
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-03-19 Thread Chris Hillery
 If you take a look at the file there are many places where this strange
 indentation occurs. Check out the top of the file: THIS IS A GENERATED FILE.
 DO NOT EDIT!

My understanding is that this isn't true anymore, though. Markos removed the 
script to generate this file, and said that in future changes should be made 
directly to it. If that's correct, clearly he should have removed the above 
comment as well.

Did you run a script to generate these files, Cezar? If so, that would explain 
Matthias's problem as well (about changes to the property descriptions that 
seem to have been reverted by you).
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/97978
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-03-19 Thread Cezar Andrei
I didn't know Markos removed the scripts after I made the changes. But I 
removed the comment and I fixed the indentation of init_val lines.

I also fixed the ExternalModules.config wrong merge, and checked 
src/system/zorba_properties.h contains changes only related to CLASSPATH and 
indentation.
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/98224
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-03-19 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1. Got: 3 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/98224
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-03-17 Thread Cezar Andrei
 It looks like you didn't fix the indentation of calls to init_val() in
 zorbacmdproperties_base.h, and in fact it looks like you moved a number of
 other instances of calls to that method onto the ends of earlier lines of code
 in zorba_properties.h. It's just not good readability. To be clear, I'm
 talking about lines like this:
 
if (*argv == NULL) { result = No value given for --classpath option;
 break; }init_val (*argv, theClasspath, d);
 
 There's no reason to have that call to init_val() hanging out over there. I
 count 9 places where this is done, most of which were put that way with this
 change.

If you take a look at the file there are many places where this strange 
indentation occurs. Check out the top of the file: THIS IS A GENERATED FILE. DO 
NOT EDIT!

 
 
 You also didn't rename the class IStream. Rodolfo reported that that class
 name conflicted with a Windows class, making the code not compile on Windows.
 It's not clear to me if this is one of the changes for optimizing XQJ you
 mentioned, but if it actually causes a compilation failure it must be changed.

Rodolfo, checked out the full build and tests on windows, there is no problem 
with it. I sent an email to clarify it.
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/97978
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-03-16 Thread Cezar Andrei
I fixed all of the comments, execept:
- the ones related to swig:
- the changes are not required, right now but they required for optimizing 
XQJ, to make swig play nice with streams it's quite a chlange, would be a petty 
to loose them
- I don't think various.i should be specified in NOTICE.xml since we 
already have swig and various.i is part of swig.
- about Properties it's not really the most intuitive way of representing it 
but I do think PropertiesGlobal is a good name, many projects use kind after 
the base to explain what it is. I call Properties::instance() because that is 
the private instantiable implementation class that extends ZorbaProperties 
which is based on PropertiesGlobal.
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/97105
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-03-16 Thread Cezar Andrei
See my prevoius comment for fixes in this proposal.
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/97976
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-03-16 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1. Got: 3 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/97976
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-03-16 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please 
seek review and approval of these new revisions.
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/97978
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-03-16 Thread Matthias Brantner
Review: Needs Fixing

- I think you reverted the changes that have been made in 
modules/ExternalModules.conf.
- The file src/system/zorba_properties.h also contains changes that have been 
reverted. For example,

1058---no-copy-optim\napply the no-copy optimization (1=enabled (default), 
0=off)\n\n
1059---serialize-only-query\nserialize-only-query (0=unknown (default), 
1=enabled, 0=off)\n\n
1060+--no-copy-optim\nno copy optim (1=enabled (default), 0=off)\n\n
1061+--serialize-only-query\nserialize-only query (1=true, 0=false 
(default))\n\n
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/97978
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-03-16 Thread Chris Hillery
Review: Needs Fixing

It looks like you didn't fix the indentation of calls to init_val() in 
zorbacmdproperties_base.h, and in fact it looks like you moved a number of 
other instances of calls to that method onto the ends of earlier lines of code 
in zorba_properties.h. It's just not good readability. To be clear, I'm talking 
about lines like this:

   if (*argv == NULL) { result = No value given for --classpath option; 
break; }init_val (*argv, theClasspath, d);

There's no reason to have that call to init_val() hanging out over there. I 
count 9 places where this is done, most of which were put that way with this 
change.


You also didn't rename the class IStream. Rodolfo reported that that class 
name conflicted with a Windows class, making the code not compile on Windows. 
It's not clear to me if this is one of the changes for optimizing XQJ you 
mentioned, but if it actually causes a compilation failure it must be changed.
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/97978
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-03-14 Thread Matthias Brantner
Review: Needs Fixing

- In DynamicLoader::loadModule the code to create the Module is redundant and 
should be factorized
- Why is DECLARE_ZORBA_JAR in cmake_modules/ZorbaModule.cmake commented out? 
Should it be removed?
- Why did the file src/store/naive/store_properties.h change? I think Markos 
has disabled the generation in the trunk. We have to be careful that nothing is 
removed by this merge (same for all properties).
  For example,
88  ---no-copy-optim\napply the no-copy optimization (1=enabled (default), 
0=off)\n\n
1089---serialize-only-query\nserialize-only-query (0=unknown (default), 
1=enabled, 0=off)\n\n
1090+--no-copy-optim\nno copy optim (1=enabled (default), 0=off)\n\n
1091+--serialize-only-query\nserialize-only query (1=true, 0=false 
(default))\n\n

causes the unknown option for the serialize-only-query param to disappear

- commit of src/util/win32/dirent.h should be mentioned in NOTICE.xml
- I don't really like the name serializeToOutputStream. Why can't it just be 
serialize with one parameter?
- there is a todo left # todo cezar compile and jar it up
- I didn't find a test for the new serializeToOutputStream or getStream 
functions? I think it would be good to have some tests.
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/97105
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-03-14 Thread Chris Hillery
Review: Needs Fixing

Agreed with Matthias's comments.

Regarding DECLARE_ZORBA_JAR(), it looks like the commented-out macro is an 
older version, and the newer version is not commented-out. The older one should 
just be deleted.

Couple more comments:

- Do we also need to mention the addition of swig/various.i in NOTICE.xml? It 
has a comment saying it's from the SWIG package directly.

- Wasn't the class name IStream causing a build conflict on Windows?

- The call to init_val() in zorbacmdproperties_base.h should be on a separate 
line. (I know it was cut-and-pasted from above, but ugh.)

- Why is the method for retrieving the PropertiesGlobal* called 
getProperties()? Shouldn't that be getProperiesGlobal()? (Or, IMHO, 
getGlobalProperties() and rename the class to GlobalProperties.)

- Similarly, why is the factory method for PropertiesGlobal 
Properties::instance()? (The Zorba Properties stuff has always seemed like a 
mishmash to me; this isn't helping.)

- Need to fix the conflict in ExternalModules.conf.

- Typo: singelton in zorba.h.
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/97105
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba

2012-03-13 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: 

text conflict in modules/ExternalModules.conf
-- 
https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/97105
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp