Re: [Zorba-coders] [Merge] lp:~matthias-brantner/zorba/caching into lp:zorba

2011-12-01 Thread Markos Zaharioudakis
I think there is a bug in user_function::computeResultCaching, starting at line 542. The condition: if (lExplicitCacheRequest) appears twice and theCacheResults will actually be set to true if the udf is sequential or non-deterministic. -- https://code.launchpad.net/~matthias-brantner/zorba/cac

Re: [Zorba-coders] [Merge] lp:~matthias-brantner/zorba/caching into lp:zorba

2011-12-01 Thread Markos Zaharioudakis
Matthias, can you change the ownership to zorba-coders so that I can do some small changes (documentation and style)? -- https://code.launchpad.net/~matthias-brantner/zorba/caching/+merge/82787 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorb

Re: [Zorba-coders] [Merge] lp:~matthias-brantner/zorba/caching into lp:zorba

2011-11-21 Thread Zorba Build Bot
The attempt to merge lp:~matthias-brantner/zorba/caching into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:272 (message): Validation queue job caching-2011-11-21T22-11-29.225Z is finished. The final sta

Re: [Zorba-coders] [Merge] lp:~matthias-brantner/zorba/caching into lp:zorba

2011-11-16 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~matthias-brantner/zorba/caching/+merge/82483 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.

Re: [Zorba-coders] [Merge] lp:~matthias-brantner/zorba/caching into lp:zorba

2011-11-16 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~matthias-brantner/zorba/caching/+merge/82483 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-co

Re: [Zorba-coders] [Merge] lp:~matthias-brantner/zorba/caching into lp:zorba

2011-11-16 Thread Matthias Brantner
Adressed comments 1-4. -- https://code.launchpad.net/~matthias-brantner/zorba/caching/+merge/82482 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zor

Re: [Zorba-coders] [Merge] lp:~matthias-brantner/zorba/caching into lp:zorba

2011-11-08 Thread Markos Zaharioudakis
Here are a few problems I can see so far: 1. I don't think we can do function caching for variadic functions. The current implementation of user_function::computeResultCaching certainly does not support variadic functions, but more importantly, we need a fixed number of params to form the index

Re: [Zorba-coders] [Merge] lp:~matthias-brantner/zorba/caching into lp:zorba

2011-11-04 Thread Zorba Build Bot
The attempt to merge lp:~matthias-brantner/zorba/caching into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:272 (message): Validation queue job caching-2011-11-04T17-29-08.827Z is finished. The final sta