Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1025622 into lp:zorba
Review: Needs Fixing http://json.org/ says that not only '' and '\' need to be escaped with a backslash but also a solidus '/'. And, some control characters have special backspace escapes: backspace (x8 - \b), formfeed (xC - \f), newline (xA - \n), carriage return (xD - \r) and HTab (x9 - \t). Currently, they are serialized as hex. I would propose to add tests for those as well. -- https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1025622 into lp:zorba
json.org says that '/' *MAY* be escaped, but it's not *REQUIRED* for it to be so. As for the rest, I've added code to emit them. (The original code didn't emit them either.) Note that it wasn't wrong, just less pretty. I added a test (within the limits of what Zorba accepts in characters). -- https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1025622 into lp:zorba
Review: Needs Fixing cannot test it on windows as it doesn't currently build on windows (this doesn't have anything to do with this branch). on linux: The following tests FAILED: 1104 - test/rbkt/zorba/jsoniq/coll_dyn_03 (Failed) -- https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1025622 into lp:zorba
I think that query is wrong since there are newline literals in strings rather than \n. -- https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1025622 into lp:zorba
Actually, the query may be OK, but the expected result is wrong. I've fixed it. -- https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1025622 into lp:zorba
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1025622 into lp:zorba
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1025622 into lp:zorba
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1025622 into lp:zorba
Review: Needs Fixing Cool, thanks. Please add a couple test cases including the problem query described in the bug report; also, add a note to the Changelog mentioning the bug fix. -- https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1025622 into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Approve, 1 Needs Fixing, 1 Pending. -- https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1025622 into lp:zorba
I added a mention in the change log and also the one test (can't think of others). -- https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1025622 into lp:zorba
s/supplementory/supplementary/ -- https://code.launchpad.net/~paul-lucas/zorba/bug-1025622/+merge/115636 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
