Re: [Zorba-coders] [Merge] lp:~sorin.marian.nasoi/zorba/xqdoc_fixes into lp:zorba

2011-10-05 Thread Matthias Brantner
Review: Approve

Looks good to me.
-- 
https://code.launchpad.net/~sorin.marian.nasoi/zorba/xqdoc_fixes/+merge/78150
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~sorin.marian.nasoi/zorba/xqdoc_fixes into lp:zorba

2011-10-05 Thread Sorin Marian Nasoi
> > > What is the google analytics change about?
> > The
> > www.w3.org_2005_xpath-functions.html
> > and
> > www.w3.org_2005_xpath-functions_math.html
> > are not generated every time 'make xqdoc' is called, they are treated as
> > templates.
> >
> > After fixing the issues described I also fixed an issue that was missed by
> > Cezar's commit described in @coders thread "Re: [Zorba-coders] XQDoc has no
> > google tracker" from Wed, Sep 14, 2011 at 10:29 PM
> >
> > I tried to identify the actual revision no and who reviewed it by I could
> not.
> > I see no commit from Cezar on Sept 14th:
> > http://bazaar.launchpad.net/~zorba-
> > coders/zorba/trunk/changes/10488?start_revid=10488
> 
> I see but all the other module pages don't contain the tracking if regenerated
> from the source. This should be fixed.

I added the Google Analytics part to all XQDoc documentation pages.
-- 
https://code.launchpad.net/~sorin.marian.nasoi/zorba/xqdoc_fixes/+merge/78150
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~sorin.marian.nasoi/zorba/xqdoc_fixes into lp:zorba

2011-10-04 Thread Matthias Brantner
> > What is the google analytics change about?
> The
> www.w3.org_2005_xpath-functions.html
> and
> www.w3.org_2005_xpath-functions_math.html
> are not generated every time 'make xqdoc' is called, they are treated as
> templates.
> 
> After fixing the issues described I also fixed an issue that was missed by
> Cezar's commit described in @coders thread "Re: [Zorba-coders] XQDoc has no
> google tracker" from Wed, Sep 14, 2011 at 10:29 PM
> 
> I tried to identify the actual revision no and who reviewed it by I could not.
> I see no commit from Cezar on Sept 14th:
> http://bazaar.launchpad.net/~zorba-
> coders/zorba/trunk/changes/10488?start_revid=10488

I see but all the other module pages don't contain the tracking if regenerated 
from the source. This should be fixed.
-- 
https://code.launchpad.net/~sorin.marian.nasoi/zorba/xqdoc_fixes/+merge/78150
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~sorin.marian.nasoi/zorba/xqdoc_fixes into lp:zorba

2011-10-04 Thread Sorin Marian Nasoi
> What is the google analytics change about?
The 
www.w3.org_2005_xpath-functions.html
and 
www.w3.org_2005_xpath-functions_math.html
are not generated every time 'make xqdoc' is called, they are treated as 
templates.

After fixing the issues described I also fixed an issue that was missed by 
Cezar's commit described in @coders thread "Re: [Zorba-coders] XQDoc has no 
google tracker" from Wed, Sep 14, 2011 at 10:29 PM

I tried to identify the actual revision no and who reviewed it by I could not.
I see no commit from Cezar on Sept 14th:
http://bazaar.launchpad.net/~zorba-coders/zorba/trunk/changes/10488?start_revid=10488
-- 
https://code.launchpad.net/~sorin.marian.nasoi/zorba/xqdoc_fixes/+merge/78150
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~sorin.marian.nasoi/zorba/xqdoc_fixes into lp:zorba

2011-10-04 Thread Matthias Brantner
What is the google analytics change about?
-- 
https://code.launchpad.net/~sorin.marian.nasoi/zorba/xqdoc_fixes/+merge/78150
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp