Review: Approve
I did not like very much the versioning solution for the collection deadlock.
It certainly does not work with multi-threading. But this is not the only thing
that is wrong for multi-threading, so I will approve.
I think a better solution would be that any dml:collection()
Review: Approve
I did not like very much the versioning solution for the collection deadlock.
It certainly does not work with multi-threading. But this is not the only thing
that is wrong for multi-threading, so I will approve.
I think a better solution would be that any dml:collection()
Thanks for the feedback.
Merging
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1026250/+merge/138044
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Thanks for the review.
Can you explain me why
SYNC_CODE(theCollection-theLatch.rlock();)
and
SYNC_CODE(theCollection-theLatch.unlock();)
has been commented in this branch?
They were already commented in the branch when I started working on it.
They were causing a deadlock when the
Thanks for the review.
Can you explain me why
SYNC_CODE(theCollection-theLatch.rlock();)
and
SYNC_CODE(theCollection-theLatch.unlock();)
has been commented in this branch?
They were already commented in the branch when I started working on it.
--
Ready for review
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1026250/+merge/138044
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
One of the tests uses ext:nomaterialization without dash. Is this intented?
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1026250/+merge/138044
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
nope, let me fix it
On Wed, Aug 14, 2013 at 3:14 PM, Ghislain Fourny ghislain.fou...@28msec.com
wrote:
One of the tests uses ext:nomaterialization without dash. Is this intented?
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1026250/+merge/138044
Your team Zorba Coders is
Fixed and pushed
On Wed, Aug 14, 2013 at 9:36 PM, Federico Cavalieri
federico.cavali...@28msec.com wrote:
nope, let me fix it
On Wed, Aug 14, 2013 at 3:14 PM, Ghislain Fourny
ghislain.fou...@28msec.com wrote:
One of the tests uses ext:nomaterialization without dash. Is this
intented?
Nice change.
The modifications in the following files don't seem to be needed:
- test/rbkt/Queries/zorba/updates/flwor1.xq
- test/rbkt/Queries/zorba/scripting/flwor6.xq
- test/rbkt/Queries/zorba/updates/flwor1.xq
- test/rbkt/Queries/zorba/no-copy/dataguide-c.xq
I'll add Markos as a second
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1026250/+merge/138044
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Matthias will get this scheduled within 28msec, hopefully soon.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1026250/+merge/138044
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Please put a more descriptive commit message for this change.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1026250/+merge/138044
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
I modified test flwor10.xq to be:
declare namespace ext = http://www.zorba-xquery.com/extensions;;
variable $x := 0;
(# ext:materialize #) {
for $i in (1, 2, 3)
let $y := { $x := $x + $i; () }
return $x
}
ran it and got:
Zorba error [zerr:ZXQP0002]: false: assertion failed with the
Of the failing tests, only some have been modified. If you changed the default
behavior, shouldn't you also have to change every affected test by adding the
pragma?
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1026250/+merge/138044
Your team Zorba Coders is subscribed to branch
The attempt to merge lp:~zorba-coders/zorba/bug-1026250 into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job bug-1026250-2012-12-05T01-32-06.304Z is finished. The
final
16 matches
Mail list logo
